From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, gregory.clement@bootlin.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rui Salvaterra <rsalvaterra@gmail.com>
Subject: Re: [PATCH] ARM: dts: turris-omnia: fix hardware buffer management
Date: Wed, 17 Feb 2021 17:27:18 +0100 [thread overview]
Message-ID: <20210217172718.6fdf412e@kernel.org> (raw)
In-Reply-To: <YC1CuWnLQju7wMl2@lunn.ch>
On Wed, 17 Feb 2021 17:22:17 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
> > Hardware buffer management has never worked on the Turris Omnia, as the
> > required MBus window hadn't been reserved. Fix thusly.
>
> Hi Rui
>
> I don't know all the details for the MBus Windows...
>
> Can this be set once in armada-385.dtsi ?
>
> Did you check the other dts files. Do any others have the same
> problem?
>
> Andrew
armada-38x.dtsi defines only
ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
for internal-regs.
It probably depends on how the mbus driver works.
If the mbus driver maps every window defined in ranges, regardless
whether they are used, then we do not want to put all windows in .dtsi
file.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-17 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 15:30 [PATCH] ARM: dts: turris-omnia: fix hardware buffer management Rui Salvaterra
2021-02-17 15:42 ` Marek Behún
2021-02-17 15:44 ` Rui Salvaterra
2021-02-17 16:02 ` Marek Behún
2021-02-17 16:10 ` Marek Behún
2021-02-17 16:12 ` Rui Salvaterra
2021-02-17 16:22 ` Andrew Lunn
2021-02-17 16:27 ` Marek Behún [this message]
2021-02-17 16:31 ` Rui Salvaterra
2021-03-15 18:08 ` Klaus Kudielka
2021-04-02 20:13 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217172718.6fdf412e@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).