From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31E6C433DB for ; Thu, 18 Feb 2021 09:34:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 763FA64D99 for ; Thu, 18 Feb 2021 09:34:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 763FA64D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SHrF+aDZsWcLc+rxxA3EhvkPF6mXDORyCOiSmxIWd0M=; b=FMWxMbJ1X0vbnKmEFmsaTcqmn wQTzvhIvu2E6ciFet6+t6aJTxkd29qfWYtw4BiH3eSO0bst6MGc9WU6Abmsi3Q7KX5ngTarfwIhBb uU11N8O8aundhnaA8ozSo66fRNQMPFwDasNd5m8fXQz1ZfLBlpA5IMej9KUVOtB0cjK4x4betGtxy uVD2qMg9rnnqddbEYcbqzdfPC5hFGfMZEBem6dw8+2I25IfTwSTprgebfzXkufL13Kf28pjyKt9Yg QD9jxEognrAvThHPYaxtmuQ9jMLesB7kGrMekVJpkqfjXaYBk1V+qAV/JfwhlI7udYFuTzzkJDdSL 9q7KJlfqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCfgN-0005Bm-TZ; Thu, 18 Feb 2021 09:33:11 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCfgL-0005BE-I5 for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 09:33:10 +0000 Received: by mail-pf1-x42e.google.com with SMTP id j12so887080pfj.12 for ; Thu, 18 Feb 2021 01:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y5EFtSLD4pZwQqPui08w/f2nE8Hwd/5PWKGDMrasgPw=; b=ub6w3IbLaHAJBI8T1/E7fc+lPKRpfl2lCVPqMHjAO91msiqm4Lgx0xCmnaD3GDJDTt TzNiCxHc3exT3ESMIdBvSF1OX+RSV0YxVoSw1bz3BPaBOKFz/USzcqHuKgejPxAuFIbf 8cv0ZIt+YaGr5pNGksGFPAL0bjfXVRcU26b8Je/4Se95WXnLj2RTRYjFdWYWzw8plKCD z5HR+0gTWVmlgDLRZzq2z2D0f9jubn13lunrGNof8p8e5GFM/nM+2lAZpSLhujLzMihI cMPJfZKO3GWu31Ctr5b2JJaYD9bDM5p8DzdzLOJLm1ZfLZq5NrfF3R/5H40g7G7Ph1fw EpXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y5EFtSLD4pZwQqPui08w/f2nE8Hwd/5PWKGDMrasgPw=; b=FgmQBq0TYm8eV0rs0E0LadJwxiE5M+fGevmzboiCpqYqKis40a9u51754Kk3AeobXD HeFlVlKhdwPjW9Lixn6hAp8R+vyrIUmpxSoMZ62bTlo53+k3uaRHv3CiN36tSuMHGfCV DA+wf4Fj5Y4+yjZ3rLmeUrKgjZfx4mpXiaRNzkXZFUtbl2qGYBQzcc90Sa7tvAda0Qgy WNaM0WHgzl3lEcB6MdQNifeKB1wt6p95SlRk9fpCuknoyjFb8QGZgOjhaReUXZ3YjC1h JgCorZ2W/FOVSz5mmGBg7cg0i+nAmSYU9Z61ml1IT0F24Uglgx7rflidW7ts/dqkhiJ1 pK7w== X-Gm-Message-State: AOAM530t/Bn/KIvEioVbq2tjc3czE+qHfuy5xuWYuuiwc0VDSl8B6CsN siJXujD/H/XTToiu9xh7YMb4fQ== X-Google-Smtp-Source: ABdhPJzmWDkUF+XEu/Fd7S8XY6GJ1/Rv+yNGyliwnb2m8eSYg//p5LFdVT71/My0rSPWXYmE0uBSaA== X-Received: by 2002:a63:2b82:: with SMTP id r124mr3295183pgr.310.1613640787362; Thu, 18 Feb 2021 01:33:07 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id s11sm5145642pfu.69.2021.02.18.01.33.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 01:33:06 -0800 (PST) Date: Thu, 18 Feb 2021 15:03:04 +0530 From: Viresh Kumar To: Ionela Voinescu Subject: Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Message-ID: <20210218093304.3mt3o7kbeymn5ofl@vireshk-i7> References: <20210203114521.GA6380@arm.com> <20210205091424.3od3tme3f7mh7ebp@vireshk-i7> <20210217002422.GA17422@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210217002422.GA17422@arm.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_043309_657313_38F364A2 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , linux-pm@vger.kernel.org, Catalin Marinas , Rafael Wysocki , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sudeep Holla , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17-02-21, 00:24, Ionela Voinescu wrote: > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > > index 1e47dfd465f8..47fca7376c93 100644 > > --- a/arch/arm64/kernel/topology.c > > +++ b/arch/arm64/kernel/topology.c > > @@ -240,7 +240,6 @@ static struct scale_freq_data amu_sfd = { > > > > static void amu_fie_setup(const struct cpumask *cpus) > > { > > - bool invariant; > > int cpu; > > > > /* We are already set since the last insmod of cpufreq driver */ > > @@ -257,25 +256,10 @@ static void amu_fie_setup(const struct cpumask *cpus) > > > > cpumask_or(amu_fie_cpus, amu_fie_cpus, cpus); > > > > - invariant = topology_scale_freq_invariant(); > > - > > - /* We aren't fully invariant yet */ > > - if (!invariant && !cpumask_equal(amu_fie_cpus, cpu_present_mask)) > > - return; > > - > > You still need these checks, otherwise you could end up with only part > of the CPUs setting a scale factor, when only part of the CPUs support > AMUs and there is no cpufreq support for FIE. Another look at it and here goes another reason (hope I don't have another in-code comment somewhere else to kill this one) :) We don't need to care for the reason you gave (which is a valid reason otherwise), as we are talking specifically about amu_fie_setup() here and it gets called from cpufreq policy-notifier. i.e. we won't support AMUs without cpufreq being there in the first place and the same goes for cppc-driver. Does that sound reasonable ? -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel