From: Viresh Kumar <viresh.kumar@linaro.org>
To: Nicola Mazzucato <nicola.mazzucato@arm.com>
Cc: linux-pm@vger.kernel.org, vireshk@kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, cristian.marussi@arm.com,
sudeep.holla@arm.com, chris.redpath@arm.com,
ionela.voinescu@arm.com, morten.rasmussen@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/3] scmi-cpufreq: Remove deferred probe
Date: Thu, 18 Feb 2021 16:05:39 +0530 [thread overview]
Message-ID: <20210218103539.zkxhqxaivhifmjwj@vireshk-i7> (raw)
In-Reply-To: <20210215075139.30772-2-nicola.mazzucato@arm.com>
On 15-02-21, 07:51, Nicola Mazzucato wrote:
> The current implementation of the scmi_cpufreq_init() function returns
> -EPROBE_DEFER when the OPP table is not populated. In practice the
> cpufreq core cannot handle this error code.
> Therefore, fix the return value and clarify the error message.
>
> Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index 491a0a24fb1e..34bf2eb8d465 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -155,9 +155,11 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
>
> nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
> if (nr_opp <= 0) {
> - dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
> - ret = -EPROBE_DEFER;
> - goto out_free_opp;
Why change goto label as well ?
> + dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
> + __func__, ret);
> +
> + ret = -ENODEV;
> + goto out_free_priv;
> }
>
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> --
> 2.27.0
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-18 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 7:51 [PATCH v7 0/3] CPUFreq: Add support for opp-sharing cpus Nicola Mazzucato
2021-02-15 7:51 ` [PATCH v7 1/3] scmi-cpufreq: Remove deferred probe Nicola Mazzucato
2021-02-18 10:35 ` Viresh Kumar [this message]
2021-02-18 13:01 ` Nicola Mazzucato
2021-02-15 7:51 ` [PATCH v7 2/3] scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM Nicola Mazzucato
2021-02-18 11:00 ` Viresh Kumar
2021-02-18 13:02 ` Nicola Mazzucato
2021-02-15 7:51 ` [PATCH v7 3/3] cpufreq: blacklist Arm Vexpress platforms in cpufreq-dt-platdev Nicola Mazzucato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218103539.zkxhqxaivhifmjwj@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=chris.redpath@arm.com \
--cc=cristian.marussi@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=nicola.mazzucato@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).