From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
linux-pm@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback
Date: Fri, 19 Feb 2021 10:28:23 +0530 [thread overview]
Message-ID: <20210219045823.beeijwaymd63prk7@vireshk-i7> (raw)
In-Reply-To: <20210218163635.GA23622@arm.com>
On 18-02-21, 16:36, Ionela Voinescu wrote:
> Yes, we don't care if there is no cpufreq driver, as the use of AMUs won't
> get initialised either. But we do care if there is a cpufreq driver that
> does not support frequency invariance, which is the example above.
>
> The intention with the patches that made cpufreq based invariance generic
> a while back was for it to be present, seamlessly, for as many drivers as
> possible, as a less than accurate invariance default method is still
> better than nothing.
Right.
> So only a few drivers today don't support cpufreq based FI
Only two AFAICT, both x86, and the AMU stuff doesn't conflict with
them.
drivers/cpufreq/intel_pstate.c
drivers/cpufreq/longrun.c
> but it's not a guarantee that it will stay this way.
What do you mean by "no guarantee" here ?
The very core routines (cpufreq_freq_transition_end() and
cpufreq_driver_fast_switch()) of the cpufreq core call
arch_set_freq_scale() today and this isn't going to change anytime
soon. If something gets changed there someone will need to see other
parts of the kernel which may get broken with that.
I don't see any need of complicating other parts of the kernel like,
amu or cppc code for that. They should be kept simple and they should
assume cpufreq invariance will be supported as it is today.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-19 5:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 10:48 [PATCH V3 0/2] cpufreq: cppc: Add support for frequency invariance Viresh Kumar
2021-01-28 10:48 ` [PATCH V3 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Viresh Kumar
2021-02-03 11:45 ` Ionela Voinescu
2021-02-05 9:14 ` Viresh Kumar
2021-02-17 0:24 ` Ionela Voinescu
2021-02-17 4:25 ` Viresh Kumar
2021-02-17 11:30 ` Ionela Voinescu
2021-02-17 11:40 ` Viresh Kumar
2021-02-17 11:57 ` Ionela Voinescu
2021-02-18 7:23 ` Viresh Kumar
2021-02-18 9:33 ` Viresh Kumar
2021-02-18 16:36 ` Ionela Voinescu
2021-02-19 4:58 ` Viresh Kumar [this message]
2021-02-19 9:44 ` Ionela Voinescu
2021-02-19 9:48 ` Viresh Kumar
2021-01-28 10:48 ` [PATCH V3 2/2] cpufreq: cppc: Add support for frequency invariance Viresh Kumar
2021-02-18 16:35 ` Ionela Voinescu
2021-02-22 11:00 ` Ionela Voinescu
2021-02-22 11:04 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219045823.beeijwaymd63prk7@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).