From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695E0C433DB for ; Wed, 24 Feb 2021 16:15:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D53564E6C for ; Wed, 24 Feb 2021 16:15:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D53564E6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ApVv/yN1oy+hKFR4Nw9RppAUDkCtgouq2fBRThvxPo4=; b=rsf9Uxn78x+e5HjZCnfNEeRPt lJF6J25TvrvyqM0BGQxr44pMJvnWHHm8SYVRLn6jH3j3Hh2hmMfdQ6PFlSaf32h8xz0HzC6I/Eccd UUHXWWIgEwN4E+JY3SSEMk5OcLT6tkJPtJUVdCpPZozgltJ9HljepTNfWWIByvHLCAS8BKx5oa6I8 bX3x1gqzOTYrrfRNxb1ETgmoLEAoZOQ2za52WuMgs3QofxE9FPMlESwBu16gU/mD42sCGSAI5vViX 3q8QYi5JS5H/oYF0MnkbD5OOKIouQi5Bc8f0kTgya+HY4QwpsGAp9WOz1tlYOrU9E8eck4tsz098E G/mTim0BA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEwn4-0002KJ-2N; Wed, 24 Feb 2021 16:13:30 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEwn1-0002Jo-Af for linux-arm-kernel@lists.infradead.org; Wed, 24 Feb 2021 16:13:28 +0000 Received: by mail-pg1-x535.google.com with SMTP id t11so1749034pgu.8 for ; Wed, 24 Feb 2021 08:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3FZdsf6XJR67eODXmbRF6cVAh1XeOXuhlF5t976l7j4=; b=nyplz0egG1ZE6DKF+WBViBtTmkq57r1y4/WrOJRBP+zvNdbtVL9ro3/gUhjk0t3EJY knieBe+/Zqqj8EyI75aZuwydHXn6/glZ4/NlhqzvSo9H8u4iKqSh7t4ojxe7AORg7iTJ /tC7QLdPHHMFfdbQSsap88uhtwzjmh5GO555zmW9OTIGAdEPhWlTHeDmgzZXbKyxndlf jrBS9ld1Bv9+TQTaYtkHFsND+dClH/HUtywBlAxWI9i+8AwTmDoT5RTjInZwdqvKzgbd uRUmF6COHLQ8XGrIpBKuqD9KCaT40tl0Hpc/jaU0GIVGvkY91YUyjyylU1wB7VEZIF9i oFMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3FZdsf6XJR67eODXmbRF6cVAh1XeOXuhlF5t976l7j4=; b=jf0aRZSLXPKN2G8vV7T1BOWrXFKQVwZNs4BSkBEFKDv1IPTW47psEdzKueWk5lTZs0 wmKTSos/bPO5rufbAw/E50bAbg5SLDHfzPqljUM/51Ru2RSMpiBhX25HtWBVQkq55Jki P9wnOFxkUmhBGSVewh0n33rIpLo1+EyqFqMqduhclt31ThN50nIY2/WODSRyTZlPTnE6 YZkl7P11OubG/JCEM42i3AVOWFnybS5URA3GXNUlV6y71hNjyULIs6N0uu4BBMZFeJfG xfNA3MLMlSUVBFq6SGvVxXLpLxQHSih3sk3aMBsqOhcux30fLumAF9A3frB19zKTAHj2 b9Ew== X-Gm-Message-State: AOAM530tcmGOqYweQNHqGvYQdFoHjLhyypsEqMDLSx14Evbj+iC0iK7U 2MHsp/N+ww5tbfZIRwbgnAS0qQ== X-Google-Smtp-Source: ABdhPJx/DJXPG0XU6qb5mGGFjx1HgwHMwaiQcD3TQBk61ZFy/l3KG8Z04RbBxc7j/J8XkKrY4wuSew== X-Received: by 2002:a63:4e26:: with SMTP id c38mr3861088pgb.81.1614183202598; Wed, 24 Feb 2021 08:13:22 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id v4sm3054021pff.156.2021.02.24.08.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 08:13:22 -0800 (PST) Date: Wed, 24 Feb 2021 09:13:19 -0700 From: Mathieu Poirier To: James Clark Subject: Re: [PATCH 0/7] Split Coresight decode by aux records Message-ID: <20210224161319.GA3495326@xps15> References: <20210212144513.31765-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210212144513.31765-1-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_111327_453186_0111B50F X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , branislav.rankov@arm.com, al.grant@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Alexander Shishkin , Will Deacon , coresight@lists.linaro.org, John Garry , linux-kernel@vger.kernel.org, Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Good day James, I have received your patchset and added it to my queue. On the flip side it will be 3 to 4 weeks (from today) before I get a chance to look at it. As such I suggest you don't wait on me before addressing the issues found by Leo. Thanks, Mathieu On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open questions are: > * General approach > * If aux records need to be saved, or if they can be pulled > from elsewhere. > > I've also tested perf inject which is now working with troublesome > files. > > Thanks > James > > James Clark (7): > perf cs-etm: Split up etm queue setup function > perf cs-etm: Only search timestamp in current sample's queue. > perf cs-etm: Save aux records in each etm queue > perf cs-etm: don't process queues until cs_etm__flush_events > perf cs-etm: split decode by aux records. > perf cs-etm: Use existing decode code path for --dump-raw-trace > perf cs-etm: Suppress printing when resetting decoder > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- > tools/perf/util/cs-etm.c | 300 ++++++++++-------- > 2 files changed, 168 insertions(+), 142 deletions(-) > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel