From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FE8C433DB for ; Thu, 25 Feb 2021 09:08:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EB8364F0E for ; Thu, 25 Feb 2021 09:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB8364F0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hS91HUP2J93bHrrrTTCSOuGJ1qMySwjd67DBd57pPYA=; b=k9tVgRUiHkbhcrGjh0Non53eZ 8Z8s50en9U9MXpshDimtOJnPPAb/IJzWk0RFOUkfTt5cRf7LHMEG4zAmoE6JI4lZfFhk2ayNH0TH4 mBhZMuftrX1n/nE2C1GN4CamBzT2BnFD8Sn+VXNRN1/rgUUZKCiWVkdGf80FfP8SRWVUjO5Q1/6XJ ZREW5/0SQzf29bDtM8I5q8lNLxJOxDJztSTBuSux5p66hRcg0Xdu+MkiFCkUYbQds3y1DFC3apdSH RynIO2otOdma1jPFVsPWY27gwwgnqfXFF5eI8lxPKio6DQGsbojFBv5C4ouD18VFociChziZatBwX DunqRW3cA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFCbb-0003m7-M7; Thu, 25 Feb 2021 09:06:43 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFCbW-0003kd-1r for linux-arm-kernel@lists.infradead.org; Thu, 25 Feb 2021 09:06:38 +0000 Received: by mail-pg1-x52d.google.com with SMTP id o10so3368406pgg.4 for ; Thu, 25 Feb 2021 01:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XDTZ33fjLbE2/tgGk4BUqIi9+Z24fcyTW3i1iRPooGA=; b=n7e8Rw3AVuSWzHat8SJs5B0TxUQEamnDc6kCmvsEN1ECxIv0PK4eCwkMudmQbYUCzC DS6i+KU4/Lmc7pU9bJd862r3RsY4FFF8AtWEdPtOsHW7ZecFr/yLkzwcS5q43IUmiOG6 DlFOCVUJ5mSYemsrdAN5ZzW2vxId9WU6QBP91Y3hZdwxW7kI7g0bf2tA1W0OTVxPjXRj HXwN4Jxl6gUYOwPyUmTTmPm73cHjzPYPtRtHAhMkkQgDkRELidKNlYS43mVRovV3I2HF jSPDCcI0o6LnjFHtoLwkc0d5FlZEv5QzFFx4DwideGT9lvNxgE7jRWiKlbpw8udnQXe3 7rzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XDTZ33fjLbE2/tgGk4BUqIi9+Z24fcyTW3i1iRPooGA=; b=DbSs/b27ezo9rK1nPagKeUqZt04pASon2beFiR7/BGsvny2z2iIosQbOYdvm8lWlNx HP+dygeiftJElFI4/QxmKrOmstrakN/2jOmGMYE/WfU+LtY9KmGBrB0JYNiW9Ppnt9td lPzmo22hB5MgBYumkkVfn+esZTOLIm5UcYNCbLhvMFSyP1A4e56ilcTI+EGT6gG472qK LX9j/ICCg/wT5WWmcuQL26Ji5lltyjY1pIwBNuLcDyem+tEYrbXFHN7sDOkCo/O7UmJW 3A8X7CQOED6cMsp4Maf/C1qNTnQJPXhMaExF/zITrqP6N/ngid9jl1hiD35AhZtwUEeW qdYg== X-Gm-Message-State: AOAM5307GuHAN5PI9jN0ixJMpgel3FUMAWaZHqIVSbzK+3DGBDbKrx5p QOwpB0dY6vzPdMBwLs62+BI= X-Google-Smtp-Source: ABdhPJwVS1uC0P1ohEib08/wGhPLo8oCIymghGRpA2CD6+kCe1O9HQ0O7l1XKktl8V3dFnHDcjFlrA== X-Received: by 2002:a62:a108:0:b029:1c1:119b:8713 with SMTP id b8-20020a62a1080000b02901c1119b8713mr2341428pff.74.1614243995660; Thu, 25 Feb 2021 01:06:35 -0800 (PST) Received: from localhost.localdomain ([49.207.194.79]) by smtp.gmail.com with ESMTPSA id n11sm5098373pgm.30.2021.02.25.01.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 01:06:35 -0800 (PST) From: Allen Pais To: jens.wiklander@linaro.org, zajec5@gmail.com Subject: [PATCH v2 2/2] firmware: tee_bnxt: implement shutdown method to handle kexec reboots Date: Thu, 25 Feb 2021 14:36:10 +0530 Message-Id: <20210225090610.242623-3-allen.lkml@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210225090610.242623-1-allen.lkml@gmail.com> References: <20210225090610.242623-1-allen.lkml@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_040638_287634_08B15518 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Allen Pais , op-tee@lists.trustedfirmware.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Allen Pais On kexec reboot the firmware driver fails to deallocate shm memory leading to a memory leak. Implement .shutdown() method to handle kexec reboots and to release shm buffers correctly. Signed-off-by: Allen Pais --- drivers/firmware/broadcom/tee_bnxt_fw.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index ed10da5313e8..4c62e044a99f 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -242,6 +242,14 @@ static int tee_bnxt_fw_remove(struct device *dev) return 0; } +static void tee_bnxt_fw_shutdown(struct device *dev) +{ + tee_shm_free(pvt_data.fw_shm_pool); + tee_client_close_session(pvt_data.ctx, pvt_data.session_id); + tee_client_close_context(pvt_data.ctx); + pvt_data.ctx = NULL; +} + static const struct tee_client_device_id tee_bnxt_fw_id_table[] = { {UUID_INIT(0x6272636D, 0x2019, 0x0716, 0x42, 0x43, 0x4D, 0x5F, 0x53, 0x43, 0x48, 0x49)}, @@ -257,6 +265,7 @@ static struct tee_client_driver tee_bnxt_fw_driver = { .bus = &tee_bus_type, .probe = tee_bnxt_fw_probe, .remove = tee_bnxt_fw_remove, + .shutdown = tee_bnxt_fw_shutdown, }, }; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel