From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861A0C433DB for ; Tue, 2 Mar 2021 09:15:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19D6564DE4 for ; Tue, 2 Mar 2021 09:15:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19D6564DE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kHdCHqNRmplwjY5zNOrPVBvpmwLxt0Xyh+CF1f1b+NY=; b=HMPQgqFGDBZnIke8tZSD7shdD qQ51OGy84ZUcaN9/O6SDgukqwOrfdxEFdZ8hlq/wYUz1RilHd9fjmZ7n5Gosok3Vx1KoOP0DmC+bN ipNr8ozMbbHIyVs5W6EiDMbW7wbal2kWEbeXQCRmaazfo09PmD7TTzHUt+DVmua7ttl9BVcDo5p+G xc3PHY5r+cJfS/Ysku7U1OnSlRfmOH40PbuOJX935qcrkaWe0OpJOEuQlEe4ju+Snm8SpFO7CSAv1 oX1uCwJbA54BNGtmr3IHuPVDl8ZP0fRjMtle3gXbCm25UPoPcFu98t/iVO4XZTtvzFSpDNOAlz0OO QXh0ucuIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lH16k-0000Vl-Bl; Tue, 02 Mar 2021 09:14:22 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lH16g-0000VJ-5z for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 09:14:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9FA445C01A5; Tue, 2 Mar 2021 04:14:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 02 Mar 2021 04:14:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=A9mpeix8eIp2s1AceaFq/lclm0J BGCKdgDe9/or40Kg=; b=dyeSZxf5f31DgJriNDJSMv0u9comdhk0hWwyrx61M8d 1RlI0b2um4bsNnbjEanyukBF2VKDEsGEZG1RuxC84iU5qhAB71vz8D8Gp/gY3dLj RaDgr+bjIGfF+6x2PkRS0iHEdyf3NhkXPKxdGI9Zikzq5VRFo3Yxs82SzTeRqNJE 2FFUpkKrf957i6Au2fv8NpMWqSM2xcXnYQs7dGQ4dOAk/FL98PEc/Ijn7kTsk2Vr w9gBHIKYUrtVgepFavxe7TRQlbRntYBY13p3vkxoBYO3kPKI5w0JRLxINg6VBnRp 0ylNqW2eRgoRUYxdLHcbiTyy4KfRUl48VsWOPj2p19g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=A9mpei x8eIp2s1AceaFq/lclm0JBGCKdgDe9/or40Kg=; b=Kbi5wDpbLPLm+5PfnDZulN 0Lph8igiPRWZBZi5+sH5Au4ODaRJn16pXm7vtLLdWofN9jJiD+xMAzPLS8Ed/UDq 0Ds1ULdOZ/Pd/JZbrmePwftTBT/mGnYVqzV55OS/xgh1oRx2sBtJRnb9DE/L1TJ4 pgtm5xFrVMynDYf1SbymEPPMgrXvRi6cSaITuPWvfcQIvHAyNTjx4ZxgNv1Wg2Nj Ie+9fsfBq6ml7/GfLh2H6V4soz5W9yTiO7QsVz1lQwQK8OBBQoT9HG6njgD/x67A HP19CQ0Un9j6vMF1wxWCp8Q5M7jfVWvNOBMoyRx9SrJZz8HZnyhb5pD37+RaGeWA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddttdcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgvucft ihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtthgvrh hnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeguden ucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 69C6824005C; Tue, 2 Mar 2021 04:14:16 -0500 (EST) Date: Tue, 2 Mar 2021 10:14:14 +0100 From: Maxime Ripard To: Tobias Schramm Subject: Re: [PATCH 3/3] ARM: dts: sun8i: V3/S3: add i2s peripheral Message-ID: <20210302091414.ueqgrrb6fnkev423@gilmour> References: <20210226103028.729172-1-t.schramm@manjaro.org> <20210226103028.729172-4-t.schramm@manjaro.org> MIME-Version: 1.0 In-Reply-To: <20210226103028.729172-4-t.schramm@manjaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_041418_986516_F004C767 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0611504115879381365==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0611504115879381365== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xz7e52sol4iuhn2p" Content-Disposition: inline --xz7e52sol4iuhn2p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Feb 26, 2021 at 11:30:28AM +0100, Tobias Schramm wrote: > The V3 and S3 SoCs feature an i2s peripheral identical to that of the H3. > Add it to the dts. >=20 > Signed-off-by: Tobias Schramm Why is it added to the v3 DTSI and not the global one? > --- > arch/arm/boot/dts/sun8i-v3.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-v3= =2Edtsi > index c279e13583ba..17ea6b8f091f 100644 > --- a/arch/arm/boot/dts/sun8i-v3.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3.dtsi > @@ -30,3 +30,18 @@ uart1_pg_pins: uart1-pg-pins { > function =3D "uart1"; > }; > }; > + > +&soc { You don't need a label for that, you can just put it under / { soc { > + i2s0: i2s@1c22000 { > + #sound-dai-cells =3D <0>; > + compatible =3D "allwinner,sun8i-h3-i2s"; We should also have a v3 specific compatible here in addition to the H3 (and document it in the bindings). Maxime --xz7e52sol4iuhn2p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYD4B5gAKCRDj7w1vZxhR xUu/AQCuOWEK7caX1VDLjoJIm0vhVD4eR1diftDPaIkE/qnDvgD/QeIJImkxu0FR vBYEx/1tkyYo8qzFb5WXZ5Bsj6SYOAI= =JV2a -----END PGP SIGNATURE----- --xz7e52sol4iuhn2p-- --===============0611504115879381365== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0611504115879381365==--