From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACA0C433E9 for ; Thu, 4 Mar 2021 01:01:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19DF564F0B for ; Thu, 4 Mar 2021 01:01:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19DF564F0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HNj0ULwuJPdVXlfAlW/pgGxGVlDasqedhb/2Q7e0+1Q=; b=Oo/oK4qPRFljaibpAcpbN/m+V AMrqBUWPBl1IPPXNSlzRSnTjLfLTCVUdJXZQBD5kO2UYq2T3Ww/ov1bvPgzIUUQKByXTqJ+G4QRPC prfz1PMvV0ERxwjRnNArOASnVw0YbKYtnOoHZxVFhZJnKTxXrX+lgB0tizVW5J/Re7ufSVXN2/mm6 bkCW9bPMFqH3lIC3u2JCxjwG7GsnpLSoR+QllHkizePaxVAhEjI7+ip1GVR9QzycEp5de8wX+TA6C Yo4pw9vexjWmcsZHbrYgWQEWRWAHRcWyNoK8N2ITYmRGbT8w9EXRVpPKvrLgiJy7VQHCHo68UMlRH 964mlGEqQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHcJV-007Fuf-3P; Thu, 04 Mar 2021 00:58:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHXtw-006Nyi-5Y for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 20:15:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3597464F0F; Wed, 3 Mar 2021 20:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614802514; bh=lpBTFCTcM7T/xDd6aulHsmCh03qW4xPBhqa8QmAamCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pL6dUUnEg4iFRCcXe+oyaqiqm48ajxuBkE2NVtd+HFkJcKFFAosGElunmdvbrz7W/ b+ECHZ5OkHrzCwsIxFPybBtmSalXJIBWBD5Pcd5mPun+Udm9ucdJz/qhT7nj/oU32a Um970NsIrjba0ZwoEz1nfYyPWh4qVJkQD4pH5SnfZBdWk7InbPxo2KVXJjeASEVHEj iZtLvG0UeRxnSWz2LdPEQZZvLvx+/yWIjWzCW8wzjWX2oUO//oddoEXEeu6DDvQ2YR YwuAw/Q38voWcVGfGoIJshSRSQlLRqsdBixYPREjTAdeolJ/5oqx4uzf3dLPBtr+Ty D9xKPk3/F186A== From: Mark Brown To: Catalin Marinas , Will Deacon Cc: Julien Grall , Zhang Lei , Dave Martin , Daniel Kiss , Julien Grall , linux-arm-kernel@lists.infradead.org, Mark Brown Subject: [PATCH v7 1/3] arm64/sve: Remove redundant system_supports_sve() tests Date: Wed, 3 Mar 2021 20:11:15 +0000 Message-Id: <20210303201117.24777-2-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210303201117.24777-1-broonie@kernel.org> References: <20210303201117.24777-1-broonie@kernel.org> MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; i=+RwXfULXEyOedqc/+Fa3w3GM71O+6mDf7cZ6Ezj6h9Y=; m=cyZpyZxDlnPm9p6fTR5Gp6BxpYr2qvSk10Lad6KDLRw=; p=ciYO5mgvbwirzdLD3MCLurfxCMKmqzieUVbabMApXUA=; g=b7d9cd6e52a7169e874621670f0a553525ef998a X-Patch-Sig: m=pgp; i=broonie@kernel.org; s=0xC3F436CA30F5D8EB; b=iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA/7V8ACgkQJNaLcl1Uh9DIVgf8DoV DMvhMfdyD+joHYp91S7eZxerx7OCAsiaBifwn8uPXTPbzGhqA/w62qP2h0h7i3SHIfMW9G3PczuRe cmcLtwQAOI7MZEyAWtc4h9YfLamGpOCKoK22d3C1OgZNM14RIdT9D4/HapDmj2ImnLSz0U3SmPJQl Ehhuss8W0qUT0plLwvusp4sMk+g7o60FiVAqkYD2m+Ked86CRHl4E3Hs2Gd4YCBjkxjtXS31OKnc0 vr8ODXeyMJTRgch/3xi1mvDV9+A86v+aOsGANl+WnLMfg/JVpwCnJKEn7vq+97pLln9L1fJ9kHLbl /SFjMMGxTKAM93PkJKfQ2Jv34nKaSqg== X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently there are a number of places in the SVE code where we check both system_supports_sve() and TIF_SVE. This is a bit redundant given that we should never get into a situation where we have set TIF_SVE without having SVE support and it is not clear that silently ignoring a mistakenly set TIF_SVE flag is the most sensible error handling approach. For now let's just drop the system_supports_sve() checks since this will at least reduce overhead a little. Signed-off-by: Mark Brown --- arch/arm64/kernel/fpsimd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 062b21f30f94..734d9ea37ecf 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -285,7 +285,7 @@ static void task_fpsimd_load(void) WARN_ON(!system_supports_fpsimd()); WARN_ON(!have_cpu_fpsimd_context()); - if (system_supports_sve() && test_thread_flag(TIF_SVE)) + if (test_thread_flag(TIF_SVE)) sve_load_state(sve_pffr(¤t->thread), ¤t->thread.uw.fpsimd_state.fpsr, sve_vq_from_vl(current->thread.sve_vl) - 1); @@ -307,7 +307,7 @@ static void fpsimd_save(void) WARN_ON(!have_cpu_fpsimd_context()); if (!test_thread_flag(TIF_FOREIGN_FPSTATE)) { - if (system_supports_sve() && test_thread_flag(TIF_SVE)) { + if (test_thread_flag(TIF_SVE)) { if (WARN_ON(sve_get_vl() != last->sve_vl)) { /* * Can't save the user regs, so current would @@ -1092,7 +1092,7 @@ void fpsimd_preserve_current_state(void) void fpsimd_signal_preserve_current_state(void) { fpsimd_preserve_current_state(); - if (system_supports_sve() && test_thread_flag(TIF_SVE)) + if (test_thread_flag(TIF_SVE)) sve_to_fpsimd(current); } @@ -1181,7 +1181,7 @@ void fpsimd_update_current_state(struct user_fpsimd_state const *state) get_cpu_fpsimd_context(); current->thread.uw.fpsimd_state = *state; - if (system_supports_sve() && test_thread_flag(TIF_SVE)) + if (test_thread_flag(TIF_SVE)) fpsimd_to_sve(current); task_fpsimd_load(); -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel