From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98CBC433E0 for ; Fri, 5 Mar 2021 02:11:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F63F64FDB for ; Fri, 5 Mar 2021 02:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F63F64FDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=wa7lNHhyo1kx/XnY1S+6djbIb8JpRBJDwpL/A3lxkUc=; b=NxF1yhqggBEBkFf5Jll7/+3e93 IcTCUv9pgtuPA7/jC10HJjsmHhX12wPsFoxKHc+oT5PDH0eea4NvGem/ueQJ/wOFH8C2S0R3dxKjK D9ta+OBvOlmleoKKzeeNep4SuhJqBX+eAZkzQeaLTRx42SGFhIzxub4lzMTeW60kTkcEdRUZs3XYw NF7dsl+4Jh3o7+NSTNW2BqDXSqgaiao4n5IYfPBTLl2M6MuxIaok9OEeZYGIejOpyjX68HU4PcnhZ otiWlPb95Cw0tIyfjMkC3/aFRKaFbhr7du81Y+fqKMscpd5r2UyaEj9Z8ucdGtg195wUqOWHoKmqx J2rn9nEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHzil-00BV49-DM; Fri, 05 Mar 2021 01:57:40 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHzig-00BV2I-Lq for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 01:57:36 +0000 Received: by mail-pl1-x62c.google.com with SMTP id s7so565276plg.5 for ; Thu, 04 Mar 2021 17:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=a/gfEUi1TGx/uGFvjKHJAmJ/48p70i3b6PrBu0uiDH8=; b=TTgjvJmgbgPpOS9oC00BHC+0UhExKhAKgWLnGRwlsJCoUIXze0fUxVJJjGgMElU9+b ByBecrh4+GJAkVGACMK8+937UQ9g9OThfvjEB5IhUys+dDLOam7Tsa2yS+Mr5oUBsZpK b5FE8/BKVn3CLZQesa0uRlfHwDqJ3cP7qk+qGMmFtErGs8a1b4rQmAZn3WQNhspkaTV8 104afembidoAsFmiebnh08Tu9dOrD4QZMGlXUj/L8gMa+690dS+yD9sB8/01+LSbpx/R rJrRuqrAPp4LCrkRAKxJc07OOW9dvLCmb59q21ogvtlGIIOiCDbYdV/OlH6MTn5CLHIe vzCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=a/gfEUi1TGx/uGFvjKHJAmJ/48p70i3b6PrBu0uiDH8=; b=JyzpC03UMWYqxV+wd9xKLiiUkbrWbykWjOx4D1Z58dq+1pLYHqnSCihZELH1hlSWwL Hz8ulHXqSGJohw1nWMviGbYScmST7RYNK8hBQ3m58ujejUqyFpI45raXFgj4LaOraJGh 46MT86rF0Uh3Uo/f2DIL+5waXnvegy36oqSpP4y0b+65wCbs1z8iTZ6X6UhYezDIJbg7 ykWSpzZbA6FIP8gc6JgioGbuHc/z6wxLYX1ametRp42SjPCe2mM3jmbUuF1WJChWUveO fvYJLwvnFu5l4gEwcjjaUXhALxZeXOCMGZbxaAmOC4PGM0rr279+x/vH3RIrpJbcSQRG Dy9g== X-Gm-Message-State: AOAM532bTL1eke1zhE1Mb9inuuRQwjz1AyYNpCNHnbT0RjvXftMvEVo7 I+UXy+Aozpgz/vKlG6rovmk= X-Google-Smtp-Source: ABdhPJwWgNTHIaiWh6RMrtnHdMheXZ5FBab63ta04GetaMWGSp67CWGXuUGMfIzmARwF/Qo6JlHFtw== X-Received: by 2002:a17:902:6b88:b029:df:ff72:7bc6 with SMTP id p8-20020a1709026b88b02900dfff727bc6mr6577192plk.23.1614909452764; Thu, 04 Mar 2021 17:57:32 -0800 (PST) Received: from localhost.localdomain ([45.135.186.46]) by smtp.gmail.com with ESMTPSA id x7sm459494pjr.7.2021.03.04.17.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 17:57:32 -0800 (PST) From: Jia-Ju Bai To: clabbe.montjoie@gmail.com, herbert@gondor.apana.org.au, davem@davemloft.net, mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, mchehab+huawei@kernel.org, corbet@lwn.net Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] crypto: allwinner: sun8i-ce: fix error return code in sun8i_ce_prng_generate() Date: Thu, 4 Mar 2021 17:57:17 -0800 Message-Id: <20210305015717.2908-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_015734_836731_D3D361FF X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When dma_mapping_error() returns an error, no error return code of sun8i_ce_prng_generate() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c index cfde9ee4356b..cd1baee424a1 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c @@ -99,6 +99,7 @@ int sun8i_ce_prng_generate(struct crypto_rng *tfm, const u8 *src, dma_iv = dma_map_single(ce->dev, ctx->seed, ctx->slen, DMA_TO_DEVICE); if (dma_mapping_error(ce->dev, dma_iv)) { dev_err(ce->dev, "Cannot DMA MAP IV\n"); + err = -EFAULT; goto err_iv; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel