From: Shawn Guo <shawn.guo@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>
Subject: [PATCH] arm64: efi: add check for broken efi poweroff
Date: Fri, 5 Mar 2021 14:51:20 +0800 [thread overview]
Message-ID: <20210305065120.11355-1-shawn.guo@linaro.org> (raw)
Poweroff via UEFI Runtime Services doesn't always work on every single
arm64 machine. For example, on Lenovo Flex 5G laptop, it results in
a system reboot rather than shutdown. Add a DMI check to keep such
system stay with the original poweroff method (PSCI).
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm64/kernel/efi.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
index fa02efb28e88..8ae0002c72f1 100644
--- a/arch/arm64/kernel/efi.c
+++ b/arch/arm64/kernel/efi.c
@@ -7,6 +7,7 @@
* Copyright (C) 2013, 2014 Linaro Ltd.
*/
+#include <linux/dmi.h>
#include <linux/efi.h>
#include <linux/init.h>
@@ -113,12 +114,26 @@ int __init efi_set_mapping_permissions(struct mm_struct *mm,
set_permissions, md);
}
+static const struct dmi_system_id efi_reboot_broken_table[] = {
+ {
+ .ident = "Lenovo Flex 5G",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_FAMILY, "Flex 5G"),
+ },
+ },
+ { } /* terminator */
+};
+
/*
* UpdateCapsule() depends on the system being shutdown via
* ResetSystem().
*/
bool efi_poweroff_required(void)
{
+ if (dmi_check_system(efi_reboot_broken_table))
+ return false;
+
return efi_enabled(EFI_RUNTIME_SERVICES);
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-03-05 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 6:51 Shawn Guo [this message]
2021-03-05 7:01 ` [PATCH] arm64: efi: add check for broken efi poweroff Ard Biesheuvel
2021-03-05 7:31 ` Shawn Guo
2021-03-05 7:46 ` Ard Biesheuvel
2021-03-05 8:02 ` Shawn Guo
2021-03-05 8:21 ` Ard Biesheuvel
2021-05-17 0:59 ` Shawn Guo
2021-05-18 7:44 ` Ard Biesheuvel
2021-05-19 14:05 ` Shawn Guo
2021-05-19 14:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305065120.11355-1-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).