From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEE5C433E0 for ; Fri, 5 Mar 2021 20:24:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D0CB64E87 for ; Fri, 5 Mar 2021 20:24:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D0CB64E87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9K6F++MyBHv9twUZCnLqASb+mNMPdFp0ODTkEOyORmg=; b=q2yTi1tuD2JITtVt+5TeBD1Tt LT1C4Z2rk8fgeiaoe/HMVr6TgqFrBmD45CpCrBSYEvd3CA76sDss5Lc6ohRxfmIxxOq37A+y4NVQI 9uSZK4OVzPhiRCTxmOS5zB6Pb90cZwsacm8dSh2Aa23ttYHCcdmye8tWgbLyfMbmS6wPy7Nd79Rmc fVQjgPpWoa6bW3jPDZEQxGcjKZ19lKFv1CxBib+xtWiPY2P2FM7xo/AgZl+1gYn6KP8t7YSd/pKAq ThtRzx7qKrwvVZXKWNy7BspYo2IGEhwL5IeGI7WYrtoPmrqJdfywgBNHKMUCkXxgH95hMTItX8MWq m5/obXoYA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIGyJ-00GLqM-Hh; Fri, 05 Mar 2021 20:22:53 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIGy8-00GLlq-Hv for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 20:22:42 +0000 Received: by mail-pj1-x1032.google.com with SMTP id bj7so2803281pjb.2 for ; Fri, 05 Mar 2021 12:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MgB9sUnmB+HDbU7JAxGibZcjoX4E3ntVPdJMz4KOYFw=; b=dLCXmMukcPtwoQkxr3n8IjcWmQ6q7PKDS4dt108Ep+Hg6xtKufWiaRfiYb+CxHR/HC qWKMfkrxZAMSD6QL8O9MUCKoSmwG/ZECasfaVxsuaSX2kBnGlXgijqIIG4MipL0UlkuP PEl4XvNYWvLojiZggWkziHss50vlyhTXkcdGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MgB9sUnmB+HDbU7JAxGibZcjoX4E3ntVPdJMz4KOYFw=; b=KHwwzbsbcMSsd2XbgWIi1oS99mPdgujkviAYF3+Fka25y5t19HNbzerGdz3quiYFRv XcxXPcXGwY6MFS02caXeaxzFRYehJdjCIqO+NgGNoP5VZMpzjaqJatHTvvn7sfmBF8EL Jspnd5JFduHjfVVKYPlBUBRGqSzY8+iL07CpbXjtmNW28YWnmPG0Ll5wcxpiwyqkTSQh A955MRPtmJOb112WPRHFDatLLjwUS7EYyACnzXkUfcmaFLjZNVV2PDHYY76CqJXHstve eNurYi0uU3AW91o4HtPJ2bENBF+EkpnwZ1PvDM1qznT2nW15OYiOeXSFYENcZjkdfg+F EI4w== X-Gm-Message-State: AOAM533ruNpRYBmg41O14NLXReidjWrOa1NKpOIbfLSXyXa7ACMS7YcM NIqdrGTUGyhYg30k3iUzlNSmDA== X-Google-Smtp-Source: ABdhPJz904H54bOFu7Tm3S02OXvw0Agtoa0McJF8goVZOFxdTDl2+pz3qI79jeBp+mKHGDstYs9PXQ== X-Received: by 2002:a17:902:ee06:b029:e4:ba18:3726 with SMTP id z6-20020a170902ee06b02900e4ba183726mr10198402plb.17.1614975758196; Fri, 05 Mar 2021 12:22:38 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 63sm3854163pfg.187.2021.03.05.12.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 12:22:37 -0800 (PST) Date: Fri, 5 Mar 2021 12:22:36 -0800 From: Kees Cook To: Sami Tolvanen Cc: Marc Zyngier , James Morse , Nathan Chancellor , Nick Desaulniers , Ard Biesheuvel , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Don't use cbz/adr with external symbols Message-ID: <202103051222.1E08D7D31@keescook> References: <20210305202124.3768527-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305202124.3768527-1-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_202240_874096_73EFBF7D X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 12:21:24PM -0800, Sami Tolvanen wrote: > allmodconfig + CONFIG_LTO_CLANG_THIN=y fails to build due to following > linker errors: > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21CC): > relocation R_AARCH64_CONDBR19 out of range: 2031220 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21E0): > relocation R_AARCH64_ADR_PREL_LO21 out of range: 2031200 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > This is because with LTO, the compiler ends up placing hyp_panic() > more than 1MB away from __guest_enter(). Use an unconditional branch > and adr_l instead to fix the issue. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1317 > Reported-by: Nathan Chancellor > Suggested-by: Marc Zyngier > Suggested-by: Ard Biesheuvel > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel