From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A009C433E0 for ; Sat, 6 Mar 2021 11:09:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEDE865000 for ; Sat, 6 Mar 2021 11:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEDE865000 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5yJtsY9cmBzdWSOjl4oNGKU7dL4dE1o+lSl6n1N33R0=; b=TmVQA+joKwZGtGH0Q7qfwXE6E dqsU0ycjqu64KvGUjlG0rRa3jiAHafCLpeH58/EJlUEZEObYGDeSca2Bg4VVVu5VctnyiA+WAht4x ckVSvRcXRQ1nFTdcfStuEWQANmkFkZI7/0M/8VJGCS/WQvVTyOQVPUD39oFYAkrxAN8rf4L8YGyAN jhtSGdM1IweKpI66CZFtJGNtmP+eckNSz5OjBn0ha3IH5XNlIe6HSTwS6GZ4dYfKKqxjTbkrx1yL1 q3QyPoHJ8TQpyei9cgHI85QrK50xPPPJKt0nNyje/zyjnSfZkyV8c7WE/OHlDC7z07ytZgH+RnYPp hzlskqPFw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIUmS-002qQY-ET; Sat, 06 Mar 2021 11:07:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIUmN-002qPf-5S for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 11:07:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A520E64DED; Sat, 6 Mar 2021 11:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615028844; bh=wxAKsZeCl/F8roiAeuqIApJKFkl5seO6VFJ8kuuYD2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ULT64t7GjQvjNv0fOideyMvGeFxiCXo+5Q0l2B5BMnj62pDoOJOUlRMvFIcHWaAGa Grt1RgQM2mFJAJc1D0E30sN5C9ojk7kbio1t7SxMO25K6yhaNZrQjyxl7oPyV7OQ8O ogEZlXvWnWYKq/ID7kv/1FijrlZz54FTyBwrK31HUngnearO9NNzc5i/MSLL5r5s/a k+VQH4QEWnvFtDeVYm0h+axE8sH2LueHXidxUG3QtxpaGa2l62BXpFyGiW67oIjzfd eMfhycRsWUGptgn54rH4gCR4UuCPWIMcNU8IqYS+C745Qiu95h4oIgNzVShXXlw35F pwZ2uN2S6zdgA== Date: Sat, 6 Mar 2021 19:07:19 +0800 From: Shawn Guo To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Christoph Niedermaier , Fabio Estevam , Ludwig Zenz , NXP Linux Team , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators Message-ID: <20210306110718.GX15865@dragon> References: <20210203235403.308539-1-marex@denx.de> <20210303125614.GG15865@dragon> <3189923d-df38-6dab-6be7-b2439c234fe4@denx.de> <20210304075652.GN15865@dragon> <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> <20210305083931.GT15865@dragon> <678b6564-14c2-7085-8750-06bbc235ae8d@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <678b6564-14c2-7085-8750-06bbc235ae8d@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_110727_525394_74FB7EE0 X-CRM114-Status: GOOD ( 25.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 12:19:25PM +0100, Marek Vasut wrote: > On 3/5/21 9:39 AM, Shawn Guo wrote: > > On Thu, Mar 04, 2021 at 01:07:32PM +0100, Marek Vasut wrote: > > > On 3/4/21 8:56 AM, Shawn Guo wrote: > > > > On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote: > > > > > On 3/3/21 1:56 PM, Shawn Guo wrote: > > > > > > On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote: > > > > > > > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1 > > > > > > > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied > > > > > > > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs. > > > > > > > > > > > > > > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2") > > > > > > > > > > > > It's more like an improvement or additions rather than fixes. I dropped > > > > > > the tag and applied for -next. > > > > > > > > > > I would argue that describing SoC regulators correctly is a bugfix, since it > > > > > can lead to stability issues of the SoC. > > > > > > > > Then resend the patch with details of the issue that it fixes. > > > > > > Can you please tell me what is missing in the original patch description > > > that justifies dropping the Fixes: tag ? I would argue that fully describing > > > CPU regulators in DT is a fix which should go through the stable tree and > > > the original patch description is accurate. > > > > You claim that the patch fixes a stability issue, but commit log > > mentions nothing about it. > > Correction, I claim it can lead to stability issues, so far none were > observed to my knowledge. But I would argue a correct regulator setup in DT > for a specific device is a bugfix and should go through stable tree. Please > correct me if I'm wrong. All I'm asking is that you resend the patch with commit log stating why this is a bugfix and should go through stable tree, because it's not obvious at least to me. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel