From: Marco Felsch <m.felsch@pengutronix.de>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: devicetree@vger.kernel.org, festevam@gmail.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, krzk@kernel.org,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mm-nitrogen-r2: add espi2 support
Date: Mon, 8 Mar 2021 13:44:52 +0100 [thread overview]
Message-ID: <20210308124452.c4svp52m77bnf3zk@pengutronix.de> (raw)
In-Reply-To: <20210308123958.254116-2-adrien.grassein@gmail.com>
Hi Adrien,
On 21-03-08 13:39, Adrien Grassein wrote:
> Add the description for espi support.
>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> index 4f4cf7df5a5a..0c5949b40eeb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> @@ -52,6 +52,19 @@ &A53_3 {
> cpu-supply = <®_buck3>;
> };
>
> +/* J15 */
> +&ecspi2 {
> + assigned-clocks = <&clk IMX8MM_CLK_ECSPI2>;
> + assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_40M>;
> + assigned-clock-rates = <40000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi2>;
> + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + #address-cells = <1>;
> + #size-cells = <0>;
Nit: These two properties should be added to the base dtsi if not
already done.
Regards,
Marco
> + status = "okay";
> +};
> +
> &fec1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_fec1>;
> @@ -286,6 +299,15 @@ &iomuxc {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hog>;
>
> + pinctrl_ecspi2: ecspi2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0x140
> + MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x19
> + MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x19
> + MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x19
> + >;
> + };
> +
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
> --
> 2.25.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-08 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 12:39 [PATCH 0/1] arm64: dts: imx8mm-nitrogen-r2: add espi2 support Adrien Grassein
2021-03-08 12:39 ` [PATCH 1/1] " Adrien Grassein
2021-03-08 12:42 ` Fabio Estevam
2021-03-08 12:44 ` Marco Felsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308124452.c4svp52m77bnf3zk@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=adrien.grassein@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).