From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA25C433E0 for ; Mon, 8 Mar 2021 20:41:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AAE864F09 for ; Mon, 8 Mar 2021 20:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AAE864F09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2O7QbAPmO0BUzR61vM+lVc6m8UaxVZif6qDSDrulIZk=; b=YnGEPYeXRZ5k6ELIjMt3daTfo kjY3D1u/rvb+XWwXdvt5WqcCbA+FUpAAkZd7DMNlhFbjm0RYtuVWGk1690O3jLr0y2n5PgAJIPRF+ 6ae2zVgguQiah8Ts85iTLdu61bgMrJont+Chcd5BNHpixD+TacQq0aXf81Y/Mihedh0IX0dr62BOI RQR39f3KRU9PToUHsF53EXVsvJCCQSm+z1YNevduScl517S1QyO1rYwKKbKPNTJbayI0M22+VM/1B GlUUbT8Sx1BbEwimfd1VjfC2dSBgX/Be1HgzrAHwUmMGapkel15ICGcBfRnoEYRhlhmP4piEstIrT S4cSWTmMA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJMeZ-002kXE-80; Mon, 08 Mar 2021 20:38:59 +0000 Received: from mail-io1-f47.google.com ([209.85.166.47]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJMeN-002kQc-No for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 20:38:53 +0000 Received: by mail-io1-f47.google.com with SMTP id n132so11478143iod.0 for ; Mon, 08 Mar 2021 12:38:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9lLfeCs1Tc8ddEaiXHzDtmEpQP9gGHowCs7DuxfnmRE=; b=l4ZnMEXyNBe6FV9yaYJbKbZQbVW9GObMauM/FdEsl79k+rnxwTQQwCa6QBvUMUaY8O H9pLz7BKQwmCQH1UyBRnn/1ZxIsdxVJr7w/++hHQOHyQ8fty4+5sSN8hBLYKdjI7Kaep 8ipGHkhG/BVHmNm4wgSu6qDuzlhVLAD1Xli4ePHLMrOIhWTo5oCX/iuiv0nM43DfT5k5 +aWd3mZyNnSnj9VZXYd0zvFAFb+Krv+J7P0amUqJztWQ9THCZ0i2oXOpcuw8NXUNHWcB rkMdtPojhr0a8bLgetGWnSQcUbZw6/09N3tBqzu8dlCU6F1q6TwnCe4WiLibG7K+zX8l Xezg== X-Gm-Message-State: AOAM531z6DJhiAl6RQTnfDEDrpTK3CCH//Yuowr48Mkxbz3L64ggmgPq tp54ulAVGQmpenWKf/nUDw== X-Google-Smtp-Source: ABdhPJz6/b0HXPf5UbrLJ8rHp/ABrKIy46sXafa7ZkfydealL7GIC6LpxZTvxSGmls2DzSoW84uFgw== X-Received: by 2002:a02:cc1a:: with SMTP id n26mr25539390jap.21.1615235926457; Mon, 08 Mar 2021 12:38:46 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id h128sm6553100ioa.32.2021.03.08.12.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 12:38:45 -0800 (PST) Received: (nullmailer pid 2920550 invoked by uid 1000); Mon, 08 Mar 2021 20:38:41 -0000 Date: Mon, 8 Mar 2021 13:38:41 -0700 From: Rob Herring To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v3 06/27] dt-bindings: timer: arm,arch_timer: Add interrupt-names support Message-ID: <20210308203841.GA2906683@robh.at.kernel.org> References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-7-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210304213902.83903-7-marcan@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_203848_260511_3D9BF87D X-CRM114-Status: GOOD ( 22.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 06:38:41AM +0900, Hector Martin wrote: > Not all platforms provide the same set of timers/interrupts, and Linux > only needs one (plus kvm/guest ones); some platforms are working around > this by using dummy fake interrupts. Implementing interrupt-names allows > the devicetree to specify an arbitrary set of available interrupts, so > the timer code can pick the right one. > > This also adds the hyp-virt timer/interrupt, which was previously not > expressed in the fixed 4-interrupt form. > > Signed-off-by: Hector Martin > --- > .../devicetree/bindings/timer/arm,arch_timer.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > index 2c75105c1398..ebe9b0bebe41 100644 > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > @@ -34,11 +34,25 @@ properties: > - arm,armv8-timer > > interrupts: > + minItems: 1 > + maxItems: 5 > items: > - description: secure timer irq > - description: non-secure timer irq > - description: virtual timer irq > - description: hypervisor timer irq > + - description: hypervisor virtual timer irq > + > + interrupt-names: > + minItems: 1 > + maxItems: 5 > + items: > + enum: > + - phys-secure > + - phys > + - virt > + - hyp-phys > + - hyp-virt phys-secure and hyp-phys is not very consistent. secure-phys or sec-phys instead? This allows any order which is not ideal (unfortunately json-schema doesn't have a way to define order with optional entries in the middle). How many possible combinations are there which make sense? If that's a reasonable number, I'd rather see them listed out. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel