From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78FCC433DB for ; Thu, 11 Mar 2021 13:43:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB82264F38 for ; Thu, 11 Mar 2021 13:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB82264F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tvZ1OP3030GJdWV/UEIM1OPskBm3LauIHyQCAtrzISE=; b=V4ifOc9/lfonRzAacxLk8Xfib s4K8utbRGU1HrpCqyPsLXM7IOBSxnpd9sDAh12JwdRHqOfG3sp1eOmCzdhrMYMqzlwp4MXpR9a0id 897oSFs+ZP+vyJXtxZgpv93bVUAxVRZcH6rHKBGmuCauJ0M5a1nxFIgmsF+5K5EPGPV8AUDoZk/dg lGw43qqfqybZSa0q6bkSJP3QdISZ4koODNWjNq61mEaE3rjc9LqGeI2BgR0BhpJzgNsiUAC9IiwvE qxJrlz27a7/RKBgeK2efKZogqe85fmKxX8zXTCj3HfX4xrSbJTXHncg6ELukoARc2q4iq5DiQbBoF hq9YilrTQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKLZ9-009Eun-FJ; Thu, 11 Mar 2021 13:41:27 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKLYz-009EtN-DJ for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 13:41:19 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12BDfCaq108524; Thu, 11 Mar 2021 07:41:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1615470072; bh=vYLdQbvqwMSqb9Nc4Kl09M1XlI2NhnGkj2qZH+9v8j8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=OBbm3t30O4VZAsUnIreBTI/XsavIqsW+FaJrebHc7IpZmU121Z5j6SYtfghbclZxZ zfSBj0o9zFchOkAq5sdFxNod8LmZzUWdHPOFjHK8zeuwDiIth2yRId2jsbce7Ghsl6 XHIvKbL6Ah6v9RtcBbGI3GQxKkiPid/UwlDDHv7w= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12BDfCPk032166 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Mar 2021 07:41:12 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 11 Mar 2021 07:41:12 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 11 Mar 2021 07:41:12 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12BDfBiK001084; Thu, 11 Mar 2021 07:41:12 -0600 Date: Thu, 11 Mar 2021 19:11:11 +0530 From: Pratyush Yadav To: Nishanth Menon CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , , , Subject: Re: [PATCH v2 3/3] arm64: dts: ti: k3-j7200-som-p0: Add nodes for OSPI0 Message-ID: <20210311134109.pbqsq3l5v2h5ivlx@ti.com> References: <20210305153926.3479-1-p.yadav@ti.com> <20210305153926.3479-4-p.yadav@ti.com> <20210311132250.6kwrgo75emyoglzo@pauper> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210311132250.6kwrgo75emyoglzo@pauper> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_134117_772323_DF970EC6 X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/03/21 07:22AM, Nishanth Menon wrote: > On 21:43-20210305, Vignesh Raghavendra wrote: > > > > > > On 3/5/21 9:09 PM, Pratyush Yadav wrote: > > > TI J7200 has the Cadence OSPI controller for interfacing with OSPI > > > flashes. Add its node to allow using SPI flashes. > > > > > > Signed-off-by: Pratyush Yadav > > > --- > > > > Reviewed-by: Vignesh Raghavendra > > > > > > > > > > > > Notes: > > > Changes in v2: > > > - Do not force a pulldown on the DQS line because it already has a > > > pulldown resistor. > > > > > > .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 17 +++++++++ > > > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 36 +++++++++++++++++++ > > > 2 files changed, 53 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > > > index 359e3e8a8cd0..5408ec815d58 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > > > @@ -269,6 +269,23 @@ hbmc: hyperbus@47034000 { > > > #size-cells = <1>; > > > mux-controls = <&hbmc_mux 0>; > > > }; > > > + > > > + ospi0: spi@47040000 { > > > + compatible = "ti,am654-ospi"; > > > + reg = <0x0 0x47040000 0x0 0x100>, > > > + <0x5 0x00000000 0x1 0x0000000>; > > > + interrupts = ; > > > + cdns,fifo-depth = <256>; > > > + cdns,fifo-width = <4>; > > > + cdns,trigger-address = <0x0>; > > > + clocks = <&k3_clks 103 0>; > > > + assigned-clocks = <&k3_clks 103 0>; > > > + assigned-clock-parents = <&k3_clks 103 2>; > > > + assigned-clock-rates = <166666666>; > > > + power-domains = <&k3_pds 103 TI_SCI_PD_EXCLUSIVE>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + }; > > > }; > > > > > > tscadc0: tscadc@40200000 { > > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > > > index a988e2ab2ba1..34724440171a 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > > > @@ -100,6 +100,22 @@ J721E_WKUP_IOPAD(0x24, PIN_INPUT, 1) /* (A8) MCU_OSPI0_D6.MCU_HYPERBUS0_DQ6 */ > > > J721E_WKUP_IOPAD(0x28, PIN_INPUT, 1) /* (A7) MCU_OSPI0_D7.MCU_HYPERBUS0_DQ7 */ > > > >; > > > }; > > > + > > > + mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default { > > > + pinctrl-single,pins = < > > > + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_OSPI0_CLK */ > > > + J721E_WKUP_IOPAD(0x002c, PIN_OUTPUT, 0) /* MCU_OSPI0_CSn0 */ > > > + J721E_WKUP_IOPAD(0x000c, PIN_INPUT, 0) /* MCU_OSPI0_D0 */ > > > + J721E_WKUP_IOPAD(0x0010, PIN_INPUT, 0) /* MCU_OSPI0_D1 */ > > > + J721E_WKUP_IOPAD(0x0014, PIN_INPUT, 0) /* MCU_OSPI0_D2 */ > > > + J721E_WKUP_IOPAD(0x0018, PIN_INPUT, 0) /* MCU_OSPI0_D3 */ > > > + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_OSPI0_D4 */ > > > + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_OSPI0_D5 */ > > > + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_OSPI0_D6 */ > > > + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_OSPI0_D7 */ > > > + J721E_WKUP_IOPAD(0x0008, PIN_INPUT, 0) /* MCU_OSPI0_DQS */ > > > + >; > > > + }; > > > }; > > > > > > &main_pmx0 { > > > @@ -235,3 +251,23 @@ exp_som: gpio@21 { > > > "GPIO_LIN_EN", "CAN_STB"; > > > }; > > > }; > > > + > > > +&ospi0 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&mcu_fss0_ospi0_pins_default>; > > > + > > > + flash@0{ > > > + compatible = "jedec,spi-nor"; > > > + reg = <0x0>; > > > + spi-tx-bus-width = <8>; > > > + spi-rx-bus-width = <8>; > > > + spi-max-frequency = <25000000>; > > > + cdns,tshsl-ns = <60>; > > > + cdns,tsd2d-ns = <60>; > > > + cdns,tchsh-ns = <60>; > > > + cdns,tslch-ns = <60>; > > > + cdns,read-delay = <4>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + }; > I see this: > +/workdir/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dt.yaml: flash@0: 'cdns,read-delay', 'cdns,tchsh-ns', 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of the regexes: '^partition@', 'pinctrl-[0-9]+' > > > And that is because > Documentation/devicetree/bindings/spi/cadence-quadspi.txt is not > converted to yaml. Following the new stringent rules, yaml please? Ok. I am working on the conversion. Will send it soon. -- Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel