From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D393DC433DB for ; Fri, 12 Mar 2021 02:42:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EBD064F64 for ; Fri, 12 Mar 2021 02:42:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EBD064F64 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SjMmLIgJ4B1qt64meImySyWHIyYZTVaopyfk8vP/WEU=; b=hUUlPLgBkuGzpVh3UgViLpEFR gsfbj5pwPfJqteXmq5yN3iTKug8dhnqMPccp4phg+5QPUzPbQwMZx7Jp9pDricvHLk9wDti+sTg/K RnZaofCc5ReswTrb3i+Vt76I4zVodmN3pYDfPXWvlvA8IXAHVPD7Vrc4qyQxcVZZ1TK3sUnexfnFx W7HChOjN1bR/9s70nWE5qM12rV01U9gVFgW8S08cJFuS0x4pUuzakz2p0B656p1+IdN/jhkyabqAX 5yW3tqCwDbiP2IE/+ObtSufLjdsR+QIB7kAT0JpZ1Wmnb9WYNSRbw0Lu1mTyJ/tYa2Bhm0OKkQVky idIyNChcA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKXjH-00AUBh-My; Fri, 12 Mar 2021 02:40:43 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKXj9-00AU9x-Jh for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 02:40:37 +0000 Received: by mail-pf1-x435.google.com with SMTP id e26so853181pfd.9 for ; Thu, 11 Mar 2021 18:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wQ2W9gu3Osj3MdqScThl5MpYybHbMYo3x9B6R2Mk6L8=; b=NZXDAK2nVsB5XLAK6iQkiJruNlfdqCk+PJ5VanZ25OXi+Q7zOTY+NZjcnHTYoiEtfi 5wk/CnP+uAgWsZoZ/bHZzWMDdnp91wseWZkkXoKIWJYj/tDgoqrTmJkkLAGNo4onaoRj d0ViJy+d71HMPrIzKYMvvRJfOnUHCkn/TdDgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wQ2W9gu3Osj3MdqScThl5MpYybHbMYo3x9B6R2Mk6L8=; b=DttfhGXQUSurc6eQGW88cfcAVmKlrkvX61RhyrOmdEjBIE6lbIOx0yrSCKcWoy8T3E nBuYFKKBKRDhH5XOegYW0rsUI/bXp3JUdt1OugHVFIsouLU1wZ3w2L7Z49BxcSN4tRNG L8bzckbkzdh7oFR6Bvc9QptsKXuEYtgwwHCFYL/EVg5C6mn5V1BuQMP1kH4pS53SJacR sXLGvpbppTz2JFY/CCv2CgSI2el+KW687LhA0RGpHR4x8KWKoSQcW9NdBFcrA3AXunsy qkkhQBAQ5AEoqpDP6NXGyPvrstFYxUD/kFFdZ0Yyjc684Z7x56zuZPC+ypk1gbTSkZ3D fhZg== X-Gm-Message-State: AOAM530pKvSQ9yeG+cHDeomU4UkHIX+cNm5+9dDSYvhImR01fxa2xyTy KnUPkG7Ez6EuPEK0lbSjchv+ww== X-Google-Smtp-Source: ABdhPJz9mHRexfp/qVZ4vgjUgGk0DFoPnlAxOoA8yf6zI0h/vMdT7tBN76386sP73c1cfoYW99A5EA== X-Received: by 2002:a63:4c55:: with SMTP id m21mr9740097pgl.29.1615516834269; Thu, 11 Mar 2021 18:40:34 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s62sm3689109pfb.148.2021.03.11.18.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:40:33 -0800 (PST) Date: Thu, 11 Mar 2021 18:40:32 -0800 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] mm: add generic __va_function and __pa_function macros Message-ID: <202103111840.73C55A4A@keescook> References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-4-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210312004919.669614-4-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_024035_708899_C08B0AE7 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 04:49:05PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, the compiler replaces function addresses > in instrumented C code with jump table addresses. This means that > __pa_symbol(function) returns the physical address of the jump table > entry instead of the actual function, which may not work as the jump > table code will immediately jump to a virtual address that may not be > mapped. > > To avoid this address space confusion, this change adds generic > definitions for __va_function and __pa_function, which architectures > that support CFI can override. The typical implementation of the > __va_function macro would use inline assembly to take the function > address, which avoids compiler instrumentation. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel