From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67866C433DB for ; Fri, 12 Mar 2021 09:28:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0062564EBB for ; Fri, 12 Mar 2021 09:28:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0062564EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X2Doc+5y+Hu2PbYy++MZSA/340tyoz6/mpcMs5VMXK0=; b=J7OURH8kdikR4x4Q3vTdbp2Jx KmgpAJJShH9RpobO3UpZ4ihAmaGzNjYzSM8pThmAagb+LR3flx7iQHsoF8FKP24bGzkyzRafbBs81 Cedx5+4GN+4w3EWO1KJlSRoRPHvmYMAR+C5Kly++4kFZqZcXHbV6aUg+nqzNnX3qsl78g+Y9jbtQ2 VwQGJmuUZuqvWB7fl+QFbFXSpqC5LuirMSB4C/rkK0+0U45xZQOdWVYTGJWJpd/JFpeXyTUq4cKWW 2JXZyFX1cvePhSTNOXWEGY1c9gOrgTZHOWylSNrErbzYxVMXSEw5TuswVEYY012U0TiFMAYhvP2DC l7gKgi4Gg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKe4K-00B0i7-6a; Fri, 12 Mar 2021 09:26:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKe3X-00B0Yu-Ug for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 09:26:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B85FE64ED7; Fri, 12 Mar 2021 09:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615541162; bh=lt1IwrNUaz19OAxDfxgi2aiw3GOvHySCHyMhts/ttlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fj6Lfc2WDvpu5FN2uF4nmKoY/pKj+yD6c1fxrHH/2C9G+WxYhA5XcICxqbDZryfHb UILcjc19PqDMIxnxPslMIKU2n5/nLiV1Ky0Z9E//xMmLGgTQbxgeTfZU2kAWYZBxoK Rw0RHvov/Ewu9lspDaalDVnJc6UQlHkTT0o+ubMrV+1eER3D8uUTJ/+L6pVBO3wu1g kIfJ2rWYtUX9JtkeoRaoE/+5gOfR4fv6xG95DkxlY7BkzgE1Yyi8ZdhqCgebkwanaU mLNNKPkrM9JHPA5MDb6489q/r3qq5RVsRy0VwZST8KtNuShKhUgPjyWON19f6p7gH9 G9dOWm5SsN/+g== Date: Fri, 12 Mar 2021 09:25:56 +0000 From: Will Deacon To: Quentin Perret Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, tabba@google.com, mark.rutland@arm.com, dbrazdil@google.com, mate.toth-pal@arm.com, seanjc@google.com, robh+dt@kernel.org, ardb@kernel.org Subject: Re: [PATCH v4 13/34] KVM: arm64: Enable access to sanitized CPU features at EL2 Message-ID: <20210312092556.GA32016@willie-the-truck> References: <20210310175751.3320106-1-qperret@google.com> <20210310175751.3320106-14-qperret@google.com> <20210311193638.GE31586@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_092607_152202_83C1A68D X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 12, 2021 at 06:34:09AM +0000, Quentin Perret wrote: > On Thursday 11 Mar 2021 at 19:36:39 (+0000), Will Deacon wrote: > > On Wed, Mar 10, 2021 at 05:57:30PM +0000, Quentin Perret wrote: > > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > > > index 4f2f1e3145de..84be93df52fa 100644 > > > --- a/arch/arm64/kvm/sys_regs.c > > > +++ b/arch/arm64/kvm/sys_regs.c > > > @@ -21,6 +21,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -2775,3 +2776,23 @@ void kvm_sys_reg_table_init(void) > > > /* Clear all higher bits. */ > > > cache_levels &= (1 << (i*3))-1; > > > } > > > + > > > +#undef KVM_HYP_CPU_FTR_REG > > > +#define KVM_HYP_CPU_FTR_REG(id, name) \ > > > + { .sys_id = id, .dst = (struct arm64_ftr_reg *)&kvm_nvhe_sym(name) }, > > > +struct __ftr_reg_copy_entry { > > > + u32 sys_id; > > > + struct arm64_ftr_reg *dst; > > > +} hyp_ftr_regs[] __initdata = { > > > + #include > > > +}; > > > > This looks a bit elaborate to me. Why can't you just spell things out here > > like: > > > > #define KVM_HYP_CPU_FTR_REG(id, name) \ > > { .sys_id = id, .dst = (struct arm64_ftr_reg *)&kvm_nvhe_sym(name) } > > > > struct __ftr_reg_copy_entry { > > u32 sys_id; > > struct arm64_ftr_reg *dst; > > } hyp_ftr_regs[] __initdata = { > > KVM_HYP_CPU_FTR_REG(SYS_CTR_EL0, arm64_ftr_reg_ctrel0), > > ... > > }; > > > > and then have the header file be a normal, guarded header which just > > declares these things? The id parameter to the macro isn't used there. > > I just tried to reduce the boilerplate as much as possible -- in the > current form you only need to add additional features to the header > it'll 'just work'. I don't really think it's worth it -- people are used to having to add declarations for things, so keeping it simple should be fine. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel