linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Tom Saeger <tom.saeger@oracle.com>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	rjw@rjwysocki.net, viresh.kumar@linaro.org,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	rdunlap@infradead.org
Subject: Re: [PATCH] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
Date: Fri, 12 Mar 2021 16:38:02 -0700	[thread overview]
Message-ID: <20210312233802.bzriltvej5gccsdp@brm-x62-17.us.oracle.com> (raw)
In-Reply-To: <YEv2RDAdeJEU75ib@Gentoo>

On Sat, Mar 13, 2021 at 04:46:20AM +0530, Bhaskar Chowdhury wrote:
> On 15:01 Fri 12 Mar 2021, Krzysztof Kozlowski wrote:
> > On 12/03/2021 13:08, Bhaskar Chowdhury wrote:
> > > 
> > > s/untile/until/
> > > s/souce/source/
> > > s/divier/divider/
> > > 
> > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > > ---
> > >  drivers/cpufreq/s5pv210-cpufreq.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> > > index bed496cf8d24..1cfea5339beb 100644
> > > --- a/drivers/cpufreq/s5pv210-cpufreq.c
> > > +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> > > @@ -378,7 +378,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
> > >  		/*
> > >  		 * 6. Turn on APLL
> > >  		 * 6-1. Set PMS values
> > > -		 * 6-2. Wait untile the PLL is locked
> > > +		 * 6-2. Wait until the PLL is locked
> > >  		 */
> > >  		if (index == L0)
> > >  			writel_relaxed(APLL_VAL_1000, S5P_APLL_CON);
> > > @@ -390,7 +390,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
> > >  		} while (!(reg & (0x1 << 29)));
> > > 
> > >  		/*
> > > -		 * 7. Change souce clock from SCLKMPLL(667Mhz)
> > > +		 * 7. Change source clock from SCLKMPLL(667Mhz)
> > >  		 * to SCLKA2M(200Mhz) in MFC_MUX and G3D MUX
> > >  		 * (667/4=166)->(200/4=50)Mhz
> > >  		 */
> > > @@ -439,7 +439,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
> > >  	}
> > > 
> > >  	/*
> > > -	 * L4 level need to change memory bus speed, hence onedram clock divier
> > > +	 * L4 level need to change memory bus speed, hence onedram clock divider
> > 
> > Also grammar fix: need/needs.
> > 
> Hmmm ...good catch...V2 on the way...
> 
> > Best regards,
> > Krzysztof

May as well roll in few more?

Regards,

--Tom

diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index a186c0d8a290..6ecef301bd40 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock);
 /* Use 800MHz when entering sleep mode */
 #define SLEEP_FREQ     (800 * 1000)

-/* Tracks if cpu freqency can be updated anymore */
+/* Tracks if cpu frequency can be updated anymore */
 static bool no_cpufreq_access;

 /*
@@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = {

 /*
  * This function set DRAM refresh counter
- * accoriding to operating frequency of DRAM
+ * according to operating frequency of DRAM
  * ch: DMC port number 0 or 1
  * freq: Operating frequency of DRAM(KHz)
  */
@@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)

                /*
                 * 3. DMC1 refresh count for 133Mhz if (index == L4) is
-                * true refresh counter is already programed in upper
+                * true refresh counter is already programmed in upper
                 * code. 0x287@83Mhz
                 */
                if (!bus_speed_changing)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-12 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 12:08 [PATCH] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c Bhaskar Chowdhury
2021-03-12 14:01 ` Krzysztof Kozlowski
2021-03-12 23:16   ` Bhaskar Chowdhury
2021-03-12 23:38     ` Tom Saeger [this message]
2021-03-12 23:52       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312233802.bzriltvej5gccsdp@brm-x62-17.us.oracle.com \
    --to=tom.saeger@oracle.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=unixbhaskar@gmail.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).