From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: David Miller <davem@redhat.com>
Cc: andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org,
afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver
Date: Tue, 16 Mar 2021 18:32:40 +0200 [thread overview]
Message-ID: <20210316163240.GA1111731@BV030612LT> (raw)
In-Reply-To: <20210315.143933.939938434416308507.davem@redhat.com>
On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote:
> From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> Date: Mon, 15 Mar 2021 13:29:17 +0200
>
> > +
> > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK)
> > +static int debug = -1;
> > +module_param(debug, int, 0);
> > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>
> Module parameters are strongly discouraged in networking drivers, pplease delete this
> ad just pass the default to netif_mdg_init(), thanks!
Ups, I was not aware of this since I've seen it in quite a lot of drivers.
Thanks for pointing this out, I will take care of it in the next
revision.
Kind regards,
Cristi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-16 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 11:29 [PATCH v2 0/3] Add support for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
2021-03-15 11:29 ` [PATCH v2 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding Cristian Ciocaltea
2021-03-15 11:29 ` [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver Cristian Ciocaltea
2021-03-15 21:39 ` David Miller
2021-03-16 16:32 ` Cristian Ciocaltea [this message]
2021-03-15 11:29 ` [PATCH v2 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316163240.GA1111731@BV030612LT \
--to=cristian.ciocaltea@gmail.com \
--cc=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=davem@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).