From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEDEC433E6 for ; Tue, 16 Mar 2021 19:40:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AADC64F44 for ; Tue, 16 Mar 2021 19:40:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AADC64F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pSX+Ilch9cCsyH6f5BvoIvBSOrLEtujhkkyD/xsTUzk=; b=V1F1h6S0nOVATzsQbzFEfz+qq I3MXTYTjd4GD3oUNqhHviOC3ZB2/g7M7b507iU1CfLbbliXZiE7eN7/Q9bfJwJLskL4iKpbFawB2o WYoGrmmFkbsFJV5pXa4IBYFBwT7chBSW3ILkDWmlW0obidvEptkJnaQE6B1QR7czT+JI+Dnpc0DD6 rk87tz1c1JC+IYYZTbKoNiZa1BchOqWmicDjX8tHBYUE1mTYLCq6qkT4UTWZfTWqYhQYaKZdg+9Lo BsPX3JBxI4F9GaLZKLY5KMY1QFTu2nkhTq0+uBh6ZK+4QjwHTPsgyZotMc7OFhRXexPj6505i4qXM jJD8McXFg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMFWk-001jgO-15; Tue, 16 Mar 2021 19:38:50 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMFWd-001jfN-7W; Tue, 16 Mar 2021 19:38:45 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C00841C0B93; Tue, 16 Mar 2021 20:38:39 +0100 (CET) Date: Tue, 16 Mar 2021 20:38:39 +0100 From: Pavel Machek To: Geert Uytterhoeven Cc: Tianling Shen , Rob Herring , Heiko Stuebner , Jagan Teki , Chen-Yu Tsai , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Johan Jonker , David Bauer , Jensen Huang , Marty Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Jacek Anaszewski Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S Message-ID: <20210316193839.GA28184@duo.ucw.cz> References: <20210316150033.15987-1-cnsztl@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_193843_532507_DDDD9412 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0482933654194554175==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0482933654194554175== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2021-03-16 16:34:50, Geert Uytterhoeven wrote: > Hi Tianling, >=20 > CC Jacek, Pavel >=20 > On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > > Personally, I'm not so fond of the -%u node names, and prefer > > > -. With the former, it's way too easy to have a silent > > > override in your .dts(i) stack. > > > Cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: > > > Fix backlight regulator name") > > > > How about using `lan-led`, `sys-led` and `wan-led` here? >=20 > Documentation/devicetree/bindings/leds/leds-gpio.yaml says "led-%u" > is the preferred form, but that anything containing "led" as a substring > is accepted. So I'd go for "led-lan" etc. >=20 > BTW, you can validate your DTB against the leds-gpio DT bindings > by running: >=20 > make dtbs_check > DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/leds/leds-gpio.yaml >=20 > Background info for CCed parties: > https://lore.kernel.org/linux-arm-kernel/20210316150033.15987-1-cnsztl@gmai= l.com/ I don't care much either way, lan-0 is okay as is lan-led. but... + label =3D "nanopi-r4s:green:lan"; + label =3D "nanopi-r4s:red:sys"; + label =3D "nanopi-r4s:green:wan"; It would be good to have common labels, that means LED_FUNCTION_LAN, LED_FUNCTION_WAN, and figuring out something better than "sys", possibly LED_FUNCTION_FAULT? Thanks, Pavel --=20 http://www.livejournal.com/~pavelmachek --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYFEJPwAKCRAw5/Bqldv6 8oJXAKCPwj7rucsgGyf7XZK9sfEne3jGTQCgqNLsTvXmKfFgv9fd007fRTCH1mM= =HMgP -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- --===============0482933654194554175== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0482933654194554175==--