From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292F3C433DB for ; Wed, 17 Mar 2021 09:33:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9372D64F41 for ; Wed, 17 Mar 2021 09:33:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9372D64F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=E7bX6v3mzRrPysiw0Bw/MZ1iiLoL8aXzW6NDarvCpls=; b=bZlawudO9M9Jbai/mHlUby2GsE 0FezKHWPwcad80ypaYPkw3Kc3uprAmpfJRqo2IYxskwVmcgXnfRSwpyxGFgBaHXWQeTjsxu0TWmtP RyLNsUSHp2nZZAwTd0FYuW9IU+JqOfteBCDskXFAc/UIyCE6Tav0mU3MnhpTpjcxx3XPXZGmfvOEO 9tqdTHwaZ/9Hoh6MSv0mcnz8hCXtGmO0URLYy4yeEnLIFVEiPs261kHBa1DRlKcsXwfsBaoQLVGno GTkbjHNKhwFbx5BuEqwCT9tgXn+p1fJIX4J3Fc7XYrKREanH4E0dtqT/NBJ7E8XaE5II+bvBBu7Tc NE5cA1eg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMSWo-002qyZ-MR; Wed, 17 Mar 2021 09:31:46 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMSWj-002qx9-2v for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 09:31:43 +0000 Received: by mail-lj1-x22a.google.com with SMTP id u20so2222850lja.13 for ; Wed, 17 Mar 2021 02:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j1JvQrYJAeTY2r8foioHnWU1JA8C4SZadDv1a3LsN+s=; b=Dshl4/mLY+2y8/eaHHS6lolq9b33VAfEGJy0pKnf7R52ed2jlnzPZ/tlMkPI6hsR2k imdlAfMONM6HW/2qZHOCPqFQcSRd2ij4NSrIYqCe7g9vaFz7bIqfO7SoYkz0hPgooduh 9ECFo7zKKRFwAGrvLLnnzdRDaOVy8ckKVbGGU5nG6nmVhDBpdfuYoREeBoDqlUQHn3gG pNw5l+LxEmZmGr4o/WO51IMmcR6N3E/EgyCt73T8ThcjsoaZpJpy4Yvp3Q0nl6a/LrHj sAIWX+GBIXFh+DPnfhWyj4DuUdnl5D8Cuq6gdFXcfsRfCATkdG1uu/F+7c9CZsbKJshv jvIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j1JvQrYJAeTY2r8foioHnWU1JA8C4SZadDv1a3LsN+s=; b=GTM/Z3FAqIe3qM0aye024MUqU4NomN25kebprpHlcOmde1JCjnau+A4kdHyFzK5hyQ DVM804Yr2VOkQ1lNPkZIqj+s555vbrGh7YoJx3s4wX0O6N7iHzNHQySp5TZFC4YcvzBH QJMU8EMevmTCDvP7JnFMMyVJv2LiaYImS+W7E2Gwl2XkWIzJdXF7N6vvkORfzFzjYbAi CYCZZ3uEdDXV5cr285VKL9ccMAhuP3YUXGWjCkMy6XBhDw+VUmCVbsNlezmHfEfXyC4y xekAX7+2rYxoEfgO9Jxn74qiiZQksbsUPptstYz0SL+ZXdShllrMtm+gLO3vK+lKvjyw Q5/w== X-Gm-Message-State: AOAM530r7OZ8TUqfKmS0HXAJKX0ZPCdCCnwijI+H6GP3MXL+u89e+iZv pTizhGP66CVs/bE0MM3HFROSoQ== X-Google-Smtp-Source: ABdhPJyNfuEMCSNz8/hVScTKZYXXn0qF+hw3di3P3T1w/Q0cuhs93WfGVDIH4QxfoZvt4zGMFnGyaQ== X-Received: by 2002:a2e:868e:: with SMTP id l14mr1853124lji.479.1615973498694; Wed, 17 Mar 2021 02:31:38 -0700 (PDT) Received: from localhost.localdomain (h-155-4-129-234.NA.cust.bahnhof.se. [155.4.129.234]) by smtp.gmail.com with ESMTPSA id j19sm3342054lfb.15.2021.03.17.02.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:31:37 -0700 (PDT) From: Ulf Hansson To: Shawn Guo , Dong Aisheng , Sascha Hauer Cc: Liu Ying , Peng Fan , NXP Linux Team , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] firmware: imx: scu-pd: Update comments for single global power domain Date: Wed, 17 Mar 2021 10:31:17 +0100 Message-Id: <20210317093117.16091-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_093141_252567_24318EEA X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since the introduction of the PM domain support for the scu-pd, the genpd framework has been continuously improved. More preciously, using a single global power domain can quite easily be deployed for imx platforms. To avoid confusions, let's therefore make an update to the comments about the missing pieces. Signed-off-by: Ulf Hansson --- drivers/firmware/imx/scu-pd.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c index 08533ee67626..6e178a63442d 100644 --- a/drivers/firmware/imx/scu-pd.c +++ b/drivers/firmware/imx/scu-pd.c @@ -29,6 +29,10 @@ * The framework needs some proper extension to support multi power * domain cases. * + * Update: Genpd assigns the ->of_node for the virtual device before it + * invokes ->attach_dev() callback, hence parsing for device resources via + * DT should work fine. + * * 2. It also breaks most of current drivers as the driver probe sequence * behavior changed if removing ->power_on|off() callback and use * ->start() and ->stop() instead. genpd_dev_pm_attach will only power @@ -39,8 +43,11 @@ * domain enabled will trigger a HW access error. That means we need fix * most drivers probe sequence with proper runtime pm. * - * In summary, we need fix above two issue before being able to switch to - * the "single global power domain" way. + * Update: Runtime PM support isn't necessary. Instead, this can easily be + * fixed in drivers by adding a call to dev_pm_domain_start() during probe. + * + * In summary, the second part needs to be addressed via minor updates to the + * relevant drivers, before the "single global power domain" model can be used. * */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel