From: Steven Rostedt <rostedt@goodmis.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support
Date: Mon, 22 Mar 2021 11:01:06 -0400 [thread overview]
Message-ID: <20210322110106.2bed3d50@gandalf.local.home> (raw)
In-Reply-To: <20210321190611.d6a3hbqabts3qq5v@e107158-lin>
On Sun, 21 Mar 2021 19:06:11 +0000
Qais Yousef <qais.yousef@arm.com> wrote:
> #ifdef CONFIG_DYNAMIC_FTRACE
> struct dyn_arch_ftrace {
> -#ifdef CONFIG_ARM_MODULE_PLTS
> struct module *mod;
> -#endif
> };
>
I know you want to reduce the "ifdefery", but please note that the
dyn_arch_ftrace is defined once for every function that can be traced. If
you have 40,000 functions that can be traced, that pointer is created
40,000 times. Thus, you really only want fields in the struct
dyn_arch_ftrace if you really need them, otherwise, that's a lot of memory
that is wasted.
-- Steve
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-22 15:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 11:09 [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Alexander A Sverdlin
2021-01-27 11:09 ` [PATCH v7 1/2] ARM: PLT: Move struct plt_entries definition to header Alexander A Sverdlin
2021-01-27 20:25 ` Florian Fainelli
2021-01-27 11:09 ` [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support Alexander A Sverdlin
2021-01-27 19:36 ` Florian Fainelli
2021-03-07 17:26 ` Qais Yousef
2021-03-08 7:58 ` Alexander Sverdlin
2021-03-09 17:42 ` Qais Yousef
2021-03-10 7:23 ` Alexander Sverdlin
2021-03-10 16:14 ` Florian Fainelli
2021-03-10 17:17 ` Alexander Sverdlin
2021-03-12 17:24 ` Qais Yousef
2021-03-12 18:35 ` Florian Fainelli
2021-03-14 22:02 ` Qais Yousef
2021-03-21 19:06 ` Qais Yousef
2021-03-22 15:01 ` Steven Rostedt [this message]
2021-03-22 16:32 ` Qais Yousef
2021-03-22 17:02 ` Alexander Sverdlin
2021-03-23 22:22 ` Qais Yousef
2021-03-24 3:37 ` Florian Fainelli
2021-03-24 16:10 ` Qais Yousef
2021-03-24 9:04 ` Alexander Sverdlin
2021-03-24 15:57 ` Qais Yousef
2021-03-24 16:33 ` Alexander Sverdlin
2021-03-24 16:46 ` Qais Yousef
2021-03-15 9:19 ` Alexander Sverdlin
2021-02-03 18:23 ` [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Florian Fainelli
2021-02-15 18:31 ` Ard Biesheuvel
2021-03-02 8:29 ` Linus Walleij
2021-03-02 10:00 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322110106.2bed3d50@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alexander.sverdlin@nokia.com \
--cc=ardb@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=qais.yousef@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).