From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_RED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AAD5C433C1 for ; Tue, 23 Mar 2021 15:55:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF7C4619CF for ; Tue, 23 Mar 2021 15:55:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF7C4619CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zfwxdJVybnDKQ1IAN9oqpPIXgHk/QmuHWTjU5g4VBPM=; b=PfxW56GpQSMyQfC270H9MvxWx WIcloE6b0tKkv64zaXBqJQjJp1TakTO58nqcDG7PXlQAiws3bRT7HveXXEavZqaDvaIvYwWqSeqqA 4Z97xZzcW7U0+sLGg2nzfNWBJ23tCya3TqH/Rv3S+j5T+USr67Hh05tmI/HHdv5Lv+xezVddn/j2c onN55TMtf/LE8i+26/Kh6Melv5+Vs/FnQRVkmI/qcuvYPIWzz76FMHmwS3d/rA7qHKX4isbQLXXl2 K1DMCohZgUv6llop4cRJxo0c5f18NTEotodYhWNjDuYVES1OWtxG7/ozimCoXo+shislpoA02iW9m bnl8hiDLA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOjLt-00FH5k-D2; Tue, 23 Mar 2021 15:53:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOjLo-00FH5O-6O for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 15:53:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47F1FD6E; Tue, 23 Mar 2021 08:53:43 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B47EA3F718; Tue, 23 Mar 2021 08:53:41 -0700 (PDT) Date: Tue, 23 Mar 2021 15:53:36 +0000 From: Lorenzo Pieralisi To: "Kaneda, Erik" Cc: Shameerali Kolothum Thodi , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "devel@acpica.org" , "Moore, Robert" , Linuxarm , "steven.price@arm.com" , "Sami.Mujawar@arm.com" , "robin.murphy@arm.com" , wanghuiqiang Subject: Re: [RFC PATCH v2 1/8] ACPICA: IORT: Update for revision E Message-ID: <20210323155336.GA1639@e121166-lin.cambridge.arm.com> References: <20201119121150.3316-1-shameerali.kolothum.thodi@huawei.com> <20201119121150.3316-2-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_155348_542709_B4951A44 X-CRM114-Status: GOOD ( 46.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 22, 2021 at 09:57:58PM +0000, Kaneda, Erik wrote: > = > = > > -----Original Message----- > > From: Shameerali Kolothum Thodi > > > > Sent: Monday, March 22, 2021 3:36 AM > > To: Kaneda, Erik ; linux-arm- > > kernel@lists.infradead.org; linux-acpi@vger.kernel.org; iommu@lists.lin= ux- > > foundation.org; devel@acpica.org; Lorenzo Pieralisi > > ; Moore, Robert > > Cc: Linuxarm ; steven.price@arm.com; > > Sami.Mujawar@arm.com; robin.murphy@arm.com; wanghuiqiang > > > > Subject: [Devel] Re: [RFC PATCH v2 1/8] ACPICA: IORT: Update for revisi= on E > > = > > [+] > > = > > Hi Erik, > > = > > As this is now just merged ino acpica-master and based on the discussio= n we > > had here, > > = > > https://github.com/acpica/acpica/pull/638 > > = > > I had a discussion with ARM folks(Lorenzo) in the linaro-open-discussio= ns call > > and > > can confirm that the IORT Revision E is not the final specification and= has > > some issues > > which is now corrected in the latest E.b revision[1]. Also there are no= current > > users > > for the Rev E and it may not be a good idea to push this version into t= he Linux > > kernel > > or elsewhere. > > = > > So could you please revert the merge and I am planning to work on the E= .b > > soon. > Hi, > = > > Please let me know if I need to explicitly send a revert pull request o= r not. > = > Please send a revert pull request and I'll remember to not submit Linux-i= ze the IORT patches. > = > From all of the activity that I've seen with the IORT specification, > it looks like this table is nontrivial to design and maintain. The > difficulty I have with the table is that I do not understand which > table revisions are in active use. Possibly all of them in firmware in the field - I am not sure what you are asking though; if you can elaborate I'd be grateful. > So my question is this: which IORT revisions are being actively used? See above. Thanks, Lorenzo > = > Thanks, > Erik > > = > > Thanks, > > Shameer > > = > > 1. https://developer.arm.com/documentation/den0049/latest/ > > = > > > -----Original Message----- > > > From: iommu [mailto:iommu-bounces@lists.linux-foundation.org] On > > Behalf Of > > > Shameer Kolothum > > > Sent: 19 November 2020 12:12 > > > To: linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > > > iommu@lists.linux-foundation.org; devel@acpica.org > > > Cc: Linuxarm ; steven.price@arm.com; > > Guohanjun > > > (Hanjun Guo) ; Sami.Mujawar@arm.com; > > > robin.murphy@arm.com; wanghuiqiang > > > Subject: [RFC PATCH v2 1/8] ACPICA: IORT: Update for revision E > > > > > > IORT revision E contains a few additions like, > > > =A0 =A0 -Added an identifier field in the node descriptors to aid tab= le > > > =A0 =A0 =A0cross-referencing. > > > =A0 =A0 -Introduced the Reserved Memory Range(RMR) node. This is used > > > =A0 =A0 to describe memory ranges that are used by endpoints and req= uires > > > =A0 =A0 a unity mapping in SMMU. > > > -Introduced a flag in the RC node to express support for PRI. > > > > > > Signed-off-by: Shameer Kolothum > > > > > --- > > > include/acpi/actbl2.h | 25 +++++++++++++++++++------ > > > 1 file changed, 19 insertions(+), 6 deletions(-) > > > > > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index > > > ec66779cb193..274fce7b5c01 100644 > > > --- a/include/acpi/actbl2.h > > > +++ b/include/acpi/actbl2.h > > > @@ -68,7 +68,7 @@ > > > * IORT - IO Remapping Table > > > * > > > * Conforms to "IO Remapping Table System Software on ARM Platforms", > > > - * Document number: ARM DEN 0049D, March 2018 > > > + * Document number: ARM DEN 0049E, June 2020 > > > * > > > > > > > > ********************************************************** > > ****** > > > **************/ > > > > > > @@ -86,7 +86,8 @@ struct acpi_iort_node { > > > u8 type; > > > u16 length; > > > u8 revision; > > > - u32 reserved; > > > + u16 reserved; > > > + u16 identifier; > > > u32 mapping_count; > > > u32 mapping_offset; > > > char node_data[1]; > > > @@ -100,7 +101,8 @@ enum acpi_iort_node_type { > > > ACPI_IORT_NODE_PCI_ROOT_COMPLEX =3D 0x02, > > > ACPI_IORT_NODE_SMMU =3D 0x03, > > > ACPI_IORT_NODE_SMMU_V3 =3D 0x04, > > > - ACPI_IORT_NODE_PMCG =3D 0x05 > > > + ACPI_IORT_NODE_PMCG =3D 0x05, > > > + ACPI_IORT_NODE_RMR =3D 0x06, > > > }; > > > > > > struct acpi_iort_id_mapping { > > > @@ -167,10 +169,10 @@ struct acpi_iort_root_complex { > > > u8 reserved[3]; /* Reserved, must be zero */ > > > }; > > > > > > -/* Values for ats_attribute field above */ > > > +/* Masks for ats_attribute field above */ > > > > > > -#define ACPI_IORT_ATS_SUPPORTED 0x00000001 /* The root > > > complex supports ATS */ > > > -#define ACPI_IORT_ATS_UNSUPPORTED 0x00000000 /* The root > > > complex doesn't support ATS */ > > > +#define ACPI_IORT_ATS_SUPPORTED (1) /* The root complex > > > supports ATS */ > > > +#define ACPI_IORT_PRI_SUPPORTED (1<<1) /* The root complex > > > supports PRI */ > > > > > > struct acpi_iort_smmu { > > > u64 base_address; /* SMMU base address */ > > > @@ -241,6 +243,17 @@ struct acpi_iort_pmcg { > > > u64 page1_base_address; > > > }; > > > > > > +struct acpi_iort_rmr { > > > + u32 rmr_count; > > > + u32 rmr_offset; > > > +}; > > > + > > > +struct acpi_iort_rmr_desc { > > > + u64 base_address; > > > + u64 length; > > > + u32 reserved; > > > +}; > > > + > > > > > > > > /********************************************************** > > ***** > > > **************** > > > * > > > * IVRS - I/O Virtualization Reporting Structure > > > -- > > > 2.17.1 > > > > > > _______________________________________________ > > > iommu mailing list > > > iommu@lists.linux-foundation.org > > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > _______________________________________________ > > Devel mailing list -- devel@acpica.org > > To unsubscribe send an email to devel-leave@acpica.org > > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel