From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552E5C433C1 for ; Tue, 30 Mar 2021 09:18:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFF626024A for ; Tue, 30 Mar 2021 09:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFF626024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ONfo2JK+QIgyTfluREzvK4MFV4nQ0uK646uMtgDkFC0=; b=H5uFAYW4pUVp96JJupXn6uQpt OS9yEcszsSrF/RPA/2ZyzhlElEDGzOKn6rb566pAoWdaF5HlWoHFSQnvBoGPMJKgYl7tmiClrZopj tZmj2Mmdv790WjVMikdUj9dNu9r+6mxpDBe3330gOlTKeG9qoUcd2btw7Mt1FOOaJ+128zKvkuGJB DQ3AIRZtpSXy4x7Pv69y3weaYN9bBMbzQqjFpYvVNVcaqDLh8xb38fmPKStRs8N75qZnf3mpxHHjv wyUVh64MFnyl74puuZiyQFseT8aUIZu9m7LwgNQw0xVtvihqnh8mE01IpavMtZoSCFWmkmmzXOTH5 yP3VcS/RA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRAV6-003B32-2k; Tue, 30 Mar 2021 09:17:28 +0000 Received: from inva020.nxp.com ([92.121.34.13]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRAUy-003B0q-Tx for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 09:17:22 +0000 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C8F801A311F; Tue, 30 Mar 2021 11:17:18 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id BC1DE1A133F; Tue, 30 Mar 2021 11:17:18 +0200 (CEST) Received: from localhost (fsr-ub1664-175.ea.freescale.net [10.171.82.40]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id A7FBA203DF; Tue, 30 Mar 2021 11:17:18 +0200 (CEST) Date: Tue, 30 Mar 2021 12:17:18 +0300 From: Abel Vesa To: Jian Dong Cc: mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, huyue2@yulong.com, Jian Dong Subject: Re: [PATCH] clk: imx: reference preceded by free Message-ID: <20210330091718.xd6phttmlyoegsnq@fsr-ub1664-175> References: <1616469034-9691-1-git-send-email-dj0227@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1616469034-9691-1-git-send-email-dj0227@163.com> User-Agent: NeoMutt/20180622 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_101721_086728_F3AFA1B4 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-03-23 11:10:34, Jian Dong wrote: > From: Jian Dong > > when register failed, clk will be freed, it will generate dangling pointer > problem in later reference. it should return directly. > > Signed-off-by: Jian Dong Applied, thanks. > --- > drivers/clk/imx/clk-lpcg-scu.c | 1 + > drivers/clk/imx/clk-scu.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c > index 77be763..dd5abd0 100644 > --- a/drivers/clk/imx/clk-lpcg-scu.c > +++ b/drivers/clk/imx/clk-lpcg-scu.c > @@ -114,6 +114,7 @@ struct clk_hw *__imx_clk_lpcg_scu(struct device *dev, const char *name, > if (ret) { > kfree(clk); > hw = ERR_PTR(ret); > + return hw; > } > > if (dev) > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > index 1f5518b7..f89b4da 100644 > --- a/drivers/clk/imx/clk-scu.c > +++ b/drivers/clk/imx/clk-scu.c > @@ -426,6 +426,7 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name, > if (ret) { > kfree(clk); > hw = ERR_PTR(ret); > + return hw; > } > > if (dev) > -- > 1.9.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel