From: Pratyush Yadav <p.yadav@ti.com>
To: Brad Larson <brad@pensando.io>
Cc: <linux-arm-kernel@lists.infradead.org>, <arnd@arndb.de>,
<linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
<broonie@kernel.org>, <fancer.lancer@gmail.com>,
<adrian.hunter@intel.com>, <ulf.hansson@linaro.org>,
<olof@lixom.net>, <linux-gpio@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/13] spi: cadence-quadspi: Add QSPI support for Pensando Elba SoC
Date: Tue, 30 Mar 2021 16:43:08 +0530 [thread overview]
Message-ID: <20210330111308.7jjyj7nir6gmjnsv@ti.com> (raw)
In-Reply-To: <20210329015938.20316-3-brad@pensando.io>
On 28/03/21 06:59PM, Brad Larson wrote:
> Add QSPI controller support for Pensando Elba SoC
>
> Signed-off-by: Brad Larson <brad@pensando.io>
> ---
> drivers/spi/spi-cadence-quadspi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index 52ddb3255d88..4aacb0b2dbc7 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1353,6 +1353,7 @@ static int cqspi_request_mmap_dma(struct cqspi_st *cqspi)
> cqspi->rx_chan = dma_request_chan_by_mask(&mask);
> if (IS_ERR(cqspi->rx_chan)) {
> int ret = PTR_ERR(cqspi->rx_chan);
> +
Unrelated whitespace change. Please move it into a separate cleanup
patch.
> cqspi->rx_chan = NULL;
> return dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n");
> }
> @@ -1633,6 +1634,10 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = {
> .quirks = CQSPI_DISABLE_DAC_MODE,
> };
>
> +static const struct cqspi_driver_platdata pen_cdns_qspi = {
> + .quirks = CQSPI_NEEDS_WR_DELAY | CQSPI_DISABLE_DAC_MODE,
> +};
> +
> static const struct of_device_id cqspi_dt_ids[] = {
> {
> .compatible = "cdns,qspi-nor",
> @@ -1650,6 +1655,10 @@ static const struct of_device_id cqspi_dt_ids[] = {
> .compatible = "intel,lgm-qspi",
> .data = &intel_lgm_qspi,
> },
> + {
> + .compatible = "pensando,cdns-qspi",
> + .data = &pen_cdns_qspi,
> + },
> { /* end of table */ }
> };
>
> --
> 2.17.1
>
Rest of the patch looks good to me.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-30 11:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 1:59 [PATCH v2 00/13] Support Pensando Elba SoC Brad Larson
2021-03-29 1:59 ` [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control Brad Larson
2021-03-29 10:41 ` Andy Shevchenko
2021-08-23 1:22 ` Brad Larson
2021-03-29 13:46 ` Linus Walleij
2021-03-31 18:10 ` Serge Semin
2021-08-23 1:24 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 02/13] spi: cadence-quadspi: Add QSPI support for Pensando Elba SoC Brad Larson
2021-03-30 11:13 ` Pratyush Yadav [this message]
2021-03-29 1:59 ` [PATCH v2 03/13] spi: dw: Add support for Pensando Elba SoC SPI Brad Larson
2021-03-29 10:43 ` Andy Shevchenko
2021-08-23 1:25 ` Brad Larson
2021-03-29 15:58 ` Mark Brown
2021-03-30 2:28 ` Brad Larson
2021-03-31 18:00 ` Serge Semin
2021-08-23 1:26 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 04/13] spidev: Add Pensando CPLD compatible Brad Larson
2021-03-29 10:44 ` Andy Shevchenko
2021-03-30 3:27 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 05/13] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2021-03-30 10:30 ` Ulf Hansson
2021-04-09 8:24 ` Masahiro Yamada
2021-08-23 1:31 ` Brad Larson
2021-08-23 1:28 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 06/13] arm64: Add config for Pensando SoC platforms Brad Larson
2021-03-29 1:59 ` [PATCH v2 07/13] arm64: dts: Add Pensando Elba SoC support Brad Larson
2021-03-30 21:55 ` Rob Herring
2021-08-23 1:36 ` Brad Larson
2021-03-31 17:51 ` Serge Semin
2021-08-23 1:55 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 08/13] dt-bindings: Add pensando vendor prefix Brad Larson
2021-03-30 21:56 ` Rob Herring
2021-03-29 1:59 ` [PATCH v2 09/13] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2021-03-30 21:56 ` Rob Herring
2021-03-29 1:59 ` [PATCH v2 10/13] dt-bindings: spi: cadence-qspi: Add support for Pensando Elba SoC Brad Larson
2021-03-29 16:00 ` Mark Brown
2021-03-30 2:12 ` Brad Larson
2021-03-30 11:12 ` Pratyush Yadav
2021-08-23 1:57 ` Brad Larson
2021-03-29 1:59 ` [PATCH v2 11/13] dt-bindings: gpio: Add Pensando Elba SoC support Brad Larson
2021-03-29 1:59 ` [PATCH v2 12/13] MAINTAINERS: Add entry for PENSANDO Brad Larson
2021-03-29 1:59 ` [PATCH v2 13/13] gpio: Use linux/gpio/driver.h Brad Larson
2021-03-29 6:48 ` Greg KH
2021-03-30 2:20 ` Brad Larson
2021-03-29 13:44 ` Linus Walleij
2021-03-30 2:21 ` Brad Larson
2021-03-31 16:17 ` [PATCH v2 00/13] Support Pensando Elba SoC Serge Semin
2021-08-23 1:18 ` Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330111308.7jjyj7nir6gmjnsv@ti.com \
--to=p.yadav@ti.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=brad@pensando.io \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).