From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6588FC433C1 for ; Wed, 31 Mar 2021 06:19:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D98D9619AA for ; Wed, 31 Mar 2021 06:19:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D98D9619AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iYsoK+y6i4YE0Ofb0H59m5/JLQD7MLLZkax81aT62AQ=; b=rRX7hrPVyplaRJvWmxtPgiGBL biOlWI+FCLWxLncC7UDE7puFVZ2Viae71Cfrb/3cxBnnh+pACGuIfNZ01rzdq1cUJuxIPEHXC7tF3 5tet0RY+17v5dBv7oHenk+2HuPnquCvuK+vSzrj8wJL04RZ7DX69T/GF6g1hU127dqMHWp4MRZ9yV Wy9HefsAixtNRJc/5JzfGD16Wasmuue2mF6HkLLQa4td1Qj7K5eFrfqOIfCmIs8Zcpl71fSxNKwKj 0miJvw60PpaQSEFOUzcAS8yzAsKTpbI3zInojUqJoL03ZrsM3eukiYS0rBZDEFUuACSKizBfHciAR FjTxI5zpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRUAi-005bLg-G0; Wed, 31 Mar 2021 06:17:44 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRUAb-005bL1-HI for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 06:17:39 +0000 Received: by mail-pg1-x529.google.com with SMTP id f3so4236871pgv.0 for ; Tue, 30 Mar 2021 23:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0F12Kqjhl0+Wf+5+6nbUD2UhZbKGbE/zQkJq2rrwfrg=; b=ETKZ6m2dIhEdGl7lpyRoB2yUuf70I1IvaCTOjGvIMaaKvmtRKgBNwRrZiHlHFF9FLC 5IC6C4vdPQfEv6N9iSc4Y/a+GHyAnDa/WQP8QCEuA2JeHJ0tCQd1PCs2hm37m3a83FdG lUJN2la5H5SNG9ca4n6Gvz2gWOCHTXI7Hqt1+547fOpkVLYFjK4s4Kab7qcoYbhdF8kt R/dbJehnFZVN2FS2VWRKYZ+5jEYXJif9lA1zRfNYdQQ/Db8fExQuFG8WIr7VffGYuHqL Gep9ggHp2FyYVKkJYhQjfi6+fmWJ3Q2h/mPQ9LOZPSrL7WZsQ/H4gU4xespePd5Be6Ke hjBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0F12Kqjhl0+Wf+5+6nbUD2UhZbKGbE/zQkJq2rrwfrg=; b=AeRV/pZyF8OqP3PsJ5cWHs+CEQV68qdAYPUUdQfX+tvjpnJlS5i/SIywxYJrpjKIQw BY6PS1ig7ToyTBR8Md2OeuciFuX/20a3BM+H8FJJNHCbkEwznuRd/+q0GKhSCVkugoiA E+h97QA3j61ds3/BbdGDYBarqRQqCrLPErxT2xDQosqsbsNOkjyxX2VltAlwL6wi/7hy j6LHnSWxDU7IeWdUGXlFMjr14p9aCmE6cisfhvUElWJz8q8tYJ8mr9LKQNkfPYLYgNZw B9DQlQGm3YCtt8YOKCppsJ46qn2+eK+jmjlAmNiPmeImDEaDCEps13a/fSsRMaFTLpMF nMOg== X-Gm-Message-State: AOAM531ZDK7g24tgi4VQeYBi68kHQF1n3fARMzO6bjFTJT3Jd/cjDdA+ zIWAZMoYIZX7yvWi2Q9kGb6LVQ== X-Google-Smtp-Source: ABdhPJyUuKeYXCKEUA4NkOYUgk8Iyh6P7JgE4L/NH6X8jw8VdbsGYKbm85djXpBaeUhPOWcYBHroZA== X-Received: by 2002:a63:1820:: with SMTP id y32mr1724701pgl.157.1617171454697; Tue, 30 Mar 2021 23:17:34 -0700 (PDT) Received: from localhost ([136.185.154.93]) by smtp.gmail.com with ESMTPSA id d6sm902402pfn.197.2021.03.30.23.17.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Mar 2021 23:17:34 -0700 (PDT) Date: Wed, 31 Mar 2021 11:47:32 +0530 From: Viresh Kumar To: "andrew-sh.cheng" Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Mark Rutland , Matthias Brugger , "Rafael J. Wysocki" , Nishanth Menon , Stephen Boyd , Liam Girdwood , Mark Brown , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH V8 2/8] cpufreq: mediatek: Enable clock and regulator Message-ID: <20210331061732.c7rfrzehcqo62ndc@vireshk-i7> References: <1616499241-4906-1-git-send-email-andrew-sh.cheng@mediatek.com> <1616499241-4906-3-git-send-email-andrew-sh.cheng@mediatek.com> <20210330043629.x62j2apv2nv4mw67@vireshk-i7> <1617168099.18405.8.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617168099.18405.8.camel@mtksdaap41> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_071737_890931_8A1CFF8B X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31-03-21, 13:21, andrew-sh.cheng wrote: > Hi Viresh, > Yes. > As you mentioned, it will be enable by OPP core. > > Per discuss with hotplug owner and regulator owner, > they suggest that "users should not suppose other module, will enable > regulators for them". > They suggest to add enable_regulator here. Which is fine if the modules in question aren't closely related to each other, but OPP core and cpufreq are too closely bound to each other. So much that the cpufreq driver can depend on the OPP core for doing it. Though I won't Nack a patch just for that, but it was just a suggestion. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel