From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CD0C433B4 for ; Tue, 6 Apr 2021 12:21:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A46C613BD for ; Tue, 6 Apr 2021 12:21:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A46C613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=us.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:In-Reply-To:References: Message-ID:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WfRfiic1oguFkAnKgXsWyEPZW6MWp7zg4DDlZlHTuPA=; b=CjGkIFTYM9CjMC EFqpHI4NtycYfsZn+fIY2hQ+kGdCzDdpjtrpTbufVjPFS+/bYEbDeL71v8TLZRtPEEyN7rNG6e8hC zpDRIGv4imR12FJnEqI4uGuO/iU+RljjNi/K448rsgdIkhlDiirISF3TW5rTpJa3o82kuYlQJPGhg B3GT8/ntOhnKxtfTYHCTKl1nAv+BjRzzQFt6u1rkys7Af5FLRQCd/slPM3aWaDdJ5hEz/THllfOpN OA5naRs/heE0gLk2CE/xr5+si08zijWqYXF42Ta3mvzysk56WXLt6BD+WEZSUNCLK2ExpfOtABWAC ysroS/9gJEvapNuuUzmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTkgE-002ZG0-57; Tue, 06 Apr 2021 12:19:38 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTkg8-002Z7c-0X for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 12:19:35 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 136CBmn9110521; Tue, 6 Apr 2021 08:18:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : message-id : references : content-type : in-reply-to : mime-version : subject; s=pp1; bh=zRWvsb4XuGZMzURwTRd+STVFZ07kypvKJ1Wvk1rlDiE=; b=IhAeqqcZ5aP5MHBfiJ750+I3o35J5dwJMr54xtGaFmlr9VtXLdalPVKl1AbGbtkGAhm7 MmWe2QvCvVUJPgO/OISScB+IIGIuw0JjO2vbBcJ2eSn20VZel3UcxgClc+QiB2FL7Lor CaCpkFHhteg6mMdi0MGWNBAzFzeiZukhXZihKhKH+JmIG9TH6udWSfCgottiOvToBN/U +h+0t6m1CHj5qEyGihceqt6eufcPQJZ4Bvq+1y9/6FbZ7Ga7Bbnr2vzNuNB1R6edRErv 9+vjVe2IdeV/SdIzHUDTNSqPlyQ6DVGf6B+vOAwsf33ZKnrTni2t86N0/5ifmr8ygW/h CQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 37rq1w0yxe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 08:18:48 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 136CCB8f112973; Tue, 6 Apr 2021 08:18:48 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 37rq1w0ywy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 08:18:48 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 136C7ZIr022908; Tue, 6 Apr 2021 12:18:46 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04dal.us.ibm.com with ESMTP id 37q2n6bjgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 12:18:46 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 136CIjN628639728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Apr 2021 12:18:45 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D8116E04C; Tue, 6 Apr 2021 12:18:45 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A03206E052; Tue, 6 Apr 2021 12:18:42 +0000 (GMT) Received: from li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com (unknown [9.85.178.250]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTPS; Tue, 6 Apr 2021 12:18:42 +0000 (GMT) Date: Tue, 6 Apr 2021 07:18:40 -0500 From: "Paul A. Clarke" To: John Garry Cc: kajoljain , will@kernel.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, irogers@google.com, linuxarm@huawei.com, kan.liang@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, zhangshaokun@hisilicon.com Message-ID: <20210406121840.GK8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> References: <1616668398-144648-1-git-send-email-john.garry@huawei.com> <20210325203944.GD8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> <20210329210717.GF8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> <247e9484-34c8-544a-e268-b025ecb317fe@linux.ibm.com> <1d800da3-ec94-3a37-eca9-1d3cf8543ba6@huawei.com> Content-Disposition: inline In-Reply-To: <1d800da3-ec94-3a37-eca9-1d3cf8543ba6@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ea4gPTtHTMP5FYvzmn0KrtI5KMaoHrd- X-Proofpoint-GUID: ZNKRsBlKyIdmHkBe1RUg5EIwA4fIsrU0 X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 Subject: RE: [PATCH v2 0/6] perf arm64 metricgroup support X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-04-06_03:2021-04-01, 2021-04-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104030000 definitions=main-2104060084 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_131932_929081_B02B8326 X-CRM114-Status: GOOD ( 34.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 06, 2021 at 12:02:36PM +0100, John Garry wrote: > On 30/03/2021 07:41, kajoljain wrote: > > On 3/30/21 2:37 AM, Paul A. Clarke wrote: > > > On Fri, Mar 26, 2021 at 10:57:40AM +0000, John Garry wrote: > > > > On 25/03/2021 20:39, Paul A. Clarke wrote: > > > > > On Thu, Mar 25, 2021 at 06:33:12PM +0800, John Garry wrote: > > > > > > Metric reuse support is added for pmu-events parse metric testcase. > > > > > > This had been broken on power9 recentlty: > > > > > > https://lore.kernel.org/lkml/20210324015418.GC8931@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com/ > > > > > > > > > > Much better. Before: > > > > > -- > > > > > $ perf test -v 10 2>&1 | grep -i error | wc -l > > > > > 112 > > > > > -- > > > > > After: > > > > > -- > > > > > $ perf test -v 10 2>&1 | grep -i error | wc -l > > > > > 17 > > > > > -- > > > > > > > > > > And these seem like different types of issues: > > > > > -- > > > > > $ perf test -v 10 2>&1 | grep -i error > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_powerbus0_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs01_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > Error string 'Cannot find PMU `nest_mcs23_imc'. Missing kernel support?' help '(null)' > > > > > -- > > > > > > > > > > > > > This looks suspicious. > > > > > > > > Firstly, does /sys/bus/event_source/devices/nest_mcs01_imc (or others, > > > > above) exist on your system? I guess not. > > > > > > > > Secondly, checking Documentation/powerpc/imc.rst, we have examples of: > > > > nest_mcs01/PM_MCS01_64B_R... > > > > > > > > So is the PMU name correct in the metric file for nest_mcs01_imc? Looking at > > > > the kernel driver file, arch/powerpc/perf/imc-pmu.c, it seems to be correct. > > > > Not sure. > > > > > > I ran with a newer kernel, and the above errors disappeared, replaced with > > > about 10 of: > > > -- > > > Error string 'Cannot find PMU `hv_24x7'. Missing kernel support?' help '(null)' > > > -- > > > > > > ...but I was running without a hypervisor, so I tried the same kernel on a > > > PowerVM-virtualized system and the "hv_24x7" messages went away, but the > > > "nest" messages returned. This may all be expected behavior... I confess > > > I haven't followed these new perf capabilities closely. > > > > > > > Hi Paul/John, > > This is something expected. For nest-imc we need bare-metal system and for > > hv-24x7 we need VM environment. Since you are checking this test in VM machine, > > there nest events are not supported and hence we are getting this error. > > > > Thanks, > > Kajol Jain > > Cool, so I hope that tested-by or similar can be provided :) [obviously > pending any changes that come from reviews] Certainly! Tested-by: Paul A. Clarke PC _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel