From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDC2C433B4 for ; Thu, 8 Apr 2021 19:52:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75A34610E6 for ; Thu, 8 Apr 2021 19:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75A34610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=mUlE11xmyHWVKOlOUHfNPp80eVDifeBmYgXwU1lJi/k=; b=McKBzAHEgvPI6/HmFTaXfNVFf5 WmgwdHY8wv+RCoW4aGczmWGUqKhajVnWnzv7fwTct8UziDOwgboH8wcheRfyNXRDHT8C2hX7h+Nwz 2cPZgAzTRLk9T/47UArjLXIGUP467OIOcUxlY/KWjKocEoUls/wQUqyXSJjSe1GNFYtKiBEQPpRg7 HfVfTMX0V65xrp3bpufGtWNOXN9m3OiS1rxzq/5+safZiTqCjvSK5+iq/BRW5xw9br8ZNVTP3d1ws qJx9kN3QfZySZfATTs34q6/VBHUY8qd5Wa1WSnEqK2ergQ6C862hIYAn68MdHqWj5ClAFnj/FIc3D CyZJ56pg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUafr-0098UA-3P; Thu, 08 Apr 2021 19:50:43 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUafl-0098TG-UV for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 19:50:39 +0000 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lUafk-00042c-9G for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 19:50:36 +0000 Received: by mail-wr1-f72.google.com with SMTP id j4so1409815wru.20 for ; Thu, 08 Apr 2021 12:50:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/I3rxjojN2v/kK7LxnxTnuoS/24IOjJzT+k5Y2qcQ58=; b=A8x+obWswZuwQ+8yImlm/Q6eLM44apFCIG3CfEciPWIrUaST032CTGditbFoTOZRr8 7OdbKdUQZxjFXPiGORnOlk8sWOqxnkImnnERS+96MnpRfzuHKtaRj4I/JspcnLrou27X hXTFMX6JnSRAWP4SCLYMj9uzU2v78AqHS1xUyHXTmeyTP0lposS4b9S8CaP4mSHFr6Yz uXVkunT7KXTxRwzf2tVANWqc0/+GOYduxe/JRKZUnf4aomUqPBlW36+91/PDbGAMgtWN 3um5QIxn21hdOosiDbXbWpbx1A3ERlAhE3jop/UXinnBMUzUn7y3lykYVzCMUsi9t5nH gFCg== X-Gm-Message-State: AOAM531nAL0jWIRHxGAvg6QQoSEvMy5yu4+5GLOK0LfSGnmRcHazXghM Kue5s6wXF5wz534w1BNuF/mre5UfZ8BS16yBnVCBL4DhZwwx4dH/sjEo35VoaxAyOSsjJiO7kCd 9nL7uJoEuSRLTZuM+U9L0zGfxlavI9hhORK0+E9LDqsNmbwl+HtVe X-Received: by 2002:adf:ea46:: with SMTP id j6mr13632658wrn.34.1617911436044; Thu, 08 Apr 2021 12:50:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzylv5JuU33P7EpPdff1gvFG44EL00KZzjjJZBKpQNPh3ZDEbsa5BmwCFBD7BAoFjC2rPb72g== X-Received: by 2002:adf:ea46:: with SMTP id j6mr13632640wrn.34.1617911435854; Thu, 08 Apr 2021 12:50:35 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id f20sm312022wmg.36.2021.04.08.12.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 12:50:35 -0700 (PDT) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: [PATCH] pinctrl: samsung: use 'int' for register masks in Exynos Date: Thu, 8 Apr 2021 21:50:29 +0200 Message-Id: <20210408195029.69974-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_205038_177032_1663CE1A X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Special Function Registers on all Exynos SoC, including ARM64, are 32-bit wide, so entire driver uses matching functions like readl() or writel(). On 64-bit ARM using unsigned long for register masks: 1. makes little sense as immediately after bitwise operation it will be cast to 32-bit value when calling writel(), 2. is actually error-prone because it might promote other operands to 64-bit. Addresses-Coverity: Unintentional integer overflow Signed-off-by: Krzysztof Kozlowski --- Not tested on ARM64. Dear Linus, Please apply it directly, I don't have any patches for Samsung pinctrl in my tree. --- drivers/pinctrl/samsung/pinctrl-exynos.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 0cd7f33cdf25..2b99f4130e1e 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -55,7 +55,7 @@ static void exynos_irq_mask(struct irq_data *irqd) struct exynos_irq_chip *our_chip = to_exynos_irq_chip(chip); struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); unsigned long reg_mask = our_chip->eint_mask + bank->eint_offset; - unsigned long mask; + unsigned int mask; unsigned long flags; raw_spin_lock_irqsave(&bank->slock, flags); @@ -83,7 +83,7 @@ static void exynos_irq_unmask(struct irq_data *irqd) struct exynos_irq_chip *our_chip = to_exynos_irq_chip(chip); struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); unsigned long reg_mask = our_chip->eint_mask + bank->eint_offset; - unsigned long mask; + unsigned int mask; unsigned long flags; /* @@ -483,7 +483,7 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) chained_irq_exit(chip, desc); } -static inline void exynos_irq_demux_eint(unsigned long pend, +static inline void exynos_irq_demux_eint(unsigned int pend, struct irq_domain *domain) { unsigned int irq; @@ -500,8 +500,8 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc) { struct irq_chip *chip = irq_desc_get_chip(desc); struct exynos_muxed_weint_data *eintd = irq_desc_get_handler_data(desc); - unsigned long pend; - unsigned long mask; + unsigned int pend; + unsigned int mask; int i; chained_irq_enter(chip, desc); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel