From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8AC0C433B4 for ; Tue, 13 Apr 2021 03:35:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 612336120E for ; Tue, 13 Apr 2021 03:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 612336120E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0CRgXMo1b1GXyiFv2Ogq7nhyFHsAImRhfh41cLaUmBM=; b=V6qiulXQLOVbxF6Z/p68moOw6 WIayMtVtOT2ZavsOuChNnCZen5cxwg6o7JWCnSndXxyvMRVgoKc0Su92R+z9XsG9MrXFfA/tUsvlJ A4F7xHDlzVdQyNTil9a7mxOy9bmVWz3ehTivziTI1dcsPhFRbQGIwfKpjy4FmTJD6VTBmM8aL6bPv y6GNqT6o/YeFv01yRHiGK9CyeoOmsKs1E++CAU8KKuGxYfBSYNRvQXDRuNIxC0NODJvncbK676pTq dwZ8lQ/EntvgQz2vupkt6XIRSKtvrNf6EUkU3SwRHmRlX9Xkikuz2TeP64JpSNlVrMjl7qKj6OtrQ Mg2HIkY0Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW9nQ-008ACn-Jy; Tue, 13 Apr 2021 03:33:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW9nM-008ACf-AD for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 03:32:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B/Oenh+b5aPc1oa+q7TNqKUaxvywdi6UhCupNXNGC/I=; b=fh7kFxvr9IuqmfndFqe9tuP1I1 XbECLVvor/GuTwQ7JCn3EXsTCvN3Sq9j+G2n3sNhlEp543TLDP+wD6ElHKjydaFfELzrUpQgSNkG5 a5L+KYSsAeWsqL4BS7Tq7nGAvbxDW5Vgxw5xbCMlIcVLrOS+IiSG4KcV5nvZeerkDphAhvql22AtA quf3DfeFXr1Z0DI59c/jqlQ4k/a9l/sP2oxbuZ4i0AG8q5CnagapmRVJXxnFO+xKvEiAOCnRmeaTe eziG5+2rzJ19Zzqx35c3hQqAVZmpYUbPHLD6ktuyOS6GZ4oW40+Ha68e6crzqSfv6cbbClrS3JfiQ oBn51v/A==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW9n5-005Cnv-Oa for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 03:32:45 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 13D3LYpM091103; Tue, 13 Apr 2021 11:21:34 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 11:31:58 +0800 Date: Tue, 13 Apr 2021 11:31:56 +0800 From: Steven Lee To: Ulf Hansson CC: Andrew Jeffery , Rob Herring , "Joel Stanley" , Adrian Hunter , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , "open list:ASPEED SD/MMC DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Ryan Chen , Chin-Ting Kuo Subject: Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio Message-ID: <20210413033155.GA3522@aspeedtech.com> References: <20210408015218.20560-1-steven_lee@aspeedtech.com> <20210408015218.20560-2-steven_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 13D3LYpM091103 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_043243_030763_49279663 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 04/12/2021 15:38, Ulf Hansson wrote: > On Thu, 8 Apr 2021 at 03:52, Steven Lee wrote: > > > > AST2600-A2 EVB provides the reference design for enabling SD bus power > > and toggling SD bus signal voltage by GPIO pins. > > Add the definition and example for power-gpio and power-switch-gpio > > properties. > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to power > > load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is connected to > > a 1.8v and a 3.3v power load switch that providing signal voltage to > > SD1 bus. > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > disabled. > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 signal > > voltage is 3.3v. Otherwise, 1.8v power load switch will be enabled, SD1 > > signal voltage becomes 1.8v. > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and GPIOV3 > > as power-switch-gpio. > > Thanks for sharing the details, it certainly helps while reviewing. > > > > > Signed-off-by: Steven Lee > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > index 987b287f3bff..515a74614f3c 100644 > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -37,6 +37,14 @@ properties: > > clocks: > > maxItems: 1 > > description: The SD/SDIO controller clock gate > > + power-gpio: > > + description: > > + The GPIO for enabling/disabling SD bus power. > > + maxItems: 1 > > + power-switch-gpio: > > + description: > > + The GPIO for toggling the signal voltage between 3.3v and 1.8v. > > + maxItems: 1 > > > > > > patternProperties: > > "^sdhci@[0-9a-f]+$": > > @@ -61,6 +69,14 @@ patternProperties: > > sdhci,auto-cmd12: > > type: boolean > > description: Specifies that controller should use auto CMD12 > > + power-gpio: > > + description: > > + The GPIO for enabling/disabling SD bus power. > > + maxItems: 1 > > + power-switch-gpio: > > + description: > > + The GPIO for toggling the signal voltage between 3.3v and 1.8v. > > + maxItems: 1 > > required: > > Please do not model these as GPIO pins like this. Instead, it's better > to model them as gpio regulators, since the mmc core manages them as > regulators. > > We have a vmmc regulator (corresponding to vdd) and a vqmmc regulator > (corresponding the signal-voltage level). These are also described in > the common mmc DT bindings, see > Documentation/devicetree/bindings/mmc/mmc-controller.yaml. > Thanks for the information. I will modify it. > > - compatible > > - reg > > @@ -80,6 +96,7 @@ required: > > examples: > > - | > > #include > > + #include > > sdc@1e740000 { > > compatible = "aspeed,ast2500-sd-controller"; > > reg = <0x1e740000 0x100>; > > @@ -94,6 +111,10 @@ examples: > > interrupts = <26>; > > sdhci,auto-cmd12; > > clocks = <&syscon ASPEED_CLK_SDIO>; > > + power-gpio = <&gpio0 ASPEED_GPIO(V, 0) > > + GPIO_ACTIVE_HIGH>; > > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 1) > > + GPIO_ACTIVE_HIGH>; > > }; > > > > sdhci1: sdhci@200 { > > @@ -102,5 +123,9 @@ examples: > > interrupts = <26>; > > sdhci,auto-cmd12; > > clocks = <&syscon ASPEED_CLK_SDIO>; > > + power-gpio = <&gpio0 ASPEED_GPIO(V, 2) > > + GPIO_ACTIVE_HIGH>; > > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 3) > > + GPIO_ACTIVE_HIGH>; > > }; > > }; > > Kind regards > Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel