From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D726DC433ED for ; Mon, 19 Apr 2021 07:35:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E46C61104 for ; Mon, 19 Apr 2021 07:35:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E46C61104 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5ohk1QsGCQb4Lbz13bqfO36Q3+pUYO+YtUyCamQXBHI=; b=oPze3KHMDrAq3fbgmsf76YAZK yzFKQMwn1moMAUHinmqMw1OCp6TGxAVqBH1lvcQJ0OJpo+tHJQbT7tlJ6NjBY5ZRt81mD6mjj29Ke gDCvzxnKFTgAnrpMzuk5ge7HtC4UQ0DuD0E7Nh+s2JdlbZIhjgW84cwki5mzYIuIrmGmu9EIMfB6A 4Bz1vZJwNMpzDtsflsAXna3p2wUabABtJdPJjNHznOnMp//pUxbEwDCKkwd6lfL/CwdICyyqokN/B R61kkubTBne5AMDoU+V9SWydCNCK/1hthH+zPLbuzTUm3A8LUjDmiZAL7mSI7EO0JsMA6y/m4SZFj 157j7T0Dw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYOOs-009LGT-Db; Mon, 19 Apr 2021 07:32:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYOOp-009LG7-ID for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 07:32:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VrhWZP0WLVCAIu2adHBvocmpnq1hUR+uWyz8+FKDUXg=; b=IyLOxnSoV2l8gXEbWaMx7WC56k DKfxiUgYQDA+jfRkmzf2g8vEbLLXjFyWKovhQMNrjZ2X3e+eTGpG6tqoS5WGPeFeaS+yLCEV2bBMf bXTPU/e8/5V7FX9vby5dOX9OYQus9A23HArnTYULcoKn+1ZiYo9AOBtUeSrAKPu6f5nmGB5IMzoPf 5sXxvq8FL2Mf0CLsxLvI5j8Ur4NQP0UHBXm51SC9ZZmll20Gb0250Av+yOmJV66WsTAeBv6UF+ObE GGVctMTR0djj+T5Cozs1veNPZvHaVZz3JbqpGRMs2wHaepWhmlDiRMVCFgujhuQkSVY8IhVICc4pf whLrwjcA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYOOj-00B8Ix-Ux for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 07:32:50 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYOOg-0000VL-3z; Mon, 19 Apr 2021 09:32:42 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lYOOd-00028m-Gy; Mon, 19 Apr 2021 09:32:39 +0200 Date: Mon, 19 Apr 2021 09:32:39 +0200 From: Michael Tretter To: Rajan Vaja Cc: "linux-arm-kernel@lists.infradead.org" , Michal Simek , Jolly Shah Subject: Re: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE Message-ID: <20210419073239.GA12636@pengutronix.de> References: <20210317160410.2097178-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:07:39 up 60 days, 10:31, 96 users, load average: 0.10, 0.25, 0.24 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_003246_023117_FB1D3067 X-CRM114-Status: GOOD ( 28.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rajan, On Thu, 15 Apr 2021 16:27:58 +0000, Rajan Vaja wrote: > Thanks for the patch. > > > -----Original Message----- > > From: Michael Tretter > > Sent: 17 March 2021 09:34 PM > > To: linux-arm-kernel@lists.infradead.org > > Cc: Michal Simek ; Rajan Vaja ; Jolly > > Shah ; m.tretter@pengutronix.de > > Subject: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE > > > > Patch 1 of this series fixes the ZynqMP PMU FW power management > > initialization, which was done by the wrong driver. PM_INIT_FINALIZE must be > > called from the zynqmp_pm_domains driver, which handles power domains, instead > > of the zynmp_power driver, which is responsible for suspend and shutdown. > [Rajan] I am fine with moving to genpd but zynqmp_pm_init_finalize() needs to be late call. > zynqmp_pm_init_finalize() should be called when Linux has requested all the devices through > genpd driver. Making it late call will make sure it. What is the reason why all devices have to be requested before calling zynqmp_pm_init_finalize()? I was expecting that calling PM_INIT_FINALIZE only would tell the PMU_FW that Linux is using the PM API and the PMU_FW should power down/up PM slaves as requested by Linux. It is somewhat surprising that this isn't the case and all PM slaves have to be powered up before calling PM_INIT_FINALIZE. What would happen if some driver is built as a module? In that case, the module would be loaded and request the pm node only after PM_INIT_FINALIZE was called. Do we have to avoid/disallow such cases? For USB, I am actually observing a similar situation: If I do not request the USB PM slave before I call PM_INIT_FINALIZE, I see communication errors with connected USB devices. Could this be related? Thanks, Michael > > > > > Patches 2 to 4 are various cleanup patches to improve the readability and > > debugging experience of the zynqmp_pm_domains driver. > > > > Michael > > > > Michael Tretter (4): > > soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver > > soc: xilinx: cleanup debug and error messages > > soc: xilinx: use a properly named field instead of flags > > soc: xilinx: add a to_zynqmp_pm_domain macro > > > > drivers/soc/xilinx/zynqmp_pm_domains.c | 79 +++++++++++++------------- > > drivers/soc/xilinx/zynqmp_power.c | 1 - > > 2 files changed, 38 insertions(+), 42 deletions(-) > > > > -- > > 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel