From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FAEC433ED for ; Tue, 20 Apr 2021 14:07:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2D0613AF for ; Tue, 20 Apr 2021 14:07:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2D0613AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t5EmkKpfBmVuJCEadCsCGFVz+H/w4U3MGLQrAtCH4ds=; b=jJwCgJb97oQGTx8BZtsoCKt5m 78LxDpQz3k3wr2dZ8lZI3UCb+jBfclbdLp69jFlLTCpaOgqLeBasJVdt0peIp+zEa5Emp6hN01DVk xEda3z/v7bVVXSTGEXx5bMF0Ozi/J7+EbAjX76zwWxKIuGlQOFr0SMAJ9CCAWJF9Nl88KSkZVbT87 fTIOYxXojVbctO/vzsL+C5iktR3ojI1hsGUOVZVhJDSTt9tHpXW21IEVgOMMdOfMHxb+a+7ZhrBNF XkHjtcEpC3YVdbQLjd/WiR60RDJOkLr9XDBF7InYliwLTr5n60J03EmA3FYkVYBAJ771hRP0C/ncw hg01kaQhA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYqzm-00CIV7-Kp; Tue, 20 Apr 2021 14:04:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqzk-00CIUt-Bs for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 14:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GWZ9/iUv0FXDeIpnx9QoQpsz7gywyohQ1hXkns45YHk=; b=fnAP6Q2NXWZg8jLU96vWyjsChP Y0Q7pKoSHxTN2ZteZfvp2Fve0L6Tq7tvrh18FVd1TQjNwMwF/y1nnH13KEURPd58MddHBy4pW0Npi K7dqqxKnKeckNqUoJuDVTdvevg0RZTBiLBp/rz65oSvMokNuVlpR8H5zMmPi1QCygwkvuRlx64ntG rbAg9mFJa0d6P00n3fQMTQNTKUn/QMh20Y65bQ5ARhgErOip9SAPiXIDANitQGoMffvn1uCz2vBUG ZdTEJhwjhDWOqCW06/9nAgZKciKc36yc2P986TI/nyfNNlStsy+u/ADNuJgBQIvbnJI9Woaiv01J2 Ofolj77g==; Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqze-00CB0L-NF for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 14:04:51 +0000 Received: by mail-pl1-x631.google.com with SMTP id v13so6136619ple.9 for ; Tue, 20 Apr 2021 07:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GWZ9/iUv0FXDeIpnx9QoQpsz7gywyohQ1hXkns45YHk=; b=ZaRkSt5KlIUTQC5awcwrSay8EjrsfYLcEGIdVI/hfGabX8AQ85CfLf8aMjKJkKmvzW 1om80L/5MfBcQD5KiyZrfZCZlp+ylttGuHF9xA96nGcI7Bkz1EJdbTu5HlfpMbu4X9KN LyyPh0PxEuA9ckcSoX+tH/t1DBwMj63PVbUpWasTCQ0IC2t/y7XhTnsV8f83Nzkgv9ya +1DMuh9o7rwi9/X4F7yMVwvGz7c6uKljqB9mrs3T2r4pEOd4c2Y8UxcOLFK7yEu8EjU0 wsJ8yVhz4EKieCxilWO3+flHeFTpShUfPBBIPSU5KAN7QAcANZTJA6WuGjvQA2TOLXlL RR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GWZ9/iUv0FXDeIpnx9QoQpsz7gywyohQ1hXkns45YHk=; b=l+DHwVaqBa03i99gGJw86mwAFJuCCZfQdOZHiFFmRWyPhC1H6s5jmc9MdMpi0WwEbU qTKD5l2okY74QT+pULkiiG/SEsfj8KpVCj6guYIq1YhaG9kr6Z+LoJgyj2TATheq3r9h E+Np9ITuW/LubrubtTcnMl8IUX1vnG+cqtWmIFUNGPLU6L2TPQ5OYgoTvh64fLBgjoFS GR4cjFep2+UMHw1II3/zDv9udAGgwggijioWTSL359xJCEBkKyFCmK2qQ3HL2BAmidIt DGQ0rBoutmV5ZDCwJwAvdJO/atmNK16ZFi5pDk38z29qXif/bHLvu2DtG9NxYI+5S1Z9 a0QQ== X-Gm-Message-State: AOAM530bBl/SrEvhv++O1jv0/h1MjT9tw8XfIP+kxrjUh3oJHdp88C+/ r1RBq8FCf0+MlDYVz8w/zzQ= X-Google-Smtp-Source: ABdhPJxa+tOj6HMWgne03HIClGYrmW6UvTyxsScQNcsf2xFSurAAxJcynVxP2gTfZ3ds5HO10TPRfA== X-Received: by 2002:a17:902:f54d:b029:ec:939f:747d with SMTP id h13-20020a170902f54db02900ec939f747dmr16157951plf.84.1618927485895; Tue, 20 Apr 2021 07:04:45 -0700 (PDT) Received: from skbuf (5-12-16-165.residential.rdsnet.ro. [5.12.16.165]) by smtp.gmail.com with ESMTPSA id hi5sm2600734pjb.31.2021.04.20.07.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 07:04:45 -0700 (PDT) Date: Tue, 20 Apr 2021 17:04:33 +0300 From: Vladimir Oltean To: Michael Walle Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC Message-ID: <20210420140433.hajuvfiz4humhhkt@skbuf> References: <20210416234225.3715819-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_070446_780459_39B728E8 X-CRM114-Status: GOOD ( 27.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, On Tue, Apr 20, 2021 at 03:27:24PM +0200, Michael Walle wrote: > Hi Vladimir, > > Am 2021-04-17 01:42, schrieb Vladimir Oltean: > > From: Vladimir Oltean > > > > This patch series contains logic for enabling the lossless mode on the > > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > > memory. > > > > During testing it was found that, with the default FIFO configuration, > > a sender which isn't persuaded by our PAUSE frames and keeps sending > > will cause some MAC RX frame errors. To mitigate this, we need to ensure > > that the FIFO never runs completely full, so we need to fix up a setting > > that was supposed to be configured well out of reset. Unfortunately this > > requires the addition of a new mini-driver. > > What happens if the mini driver is not enabled? Then the fixes aren't > applied and bad things happen (now with the addition of flow control), > right? > > I'm asking because, if you have the arm64 defconfig its not enabled. > > shouldn't it be something like: > > diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig > b/drivers/net/ethernet/freescale/enetc/Kconfig > index d88f60c2bb82..cdc0ff89388a 100644 > --- a/drivers/net/ethernet/freescale/enetc/Kconfig > +++ b/drivers/net/ethernet/freescale/enetc/Kconfig > @@ -2,7 +2,7 @@ > config FSL_ENETC > tristate "ENETC PF driver" > depends on PCI && PCI_MSI > - depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n > + select FSL_ENETC_IERB > select FSL_ENETC_MDIO > select PHYLINK > select PCS_LYNX Yes, ideally the IERB driver and the ENETC PF driver should be built in the same way, or the IERB driver can be built-in and the PF driver can be module. I don't know how to express this using Kconfig, sorry. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel