From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64BFC433ED for ; Wed, 21 Apr 2021 13:04:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94CA86145F for ; Wed, 21 Apr 2021 13:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94CA86145F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AWrsDz4fg/sNCspyO66JjY+a69UdE3FDAzlUohdWMJQ=; b=fUx5IT691T1HR9x+VGdcHuS+Y auS0ANLiEihx3DER9KwqJ8byE0VHN9kOvjlO6Na6dPNZ1wvpxjGD6G011J2negzxEEcHkM6zLN+ei 81zZNgZeZfJ7FQRhofcfT7xpUqBSONIVQ8Z6jZIgr0J7gt3FKSRqBqkrkhpEGiZrXm/6uCUlH63oR 0m+9xKqM29gEOko/oC52kSx5u9Rrw7hQMjXCXNBi+f5pOfy4j5Nz8ZLNbUeLR0SHlfMG8E23r/s4r IoHk2Ap/dofatuIiShzMuC5LIoLlvwQ8SapQQ0QjG94gs5sWkyXwhE2dq18uS9Z8ZCRz9kxSj1iRL e9aZSqUIA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZCVE-00EQ9l-5V; Wed, 21 Apr 2021 13:02:48 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZCVA-00EQ9Z-09 for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 13:02:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UeZwrAirP5oKmPZEmzMTtLTTyvCyMV+tCwRx9d87/lo=; b=ratI2gYeDcR+nn6B/iKH1O63J+ W29TuL8mOXBlLNMWVcBFCrZBaO9GJoFIZCQWdqUdxwBo2oQZwOOhunggGBzISpGSQa4NgPAarykn+ E+aNld/fnoxOMaJ3/j+5qpYEERaVfmqQ/ENl7YNqdOQBs/NH3iv8a6wGT6CCrI+V3zZefRRpP9Mah PseiWecAFkLZUZ6/lS7O8aV5/68qqrF2opYred7dkjo+sT34REzbvJcE0TgNr0376tQFUvf/quv7h XDg7BGblB8jWuJv+zY6bFN1Txh52fcllcmzTz/qV4Ah4/8vohis9hTh9riKcpHV4U+l+R9cTY7GPG KFzgd1PQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZCV7-00CsyV-CH for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 13:02:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9A2C6145E; Wed, 21 Apr 2021 13:02:39 +0000 (UTC) Date: Wed, 21 Apr 2021 14:02:37 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Marc Zyngier , Mark Rutland , Will Deacon Subject: Re: [PATCH] arm64: Force SPARSEMEM_VMEMMAP as the only memory management model Message-ID: <20210421130235.GC18635@arm.com> References: <20210420093559.23168-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_060241_469498_14C6F0D6 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 21, 2021 at 10:18:56AM +0530, Anshuman Khandual wrote: > On 4/20/21 3:05 PM, Catalin Marinas wrote: > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > > index b943879c1c24..15018dc59554 100644 > > --- a/arch/arm64/include/asm/memory.h > > +++ b/arch/arm64/include/asm/memory.h > > @@ -329,7 +329,7 @@ static inline void *phys_to_virt(phys_addr_t x) > > */ > > #define ARCH_PFN_OFFSET ((unsigned long)PHYS_PFN_OFFSET) > > > > -#if !defined(CONFIG_SPARSEMEM_VMEMMAP) || defined(CONFIG_DEBUG_VIRTUAL) > > +#if defined(CONFIG_DEBUG_VIRTUAL) > > A small nit. Should this be #ifdef CONFIG_DEBUG_VIRTUAL instead ? Yeah, for consistency I changed it to #ifdef. > This is > an user selectable config and the conditional check here does not have an > #elseif part either. But then there are similar such instances else where > on arm64 platform as well. I'm not sure I get it. What would an #elseif need to check? We already have an #else block for this #ifdef. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel