From: Nishanth Menon <nm@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema
Date: Thu, 22 Apr 2021 09:20:12 -0500 [thread overview]
Message-ID: <20210422142012.lcjiy2gaoqllzlna@nervy> (raw)
In-Reply-To: <20210421225212.GB1750844@robh.at.kernel.org>
On 17:52-20210421, Rob Herring wrote:
> On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote:
> > Convert linaro,optee-tz to json schema format for better documentation
> > and error checks.
> >
> > NOTE:
> > 1. This change does introduce a stricter naming convention for
> > optee nodes.
> > 2. We do have false positive checkpatch warning with this patch:
> > "DT binding docs and includes should be a separate patch"
>
> Not really something that needs to be in the commit msg. I'm aware of
> the issue, just haven't gotten around to fixing it.
sure, thanks..
In this patch and my previous patches as well, I will move them all
to diffstat comment.
> > +properties:
> > + $nodename:
> > + const: 'optee'
>
> Don't need quotes.
aarrgh.. yes, ofcourse.
>
> > +
> > + compatible:
> > + const: linaro,optee-tz
> > +
> > + method:
> > + description: The method of calling the OP-TEE Trusted OS.
> > + oneOf:
> > + - description: |
> > + SMC #0, with the register assignments specified
> > + in drivers/tee/optee/optee_smc.h
> > + items:
> > + - const: smc
> > + - description: |
> > + HVC #0, with the register assignments specified
> > + in drivers/tee/optee/optee_smc.h
> > + items:
> > + - const: hvc
>
> Please just do 'enum: [ smc, hvc ]' and rework to a single description.
Sure, will do. thanks for the comments.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-22 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 22:25 [PATCH] dt-bindings: arm: firmware: Convert linaro, optee-tz to json schema Nishanth Menon
2021-04-20 8:32 ` [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz " Jens Wiklander
2021-04-20 13:49 ` Nishanth Menon
2021-04-21 22:48 ` Rob Herring
2021-04-21 22:52 ` Rob Herring
2021-04-22 14:20 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422142012.lcjiy2gaoqllzlna@nervy \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).