From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB6CC433ED for ; Fri, 23 Apr 2021 08:25:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E1A561406 for ; Fri, 23 Apr 2021 08:25:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E1A561406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KrISl6z3o6y26T89LjzzRX03XhkGc4+pcG0qO8KdoGw=; b=XnLOh9SLHnjUPtRjwulryvLiK n8Tqa2mRbEyo+dYaJGzm0u4/srdvC4qwlZh4UVjwQAJJ3OlMX63VHnhci4zQJq46SeFp51xngMeJQ PfNhpzsFSTEkUTXgzHoigk4onPPGwBRlKtHJkydfJKYxNvYwG6Y8vCGCA5gR+omPUgZGvsf5HThHJ pCqds7cwfvQl+F5wvIkiwH4VWpwpmg4ojiFPdX7ciPFZiwzVVIqJao1DnMJP/ijWhtNTAYcKXB8ef 1ecq//vFTpEoJnGcAUzKsj42B/YEHrt/vMpHSAL9ei6LcF0sJqpSCN+c1BngMcpiWXRWJDRABtT61 z62Cblykg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZr61-0012ms-2K; Fri, 23 Apr 2021 08:23:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZr5m-0012l8-3b for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 08:23:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dt9HwIDrfI2/ch9J9rSa8flLYg6VDa/+n4OLPX1iizw=; b=bYdepcRgYt3321nMo+FEWEvRWn T7I2/Wb13nY9DlZ78wst5IHK2lBKoP1uWvkyRFxfTivRUI3RYI98OltqFHhvF0v1AOq4S8waUzwXt tt+l6D1UEG2OWa+QFc2AZo4qTZ5qt9IW5ubgfzannfV3CZR7c9nSIGD5Agc7i6rgHjXhEACHGAefH VikvY4ESeyTnMFdcIpvvmhT7bqnIhyPY4URRK/HcYAK5w9WOn/Bm2cW3ua0Lc2d34aGkXA7Ggz7TQ htvtDUdhS5En/l3Hu6fnJ+zMEV9L2NJPisJHKyQsB3pihW+uDY6gIOS6Nx9iHySizTy7w8ySqZvc8 eFnp7JJg==; Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZr5j-00EFmA-As for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 08:23:12 +0000 Received: by mail-pf1-x42a.google.com with SMTP id q2so1642855pfk.9 for ; Fri, 23 Apr 2021 01:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dt9HwIDrfI2/ch9J9rSa8flLYg6VDa/+n4OLPX1iizw=; b=frW0po5FgAq+q+y3Fz3HvRPDGooCP+B/jO9QUDtqXyOYenHmHYEjbs9+gxQ836EO3v 8uZBGvBgnejNosjf8xx9MAV7blS2bFJdf8G936a5geyvZ4FkmqjyeNzU7mSHx8yqKNZA Pb0YW0zL8/p2udkh8nn5uosEHUds5/E8F/cE5kGLvXccqW6yPdZFHq8vmC8reo2gefvd AFbyeuFXtGPmk5wPNB4tlaCqGv3GSvFzsRrQ0VRJa4rWxV3ASfeyyHZBt2c6FEp7snmI 9TEXlzMCLJB1A970cYD8ClwUIiR73pGRykxtLponglCewY4LZ0Xs271TNXus6iiiCmae 9t9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dt9HwIDrfI2/ch9J9rSa8flLYg6VDa/+n4OLPX1iizw=; b=JBryH6SyEQZjSXrszpoEuE/WQjKPONvXMqOtW260TLnhiY94KZfmn3CN+Vt7ue3DXW cRZrZ+x1ygIAkV3drHCjwysXC116BgPcy76wHf7PA4W4YLoeG9BChBoh6dL+mlkJ3Dwp btRC/3js4ur6Jmc9o/QbbAswZ9AKr6ep9xJt6HlR2FJsW8w6hY8+BU9f0LdOamzN8gJA ARZ6w/QtyImJgmI3mDyIbZAhiYd6bEA0VEVZkBEwk90PR4QHtJYOrlOE5M8A2nESq024 NDY4n5ZvFzgW+gBK6q4CHpZ6zzWeCb5ezD8X59yZiS+BVAp8PbswHGDt7+nwJp1eFbdP g+zw== X-Gm-Message-State: AOAM5318bPm9h2VVgGALPF9gbT9xydze6FX9JeU+mbDZfDJu7fy1pzfh 5DSnnicakhysX9BLongHfWxSkA== X-Google-Smtp-Source: ABdhPJwp6R++B8/RH9RTVR+lsX+pc0Ty6QQ9g+2gAHq1Bs1HvpQ5wgdTUnqV3r3BZo4mspeCKIyaCw== X-Received: by 2002:a63:4413:: with SMTP id r19mr2656837pga.75.1619166189058; Fri, 23 Apr 2021 01:23:09 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id x13sm4318087pgf.13.2021.04.23.01.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 01:23:08 -0700 (PDT) Date: Fri, 23 Apr 2021 16:23:04 +0800 From: Leo Yan To: Daniel Kiss Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, denik@google.com, Branislav Rankov Subject: Re: [PATCH 1/4] coresight: tmc-etr: Advance buffer pointer in sync buffer. Message-ID: <20210423082304.GA377091@leoy-ThinkPad-X240s> References: <20210421120413.3110775-1-daniel.kiss@arm.com> <20210421120413.3110775-2-daniel.kiss@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210421120413.3110775-2-daniel.kiss@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_012311_408431_B8876A8E X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 21, 2021 at 02:04:10PM +0200, Daniel Kiss wrote: > With polling the sync could called multiple times in a row. Without this > change the data will be overwritten at the beginning of the buffer. > > Signed-off-by: Daniel Kiss > Signed-off-by: Branislav Rankov >From the last week, I spent time to dig into AUX trace buffer, thus this patch set gives me a good chance to apply my learning for perf ring buffer. For this patch: Reviewed-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index ea5027e397d02..dd19d1d1c3b38 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -1442,7 +1442,7 @@ static void tmc_etr_sync_perf_buffer(struct etr_perf_buffer *etr_perf, > { > long bytes; > long pg_idx, pg_offset; > - unsigned long head = etr_perf->head; > + unsigned long head; > char **dst_pages, *src_buf; > struct etr_buf *etr_buf = etr_perf->etr_buf; > > @@ -1465,7 +1465,7 @@ static void tmc_etr_sync_perf_buffer(struct etr_perf_buffer *etr_perf, > bytes = tmc_etr_buf_get_data(etr_buf, src_offset, to_copy, > &src_buf); > if (WARN_ON_ONCE(bytes <= 0)) > - break; > + return; > bytes = min(bytes, (long)(PAGE_SIZE - pg_offset)); > > memcpy(dst_pages[pg_idx] + pg_offset, src_buf, bytes); > @@ -1483,6 +1483,7 @@ static void tmc_etr_sync_perf_buffer(struct etr_perf_buffer *etr_perf, > /* Move source pointers */ > src_offset += bytes; > } > + etr_perf->head = (pg_idx << PAGE_SHIFT) + pg_offset; > } > > /* > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel