From: He Zhe <zhe.he@windriver.com>
To: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
eparis@redhat.com, linux-audit@redhat.com,
linux-kernel@vger.kernel.org, zhe.he@windriver.com
Subject: [PATCH v2 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat
Date: Fri, 23 Apr 2021 18:35:32 +0800 [thread overview]
Message-ID: <20210423103533.30121-2-zhe.he@windriver.com> (raw)
In-Reply-To: <20210423103533.30121-1-zhe.he@windriver.com>
Add sign extension handling in syscall_get_return_value so that it can
handle 32-bit compatible case and can be used by for example audit, just
like what syscall_get_error does.
Suggested-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: He Zhe <zhe.he@windriver.com>
---
v1 to v2: Improve error code check suggested by Mark
arch/arm64/include/asm/syscall.h | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/syscall.h b/arch/arm64/include/asm/syscall.h
index cfc0672013f6..c3b5fca82ff4 100644
--- a/arch/arm64/include/asm/syscall.h
+++ b/arch/arm64/include/asm/syscall.h
@@ -44,7 +44,20 @@ static inline long syscall_get_error(struct task_struct *task,
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
- return regs->regs[0];
+ long val = regs->regs[0];
+ long error = val;
+
+ if (compat_user_mode(regs))
+ error = sign_extend64(error, 31);
+
+ /*
+ * Return codes with bit 31 set may or may not be an error code.
+ * For example, mmap may return a legal 32 bit address with bit 31 set
+ * for 32 bit thread, in which case the untouched val should be
+ * returned. Otherwise, the sign-extended error should be returned if
+ * it still falls in error number range.
+ */
+ return IS_ERR_VALUE(error) ? error : val;
}
static inline void syscall_set_return_value(struct task_struct *task,
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-23 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 10:35 [PATCH v2 1/3] arm64: ptrace: Add is_syscall_success to handle compat He Zhe
2021-04-23 10:35 ` He Zhe [this message]
2021-05-05 17:30 ` [PATCH v2 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat Mark Rutland
2021-04-23 10:35 ` [PATCH v2 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit He Zhe
2021-05-10 22:38 ` Paul Moore
2021-05-11 3:19 ` He Zhe
2021-05-11 14:51 ` Paul Moore
2021-05-12 8:43 ` He Zhe
2021-05-14 20:33 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423103533.30121-2-zhe.he@windriver.com \
--to=zhe.he@windriver.com \
--cc=catalin.marinas@arm.com \
--cc=eparis@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).