From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FEE9C433B4 for ; Sun, 2 May 2021 14:07:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C81D86102A for ; Sun, 2 May 2021 14:07:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C81D86102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LbqUleGVi6Fm84I+5t5bZ0lt1GlVmrw5zwvuNxNm/3U=; b=UyDDbiM1NWa+ucvSquu18Qn7V zMlVKqmL45EAqhvAU7tzfi38i5gExo5NkWeegmfTO4Nx9VlHkaezwamhqSIBSPsucNZ3EzUJiSaNd q/o++hLjv1EVDUBrqtgaZGrnvWHfEhyrLRN9BwDlD4ko0+LqtzvfW945WGhU5ARWc4BJB1Nr4z0+9 VkymvqEkmiV2dgMuR5+ZJ92OumEqW8Scn1dEZXiLxqZS5++GpG3t9kIaNP+2eBJiHR8FmcmXBmZB2 b4PTFP38oEWU3CUTwJtzzlsRgkf33ICz2GqC+Q7fvCTUBBvohJPf7cEPoMNuUxo/hAoml8e0O8zo0 u+mwiqotg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldCj6-00Bt4G-Dx; Sun, 02 May 2021 14:05:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldCii-00Bswc-2r for linux-arm-kernel@desiato.infradead.org; Sun, 02 May 2021 14:05:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=I9LlAYv6m9a/Lhf0C4+UuMXHzhZ3Sg5CgxehU02txHs=; b=gkc5/HeW75UbIBV1LXJ6CL93eW MLtR+iI3cXW4XtesQS4+uR667q+oO9v1FJMerg9aya995rAO8HsgH9SWStwiNx7w8LrJj+AgM+K4J 40ICPGwhxdL34XNuuoRMwQt6ZOPkZ+jdvnJ6qW43G4pvpYkN5R+1ieno3GeNl9VGJOrUEA5tky1ik Z/S9uvNA/veY8gmXSM1j7Rvx68yCkQEos+ha2GjIKU6KbtMDz9Odz8NpkXEieIA7iGZKs2nrfaaLB cH4bMJ6giWh0HculiHVpbGoOxxICGzGJZ/KS6NvRgz0d5kS8lZMk/CLwL1D5F0+C36CmRmoWGbGUY khw9fVtg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldCif-002YUJ-MX for linux-arm-kernel@lists.infradead.org; Sun, 02 May 2021 14:05:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 866DC6102A; Sun, 2 May 2021 14:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619964313; bh=lUX4eytSW0bGZZYiuwe9s9CZeSADcmyNb4eWnzvha/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KXR3I1Z3inrnG4in57J/MruXywKCsBE8xnlcdCmjouytG7jT8XmeNyeo+rVHEfD0m lytIJKbXzie2Ytoofam3zgb7VqWQuztf2PVRvLjkPYe4TeyxdX6wPQE7SxvOH2TDev OYud/Jxt8jZydQEGCJkfRJnWagY6oCbkVa8i9dPtfEq75JinnRBWoRZcTMKFox3uD9 mVoC3pLrC8EFpJfkqsq2RMl9jZ4EX+RunomwnN2f9WRS+OZC7wbz8GMZgkuxQRKl87 US8ZDWQ7KVNd4t/2xZJAp3CUHAzVYhH+RsVPBhDjVb8w8SSAaTIV3VdcxPrvBnvXLj Fp0aaOXRenXyg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shixin Liu , Herbert Xu , Sasha Levin , linux-crypto@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 31/34] crypto: stm32/cryp - Fix PM reference leak on stm32-cryp.c Date: Sun, 2 May 2021 10:04:31 -0400 Message-Id: <20210502140434.2719553-31-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210502140434.2719553-1-sashal@kernel.org> References: <20210502140434.2719553-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210502_070513_775094_79A5D60E X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Shixin Liu [ Upstream commit 747bf30fd944f02f341b5f3bc7d97a13f2ae2fbe ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Signed-off-by: Shixin Liu Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/stm32/stm32-cryp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index ba5ea6434f9c..9b3511236ba2 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c @@ -537,7 +537,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp) int ret; u32 cfg, hw_mode; - pm_runtime_get_sync(cryp->dev); + pm_runtime_resume_and_get(cryp->dev); /* Disable interrupt */ stm32_cryp_write(cryp, CRYP_IMSCR, 0); @@ -2054,7 +2054,7 @@ static int stm32_cryp_remove(struct platform_device *pdev) if (!cryp) return -ENODEV; - ret = pm_runtime_get_sync(cryp->dev); + ret = pm_runtime_resume_and_get(cryp->dev); if (ret < 0) return ret; -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel