From: Rob Herring <robh@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: alexandre.belloni@bootlin.com, a.zummo@towertech.it,
linus.walleij@linaro.org, ulli.kroll@googlemail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml
Date: Thu, 6 May 2021 12:45:39 -0500 [thread overview]
Message-ID: <20210506174539.GA536770@robh.at.kernel.org> (raw)
In-Reply-To: <20210503195048.1575007-1-clabbe@baylibre.com>
On Mon, May 03, 2021 at 07:50:47PM +0000, Corentin Labbe wrote:
> Converts rtc/faraday,ftrtc01.txt to yaml.
> This permits to detect some missing properties: reg, resets, interrupts
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../bindings/rtc/faraday,ftrtc010.txt | 28 ---------
> .../bindings/rtc/faraday,ftrtc010.yaml | 59 +++++++++++++++++++
> 2 files changed, 59 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
> diff --git a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
> new file mode 100644
> index 000000000000..6b318650e79f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/faraday,ftrtc010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Faraday Technology FTRTC010 Real Time Clock
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: |
> + This RTC appears in for example the Storlink Gemini family of SoCs.
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: "faraday,ftrtc010"
> + - items:
> + - const: "cortina,gemini-rtc"
> + - const: "faraday,ftrtc010"
Drop quotes.
> +
> + resets:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 2
> + description: when present should contain clock references to the
> + PCLK and EXTCLK clocks. Faraday calls the later CLK1HZ and
> + says the clock should be 1 Hz, but implementers actually seem
> + to choose different clocks here, like Cortina who chose
> + 32768 Hz (a typical low-power clock).
Normal formatting is 2 space indent.
Split to use 'items' like PCI.
> +
> + clock-names:
> + items:
> + - const: "PCLK"
> + - const: "EXTCLK"
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + rtc@45000000 {
> + compatible = "cortina,gemini-rtc", "faraday,ftrtc010";
> + reg = <0x45000000 0x100>;
> + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&foo 0>, <&foo 1>;
> + clock-names = "PCLK", "EXTCLK";
> + };
> --
> 2.26.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-06 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 19:50 [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Corentin Labbe
2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
2021-05-06 10:36 ` Linus Walleij
2021-05-06 10:34 ` [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Linus Walleij
2021-05-06 17:45 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506174539.GA536770@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).