From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55550C433B4 for ; Thu, 6 May 2021 21:03:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3CAC61289 for ; Thu, 6 May 2021 21:03:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3CAC61289 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=p35wTHGuhVlR90JEsA8tMGyg6a7xBFbJTfKJtvrlj4g=; b=KJ8JYYnIQ3z17PBpg/Z83fQwz nDXRK/YnGSGmXiPAO1mmkOVC8WhXsjN0uZUwOmbf2rJ6T+dtjBza/t/0nlHAgfInRJJ1hMlfIvAr/ qpAD/gJTyJkC+Y/W+RIeXXq3yg538RgAh9QQwoQ2MuoNfwpPuv95oXRf2Vi72vB84hN/iyU1PyLJl dcWvzEhbHs+IOoZEtL7sMkQFFxm+BWMVKL4XbVlnvzHhI+Fx5GFZqqaAs6+VCnR35NEpM/sJHa4Lw dA55byJALY1tF3qNEKBtkHkK5ZcML6XBYVFj752M9fWAqgpyDFMzJHTTbbz7bhETlc76AAlSO2X6L eYMu8Eb1g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lel7d-005K6F-FG; Thu, 06 May 2021 21:01:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lel7a-005K5w-NE for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 21:01:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To :Content-ID:Content-Description:References; bh=4209ky2tpwgrvNdCwRnlsm+ZZvWbzk/ZoJnHM3WWWx4=; b=WOqJf4J/jE5+z5b1Qr9UZLKcu9 fn/DuOcXksZpSxaMwq2BpFdr5Hr+C1I+vT2rfTxGLvV3rOSSvSD4v6kvCvk3vDobMuN56pV8Ry6/4 VwkYfqqToP0tsHxr/Er/jgJVZbWHQfj1w2dYbatjUuoVr6ZuYODfuDYssviuYmEMszBXSPJ4i/mYd +eZxT+f3uaW/tRD2ooMjYiDBO9rd9I5qcsVQTPbkVMNSDdwuuGr1Ky5wTwOrUsVe9l7TahopE/tp0 ivxBIgvwMV0V18S85NMLkc5VoKl5sYwTAPt/3cDAm/zI0YpS7DBZeh+R2stbDep8GqNnNm0lJPdl1 diXs9UCQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lel7X-006OAr-Fz for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 21:01:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF21A610FA; Thu, 6 May 2021 21:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620334879; bh=atn5UYpmCJPmVfaNd52jeRUD1ASymmELvozqzIkybIA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=siGw+V7Mt/rehpoCL1CGoEe1xmiwIlC92fKqPBmkEbyQtcYNGQIoGuxVv8JfnEZNa 6a63xSXpc200o/fAWj2Q3DAwBntrdNJthxagLcspGNNl8mhiAsm688+pf5KVWOY7QW 3j+XdC15qrY81fnibpnr08hhmvj3TBfqr3k8h+EdJmfsOPzTwKACwJqaly0YI3Cnd6 Qvn+wnca3Ed5WvXBQh+7NVPfXJ6ywSh1YNofXR7XVXWFhKIUY+fKY3RnP9iWZKdVV/ /zbKJaBg/MdzGML99Nh1Yd1DhR+hTsES5UTfcI6SOIBPr5253j8wVG4lcRoXR6P7Jz a2KzfWWwKc+5g== Date: Thu, 6 May 2021 16:01:17 -0500 From: Bjorn Helgaas To: Lucas Stach Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com, bhelgaas@google.com, stefan@agner.ch Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy Message-ID: <20210506210117.GA1433800@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_140119_901316_978D6BAD X-CRM114-Status: GOOD ( 25.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 06, 2021 at 06:08:24PM +0200, Lucas Stach wrote: > Hi Lorenzo, > = > have those two patches fallen through some crack? AFAICS they are gone > from patchwork, but I also can't find them in any branch in the usual > git repos. They were marked "accepted" in patchwork but must have fallen through the cracks. I reset them to "new" and assigned to Lorenzo. Neither one follows the subject line capitalization conventions. The subject line of this patch (1/2) doesn't really make sense. I *think* this adds a property ("vph-supply") to indicate which regulator supplys power to the PHY. > Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu: > > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY. > > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data > > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design, > > the VREG_BYPASS bits of GPR registers should be cleared from default > > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > > turned on. This commit log doesn't describe the patch, either. Maybe something like this: dt-bindings: imx6q-pcie: Add "vph-supply" for PHY supply voltage The i.MX8MQ PCIe PHY can use either a 1.8V or a 3.3V power supply. Add a "vph-supply" property to indicate which regulator supplies power for the PHY. > > Signed-off-by: Richard Zhu > > Reviewed-by: Lucas Stach > > --- > > =A0Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++ > > =A01 file changed, 3 insertions(+) > > = > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b= /Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > index de4b2baf91e8..d8971ab99274 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > @@ -38,6 +38,9 @@ Optional properties: > > =A0=A0=A0The regulator will be enabled when initializing the PCIe host = and > > =A0=A0=A0disabled either as part of the init process or when shutting d= own the > > =A0=A0=A0host. > > +- vph-supply: Should specify the regulator in charge of VPH one of the= three > > + PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3= v voltage > > + supplies. Just going by examples for other drivers, I think this should say something like this: - vph-supply: Regulator for i.MX8MQ PCIe PHY. May supply either 1.8V or 3.3V. You mentioned "one of the three PCIe PHY powers"; I don't know what that means, so I don't know whether it's important to include. I also don't know what "vph" means; if the "ph" is part of "phy", it'd be nicer to include the "y", so it would be "vphy-supply". > > =A0Additional required properties for imx6sx-pcie: > > =A0- clock names: Must include the following additional entries: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel