From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7835BC433B4 for ; Fri, 7 May 2021 06:27:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2981D613DD for ; Fri, 7 May 2021 06:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2981D613DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/MxQ4yyIp3cR0+EKkFUZvmBOuUi3GijY0NObOYYKLQ8=; b=JslUKfkJEEYPDvP1C1CZ2swbG YS1LxkfUlwoy1q8O+Gnuw3xAvm6mDvTfcUHQQuBnekO7m6JXVviRaEbKNgaCUaOP4f/2CtJPmXTTo jr2JwBYVUrKzPkZ/LaumEbFYs3g7QTzBBxolPIAuvM1pKqr9S9Y+F3hUzGM8dOZBuH/QhCwAQl6qN 0PBUFGzKxHz9+Rqs0pqfr32yeDSJD4f43EwfXw75KZ31XjgmVlUdlQGo9RvrM83n2JPSu3ZHA+lRQ 1X0klCeb3MffHwbTm4pdnXUEONs1nrqZ6beIrIPjMxsTW4fisjkRXgCO+ycWDdMmY45s95DNDcpGC 0PeXNw1Uw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1letvO-006FtT-RB; Fri, 07 May 2021 06:25:23 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1letvK-006Fsa-MA for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 06:25:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uTeZ4lkVp1rRZUXOTLlqy5BR/QPwKU4dDkwNATmLCpU=; b=GyGjcqAR4o4RgbXvuZ4x2F74V9 llP8Nq7lWnYbWTfp1B0XXeTKkS6P7jcMyXBPefiIhEEcPq1M4XCK7p64zFOIvBR0QBDgOxVl3Y+la lRpaSLSftxmFHL2LJyCutY3ZFh6Ii07O7Eh5qMQB0c390AG7wMEjIpqnejTzhJVUXZs2xQZ7bU60s rlxu4bzs6cltFHK4SP1/V7/3zBezDvx0Vt/oieFp39M6zN+UmvvUVb1qQFjd/nnKmxlpbOZCoxoDk h7Yfaz3TWCoZqMNWi+WYYgSrimtrX4IOiLgaEfV8TdRZoUw/dIlTAXWQ2oOtNXL/GVQdRAqDC5MMd 4YfZagQA==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1letuw-002sn3-4o for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 06:24:58 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1476CRoH036991; Fri, 7 May 2021 14:12:27 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 7 May 2021 14:24:18 +0800 Date: Fri, 7 May 2021 14:24:17 +0800 From: Steven Lee To: Andrew Jeffery CC: Philipp Zabel , Ulf Hansson , Rob Herring , Joel Stanley , Adrian Hunter , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Chin-Ting Kuo Subject: Re: [PATCH v3 5/5] mmc: sdhci-of-aspeed: Assert/Deassert reset signal before probing eMMC Message-ID: <20210507062416.GD23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-6-steven_lee@aspeedtech.com> <20210506102458.GA20777@pengutronix.de> <19a81e25-dfa1-4ad3-9628-19f43f4230d2@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19a81e25-dfa1-4ad3-9628-19f43f4230d2@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1476CRoH036991 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_072456_906635_3E79335E X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/07/2021 09:32, Andrew Jeffery wrote: > > > On Thu, 6 May 2021, at 19:54, Philipp Zabel wrote: > > Hi Steven, > > > > On Thu, May 06, 2021 at 06:03:12PM +0800, Steven Lee wrote: > > > + if (info) { > > > + if (info->flag & PROBE_AFTER_ASSET_DEASSERT) { > > > + sdc->rst = devm_reset_control_get(&pdev->dev, NULL); > > > > Please use devm_reset_control_get_exclusive() or > > devm_reset_control_get_optional_exclusive(). > > > > > + if (!IS_ERR(sdc->rst)) { > > > > Please just return errors here instead of ignoring them. > > The reset_control_get_optional variants return NULL in case the > > device node doesn't contain a resets phandle, in case you really > > consider this reset to be optional even though the flag is set? > > It feels like we should get rid of the flag and leave it to the > devicetree. > Do you mean adding a flag, for instance, "mmc-reset" in the device tree and call of_property_read_bool() in aspeed_sdc_probe()? > I'm still kind of surprised it's not something we want to do for the > 2400 and 2500 as well. > Per discussion with the chip designer, AST2400 and AST2500 doesn't need this implementation since the chip design is different to AST2600. > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel