From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1968C433B4 for ; Fri, 7 May 2021 08:22:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F6AE6143C for ; Fri, 7 May 2021 08:22:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F6AE6143C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=beoXi2tdbyhAVCOr25TgwIZTSFAvhMhmlzXAXDQW4+0=; b=XxZgLhHdGLau3Rqb2bp5SzHFO G2YKviWNQbrE5WVE+89yMhq8eeFMOPgZ4Fl79xi0vPOqivn3BSnC/qvd81w/IINIClCVeFuis/M4r lgLVHcu7frpvqcEW7LL7Tkj7RTd6gRyaSO52ls1wppZO/8PSWndoWL9AzvCH8cA1WAIxE4tCG9HKN faDDV0s6AG++Is19Mi00CNcEh3/0bD5LOpzsIcY7oLE1QFWvGPILGjH8k+FX3xYVUkVV+/zQE3h0r whI6W1gyGpXKuaikcOV/lg6BoYJaXNCwEK+9gU/l2B80/2vGh63QcTM5DZHGqLDRhxEqbYTGu4gPw i79DD6x+w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1levj9-006UXP-4M; Fri, 07 May 2021 08:20:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1levj3-006UXC-GS for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 08:20:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7Zf3td2lxlucTeBEIjSD0gXXu1VVq4uAVnn0XY63FWU=; b=rT+aAG3f5bk+LdwSCcw1dayEta qx87dOo/rff3mMooE49CrumHszYn1K+/1imuOi38tnHN6bTcS+8z7RrASF0x4K1s84j9t17wMzHF6 +YMHYKa+kTkaFJWY1Xg8qbJrD1WEG6w+Jn0Yf5PCY5hJl5ygd9idbJ27d7j4XxxzVaCEgX2cNSDfW yPCzHs4M2x9DKsoEQd5c1O5PwBOo43cusHPELaclKHrejoB3qHoCSNXK+krCi+Z92rT/wZjUR7SaM oLGqtTn8ZALXD+/CMi9I5cJ1R+dE56AOyMcblvOSBPy8+qe2BDVq4EfRvt79P/u1qVThBlD3qFf0s g1jhs1Rw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1levj0-006glo-N2 for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 08:20:44 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1levis-0001mt-7n; Fri, 07 May 2021 10:20:34 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1levir-0003Zc-J2; Fri, 07 May 2021 10:20:33 +0200 Date: Fri, 7 May 2021 10:20:33 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Christophe JAILLET Cc: linux-fbdev@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, j.beisert@pengutronix.de, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message Message-ID: <20210507082033.ihp2ozulam72wezw@pengutronix.de> References: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de> <5cd9c8de-acd9-9594-38a0-62ecf5734c10@wanadoo.fr> MIME-Version: 1.0 In-Reply-To: <5cd9c8de-acd9-9594-38a0-62ecf5734c10@wanadoo.fr> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_012042_760362_F3913C84 X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7982821491927431368==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7982821491927431368== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k6uy7cv4js3qqvsf" Content-Disposition: inline --k6uy7cv4js3qqvsf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Christophe, [dropping krzysztof.h1@poczta.fm from recipents, the address doesn't seem to exist] On Fri, May 07, 2021 at 09:11:19AM +0200, Christophe JAILLET wrote: > Le 07/05/2021 =E0 07:05, Uwe Kleine-K=F6nig a =E9crit=A0: > > On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote: > > > 'ret' is known to be 0 here. > > > No error code is available, so just remove it from the error message. > > >=20 > > > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of d= irect pointer deref") > > > Signed-off-by: Christophe JAILLET > > > --- > > > drivers/video/fbdev/imxfb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c > > > index 7f8debd2da06..ad598257ab38 100644 > > > --- a/drivers/video/fbdev/imxfb.c > > > +++ b/drivers/video/fbdev/imxfb.c > > > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pd= ev) > > > info->screen_buffer =3D dma_alloc_wc(&pdev->dev, fbi->map_size, > > > &fbi->map_dma, GFP_KERNEL); > > > if (!info->screen_buffer) { > > > - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); > > > + dev_err(&pdev->dev, "Failed to allocate video RAM\n"); > > > ret =3D -ENOMEM; > > > goto failed_map; > > > } > >=20 > > Reviewed-by: Uwe Kleine-K=F6nig > >=20 > > Are you using this driver, or did you find that problem using some > > static checker? >=20 > No, I'm not using this driver AFAIK. OK, thanks. (We're working on a DRM driver for this hardware. So you could have been an interested tester.) Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --k6uy7cv4js3qqvsf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCU+E4ACgkQwfwUeK3K 7AkjAAgAnt/sPpkqRLMXAau9y9HiswDIt+I8Pdi7OOyx53eECYY1KD+2Lo9YSg6I 8bnnHAEmSLebkh98Wb83wa61xTi7t66L/MtIjPY+aYjg7AFWiXNmbFVQLgmXeobc L9bsN2CwMZtCsu50jJt6vVIgWrg5Ddzn7/9oiGCQNlCmSX16dmKQepIxnzEOuima XWxQrAsctEYpn7ms0MnTqVruHFKGs7jFyA0K9MQN8FD8odvLXE3/VQhmXmpCpAKY wm4LEJlqsfoasRQa1pevm5iHksq6YBNEtVOs9r6r9rLkUydHbaJLWydO/3k3Sj4S 7sKqBYyFG144lPJarkg5E77+61g39g== =tg7t -----END PGP SIGNATURE----- --k6uy7cv4js3qqvsf-- --===============7982821491927431368== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7982821491927431368==--