From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C56AC43460 for ; Fri, 7 May 2021 09:51:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B09DA613CD for ; Fri, 7 May 2021 09:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B09DA613CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jr+nQvSksHS8FLU7Ugvq7HDK/XerKQaiBCKx8Oto2Lw=; b=h/3VkqKjtHoQHhQP2wWyszQGP uCLtekPSkuLCEQsiAP4961ANv7sDCTtDHqJDssjlpZsxUOLU8i49lRds+sUbZQiYZrQkcas3dlxfl dZgHd9c5u7MRZ6NVmuj0ERRTLSaini+O7hPSLsoOIZd7rIERy5SUPiyoKcCXT4FjdmWPDTzxeSec2 z7JIONL6ZBlvprAeCtpaRIdcv6fU4mNvOBNjfxXEdO1rKS317Qc3dEkcu/HvhUwh+0ER98onkfR3H Q8OfNBPeo2vbr8ej3iewTba4QZOk7+QUbCvInjGW/ZMtytgTIQGKPcAc4E5NCsyJRXy9fBq2HaQ17 UHkjyxwUA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lex7D-006irJ-HT; Fri, 07 May 2021 09:49:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lex78-006ipz-PD for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 09:49:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J4VYpghF3MgSQ+D48VTG8tIeaNGMSReJAEdhuhEidJE=; b=XQ0SpWCMCBD6YMIIl2d3fO5QU3 d0QdvrR/MioHiGH9GeSC4jyNfKUv2bh6nIJPsPhJqsSleRKzO2pFPzfBylY0baEC5v11dzCucBXgX Q/pFCCOmqL65fiiPBhUZ/gb/ZiuYqPn+caZv39wktrxK/1eBc7XipWqi0drJZyQ2R2J7d961PzLcD hnyLO74lIFpaQX/OOLX0599Qc0bArHbkQPrEKiL3wv+yhk6Ehj23VW8Q85O1/ACqznyEBLVdfb+le lShsQBuqWirDjKDJ7NzlBn36CXXTtTR6qIRyoVXMTaOLUsSBUgcmQw0FjjW1C3vGlzaztTQgoh946 coHZY0vQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lex76-006klS-1J for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 09:49:41 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lex70-0004vV-9R; Fri, 07 May 2021 11:49:34 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lex6z-00086j-BS; Fri, 07 May 2021 11:49:33 +0200 Date: Fri, 7 May 2021 11:49:33 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Shawn Guo Cc: devicetree@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Message-ID: <20210507094933.dxtwm7vnr6ijqtup@pengutronix.de> References: <20200810084725.16112-1-u.kleine-koenig@pengutronix.de> <20200822125611.GB30094@dragon> MIME-Version: 1.0 In-Reply-To: <20200822125611.GB30094@dragon> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_024940_104823_F337BFAB X-CRM114-Status: GOOD ( 24.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5977805251192946007==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5977805251192946007== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zbspnzgd6pmnh75a" Content-Disposition: inline --zbspnzgd6pmnh75a Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Shawn, digging through my mailbox of unarchived mails I found this patch. On Sat, Aug 22, 2020 at 08:56:12PM +0800, Shawn Guo wrote: > On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-K=F6nig wrote: > > The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as >=20 > Is this how i.MX25 RM names the function? The reference manual (Rev. 2; 01/2011) doesn't give a name. The relevant description for the GPIO_A pad reads: MUX Mode Select Field. Select 1 of 7 iomux modes to be used for pad: GPIO_= A. 000: Select mux mode: ALT0 mux port: GPIO[0] of instance: gpio1. ... So I'd say: GPIO_A is the pad name (only) and the function is better named GPIO_1_0. Best regards Uwe =20 > > done for all the other pins with GPIO functionality. Fix for consistenc= y. > >=20 > > There are no mainline users that needs adaption. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > >=20 > > diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx2= 5-pinfunc.h > > index e14140e62b9b..55948e668410 100644 > > --- a/arch/arm/boot/dts/imx25-pinfunc.h > > +++ b/arch/arm/boot/dts/imx25-pinfunc.h > > @@ -563,15 +563,15 @@ > > #define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000 > > #define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000 > > =20 > > -#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000 > > +#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000 > > #define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000 > > #define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000 > > [...] --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --zbspnzgd6pmnh75a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCVDSoACgkQwfwUeK3K 7AkApwgAn12g8QeRMddUkSPCxBVJehN5K7AL4QSF174HdZQi/9QCMoyHe/ymylSt bJo1MRCpaH3/Y997Ryu7d8Y17974vQ6X16sF02c7tA17gOdJrnUTzawn1fg4xM35 Y3HMZuNBPNWMfGeiEqgFnqiusIMtTEshOcPmx+nV9E+1xZLoLGqylWEu0cXDKMkp hVO6e8xtq0M9XiVVuZwXkNDNzxXpXgJsoqeMk24TkA4q6rLQCTcIJ9kzXqfOi4+V /S15rd1h/xAbZv29w0r0IGg3z5IUOc2TX3rZiEL21QvC2x5p8cf1Dhr8kuIncQxI V/2DP//rhCvh+KgzEgTOnitdKcVI3A== =d9GS -----END PGP SIGNATURE----- --zbspnzgd6pmnh75a-- --===============5977805251192946007== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5977805251192946007==--