From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CCBC433B4 for ; Fri, 7 May 2021 16:42:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D632561431 for ; Fri, 7 May 2021 16:42:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D632561431 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=sVFobI83AUpwokKGeDyO0USRGrEY7gzCTb+mr+ms/5g=; b=n2PgrNFmDa5GNlygaxOjnn+cY TKXr7hGBgryBiLyoTiKdEpV3otT8rwxYge9thceuIZDTfM1Xl5mXA9jc2UWZUZTuTFVh+r8InxzQ7 Bx8pdYPt9Ymfi5ybUYcR1jsZqfsQfEmCeLB8Swkp+d4BmBOXkURu3YKehFwxLKjCj2WFtdHlO7FX6 9RZBXCjDVV45QqyKyNiXK1djFr8E398XARd1iMENxoB8wFk/zFmdJlbaJdWvUp0fd2Y6TX0FTi8c6 KFR3OOuRArxjK34cPdpJDBicxkOKx16mHZvRr3jYX5a3GPE/XRhTJuZY4ik8qn0TWsHtzl4McgbFn UOD1+8l3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lf3XX-007aUj-RL; Fri, 07 May 2021 16:41:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3XV-007aUZ-OV for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 16:41:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To :Content-ID:Content-Description:References; bh=AvvbNrWPgJeWv6Bs3yMjtnZ3gaW4eT/YLWoUtVJCPGc=; b=dbkFdlH5yuPunFlP9YWdyG4Ini a+4tyqzaS89Oosl0OgenZNqHaKVYEG11fEvBP4FNiRMCoCEO8ozn+RBdEVpemj9n8QIGZptxAHoNx bnWCYGc7fxoKAwJWb1TLPcLDW9r6oM3qq/6Eiiv4rNryWk5Nc+7G03oLl6FOdX0JWZP0R5D2sW0IZ 7eRrjdPzPWOV7dft22LICkDY0FbjX0/zyiUmAqsu1I7gr9Fnz+ENk1y8aen8ArZU3agHG4Euhb8y6 xDoMXH/Nhl6MW+dOepOabFkD10gT2ssu5vtVOGL82c7F9iScM18QnzY+honxQMs2lvLAlmgIFRD3A K87yRYgQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf3XS-0070mC-QJ for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 16:41:20 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0265760232; Fri, 7 May 2021 16:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620405678; bh=8qu3pcdWdcBMrLO+cWfb7Fgok5Qi7EPzYPQFmIT4w3o=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=t1dJgVdaJQCgQbGm7k3ibCU2iN3hS/7Snik0+4p63b9ctcA/i2QWfTsk32V91Q41v J+zymwDmoKMGrSkLxWJ8dyIzQEp3NqcA+RRKULMIQXr/vN1Bqqh4GJdN/ie2yVkwBc 4qHKmAVqnhN7Y4rylf1aG8rYHHtg4N6KFm3jb2sCiObfOVfjd4n6YEA4RJn/YkLbtE 3VE7xooyuAJpOO3+weSv54uS+3KPjzy7sqAlHGbaNFeESE15L9nr6POeEuKxo7FooB qhIb+sKA1XtczhbSev5CJ8Pwtk8Ws/bnjWjnz/9QGj7ThU6098sm0sHVRk1ZbFAoeG tDGhUaISjiaNQ== Date: Fri, 7 May 2021 11:41:16 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/42] PCI: pci-bridge-emul: Add PCIe Root Capabilities Register Message-ID: <20210507164116.GA1512466@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210507144015.bol3qeqsdoo7nmju@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_094118_942605_5B934EF4 X-CRM114-Status: GOOD ( 27.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 07, 2021 at 04:40:15PM +0200, Pali Roh=E1r wrote: > On Thursday 06 May 2021 18:10:09 Bjorn Helgaas wrote: > > On Thu, May 06, 2021 at 05:31:16PM +0200, Pali Roh=E1r wrote: > > > Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space= common logic") > > > Cc: stable@vger.kernel.org # e0d9d30b7354 ("PCI: pci-bridge-emul: Fix= big-endian support") > > = > > I'm not sure how people would deal with *two* SHA1s. > = > I guess that this is fine per stable document as it mention such example: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Oh, I see what you mean: the SHA1 on the stable tag is a prerequisite. I had forgotten that, but it makes sense. Thanks! > > This patch adds functionality, so it's not really fixing a bug in > > 23a5fba4d941. > = > I'm not sure what is the correct meaning of Fixes tag. I included it to > easily determinate in which commit was introduced member name "rsvd" > which should have been named "rootcap". IMO, the point of "Fixes: X" is to say that "if your kernel includes commit X, you should consider also including this patch because it fixes a problem with X." In this case, the fact that your kernel includes 23a5fba4d941 is not an indication that you should include this patch because this patch doesn't fix a defect in 23a5fba4d941. > Submitting patches document is not fully clear for me as I understood it > that Fixes and CC:stable are two different things. E.g. it mention > "Attaching a Fixes: tag does not subvert ... the requirement to Cc: > stable@vger.kernel.org on all stable patch candidates." which I > understood that patch for backporting needs to have Cc:stable: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html Yes, I think you're right. "Fixes:" by itself just indicates that this fixes a defect in a previous patch. But the fix may not rise to the level of being considered for stable, because historically we only wanted small, critical fixes for stable kernels. I think this patch should omit both Fixes: and the stable tag. If a future patch that depends on this one is a candidate for stable, *that patch* should have a stable tag with this patch as a prerequisite. Useful tidbit I found recently -- a URL like this: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/submitting-patches.rst?id=3Dv5.12#n554 is more specific and won't become stale as the doc changes. (If you follow that URL five years later, the doc will have changed so the v5.12 version will be stale, but at least the URL still makes sense in the context of this conversation.) Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel