From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91950C433ED for ; Mon, 10 May 2021 15:56:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01E6F6161C for ; Mon, 10 May 2021 15:56:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01E6F6161C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5SE1mETrwYzPY3J+xnPy9F0+Y4s8OAsiCmg0GH1XMBg=; b=Qb3TCZOhx5zzoqKt39R4ycbIk I154bCZpPgsUrMZjbjc8TbFBi/ZNbHvwi7ggNJMTmk3UnZZpidK2XhT6oUV/SikUpjpaRxlN4OCU5 vI0B8s84etwkLO4XbFtJEUWBrTnP2EF+XalVpJAk+KMsaJDoVXvfgEPHUybWIoO/ub+OWc/YmAkKO laUt1Vt3bCKVsAtmXfT8eVVWNBZdt5ikljuUEj0gmrqMSqLNyofyDyQYRXsN+zcJ6tmnFDwtrFAzP TYjR0lIo4Pvj9CEgI+261c59R5HJQngClTAa17FN/APQYpnV7OszmwckgFnOeRP5nl+CH6jXMt0Ok TE0LlN41w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg8FL-00Eq8Y-4L; Mon, 10 May 2021 15:55:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg8FI-00Eq7X-0p for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 15:55:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dKnE93StZsqCunlDWqAom0kQB6W55N5BaGWqotQGVUE=; b=qJYiuiA6ZpACNBCivHmxyx53g8 /PRFRc0QhRwNnGMdswIj5c71JJkrTIHWZCAihzqU98XsiRS/VS9tiP3g3SbpyaPvL1pMa4/0WQEa2 Gg4UDSawN+HxzspiL1Ij75EbAl154IGl0bXN2H4yNQALvXjjqxVb01O5mtSSCMwA077A+JWyTFtBn quhU2b94o22n+CdEQB1P0v6E8LE3Vk58m8pwWIr70tz3xB9OVuZ7I9I77OLdR+0UilinmzvYxB7kQ Gao8CbxRfAjHfN5LfLiXB3HqCkn0NLHyaH01Cw7gDxbcCI5T962lScfKuiN7nYZl88x6uYyWPKuzi XukrBaTg==; Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg8FF-008tEq-9w for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 15:54:58 +0000 Received: by mail-qv1-xf30.google.com with SMTP id jm10so8576932qvb.5 for ; Mon, 10 May 2021 08:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dKnE93StZsqCunlDWqAom0kQB6W55N5BaGWqotQGVUE=; b=nuCBcs9/S1aTLECuWcN5h85qoqBaLLtCmy8zbuhR+zPZIMDw77L3oRAU7xMeuDuh42 1aY3lX4gkaR/KbePkX7G1aB4Tpotsrq6rAP9gAhtcsTRhc0Gr01HHPgz83z/GnxJGBsg Bgm+850D+Iu3fWcIhJnyleMndHaJU8eu5R+J7ww9ibnhcQrnYmdXCBCA/riNKAbRtSll l1yAaUuiGbs9mNbvE3XsoU7M2UC1x/oM1anr+WkEwv0XXzudrTewGREVjZScvyVEfQdQ cELamVl6RymHsUL1VXH8Yvje4DNltTqqC+G2U/5otju6aAnXdj/94+nc1C46u8eQdS8I heCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dKnE93StZsqCunlDWqAom0kQB6W55N5BaGWqotQGVUE=; b=NVinViJle/YTRpS4UZg+vIqEFPfRnUgBRZlH3id66zqEpgYrod63zVXBTaELMAkoIS fYedtyEb4V5iUMDN68Q5j+edoVuNb8DRVodpQ2B+11AO+c9GbVjhrtJs8NwOyz8Q5Z2B X3w+SzQpOrOHHeS2lPnTly4sdsv/H+Ke2jOrq8nHexoc1kkn+kTCjDFMMqIKnNPSt3g7 zIa3Jx7cRChtAWQ5XQgdJCLMicetbLP5ZJHaS0lcrvcAu/aAgpKKvBIBIk3kTyqWjf2l FBcMjYKJR0K11CNJyMVbbQ7rAjYDyk73Gn45lnjt+6WhieFYiTePAiD8uUwe6+HBVAis D5Ag== X-Gm-Message-State: AOAM531gMeD6IrlGpxbGF3neiSm5lrfhBK8UN9XF/nXeWGXy5ybRDiqe vhXwT3OdZ9egXaJL4u4EHSstQQ== X-Google-Smtp-Source: ABdhPJxmEWE6l8G4ddQYCJA3Ydglf+qOUGmIWRC1Z06kUQgptb6+ijWYRVzLErmdhwjQdbwCc1sh8A== X-Received: by 2002:a0c:bd8c:: with SMTP id n12mr2852029qvg.29.1620662095910; Mon, 10 May 2021 08:54:55 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-113-94.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.113.94]) by smtp.gmail.com with ESMTPSA id g185sm11814969qkf.62.2021.05.10.08.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 08:54:55 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lg8FC-004bOW-Vr; Mon, 10 May 2021 12:54:55 -0300 Date: Mon, 10 May 2021 12:54:54 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Joerg Roedel , Alex Williamson , David Woodhouse , Lu Baolu , Will Deacon , Kirti Wankhede , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, kvm@vger.kernel.org Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook Message-ID: <20210510155454.GA1096940@ziepe.ca> References: <20210510065405.2334771-1-hch@lst.de> <20210510065405.2334771-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510065405.2334771-4-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_085457_363792_17DD0682 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 08:54:02AM +0200, Christoph Hellwig wrote: > The iommu_device field in struct mdev_device has never been used > since it was added more than 2 years ago. > > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/vfio_iommu_type1.c | 132 ++++++-------------------------- > include/linux/mdev.h | 20 ----- > 2 files changed, 25 insertions(+), 127 deletions(-) I asked Intel folks to deal with this a month ago: https://lore.kernel.org/kvm/20210406200030.GA425310@nvidia.com/ So lets just remove it, it is clearly a bad idea Reviewed-by: Jason Gunthorpe Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel