linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:
@ 2021-05-10 17:29 Johan Jonker
  2021-05-14 12:29 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Johan Jonker @ 2021-05-10 17:29 UTC (permalink / raw)
  To: heiko; +Cc: robh+dt, linux-rockchip, devicetree, linux-arm-kernel, linux-kernel

/arch/arm/boot/dts/rk3228-evb.dt.yaml:
pwm@110b0020: clock-names: ['pwm'] is too short

Devices with only one PWM clock use it to both to derive the functional
clock for the device and as the bus clock. The driver does not need
"clock-names" to get a handle, so remove them all.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm/boot/dts/rk322x.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 9fbd96c3f..61028a5c9 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -384,7 +384,6 @@
 		reg = <0x110b0000 0x10>;
 		#pwm-cells = <3>;
 		clocks = <&cru PCLK_PWM>;
-		clock-names = "pwm";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwm0_pin>;
 		status = "disabled";
@@ -395,7 +394,6 @@
 		reg = <0x110b0010 0x10>;
 		#pwm-cells = <3>;
 		clocks = <&cru PCLK_PWM>;
-		clock-names = "pwm";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwm1_pin>;
 		status = "disabled";
@@ -406,7 +404,6 @@
 		reg = <0x110b0020 0x10>;
 		#pwm-cells = <3>;
 		clocks = <&cru PCLK_PWM>;
-		clock-names = "pwm";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwm2_pin>;
 		status = "disabled";
@@ -417,7 +414,6 @@
 		reg = <0x110b0030 0x10>;
 		#pwm-cells = <2>;
 		clocks = <&cru PCLK_PWM>;
-		clock-names = "pwm";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwm3_pin>;
 		status = "disabled";
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:
  2021-05-10 17:29 [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error: Johan Jonker
@ 2021-05-14 12:29 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-05-14 12:29 UTC (permalink / raw)
  To: Johan Jonker
  Cc: Heiko Stuebner, robh+dt, linux-rockchip, devicetree,
	linux-arm-kernel, linux-kernel

On Mon, 10 May 2021 19:29:11 +0200, Johan Jonker wrote:
> /arch/arm/boot/dts/rk3228-evb.dt.yaml:
> pwm@110b0020: clock-names: ['pwm'] is too short
> 
> Devices with only one PWM clock use it to both to derive the functional
> clock for the device and as the bus clock. The driver does not need
> "clock-names" to get a handle, so remove them all.
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error:
      commit: dc71c5ca34f408030b979d894c0459ef059445a1

Fixed the patch subject that somehow got mangled together with
the first line of the patch message.

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-14 12:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 17:29 [PATCH] ARM: dts: rockchip: Remove more clock-names from PWM nodes A test with the command below gives this error: Johan Jonker
2021-05-14 12:29 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).