From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2A4C433B4 for ; Mon, 10 May 2021 17:10:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29D1C613CA for ; Mon, 10 May 2021 17:10:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29D1C613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ct0CPXfS0j5NDrigp2z6kfCr32kYIxBoBw430v16iwY=; b=QaKirPzcu5Yc2W0972a6Ssj99 HOKyvCFii48dbjSnAs+xNqG1Qs+Mm8s4yOAHQ/BfBUHE8ApYSD7p/2fCvwal6WUg+XQqL61Ct2y4+ xDKaKk+7dK49ByGYKsKU2nD/GYDtIhgOodzRdaEvvPRr5mLE5SFWhqD/n3QCW6vBZh5aRju0ehnl8 PkmSGaCoLRwTPtjY4eI1Fo70qQYJdOl9EuM7M2U66s2tF7fkQFJfY09TIhE4+cg4w6a0mckYAo9FA 7PkDz2PfJT1I2gXUky6vRWmf82DmvO98b41avaSju6aVjo5jvJ6BiT8Uw66qeZhiBwTXWayJY80A3 e931J3tpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg9PC-00F6Y5-0C; Mon, 10 May 2021 17:09:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9P8-00F6XU-S6 for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 17:09:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=WhrCiYHIM/oUHREob6v7c0yAAQayip0DOMoynPKexRs=; b=MJNYP8O5PoMOYH0IOIpt5l6Nxe hnZZFazM6StInF9BP/ashYmeLGTMMCLCwbBo3Je6bkygZ1ZQP+uTCql5QwEMmr9miio4I5FXg/jBk Al511mdpyd2v1iOKr42U8pfKlGUvKtOe6qnPeW8CFJ7Wsu/8gNGktX8QbVU4xjM4c/TgmhdgAKQPM lIy0+M4pLeQVAH2NdBPHnQW6AyeWfwPDw8NaHShHxu7jRZ+T9m2paL3P/gN6BM/yC4mxHNz3ACks4 xNljv/WefMGosIb3VMWZONhFqKsyXiWl/9LaapN2SEISUYhvnd9b7jqHGG5K/DKHxOeyXNZRAXwKZ +pNJymvQ==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9P6-008xe9-4u for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 17:09:13 +0000 Received: from fraeml715-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Ff6gS3zHFz70gFg; Tue, 11 May 2021 00:57:56 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml715-chm.china.huawei.com (10.206.15.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 10 May 2021 19:09:09 +0200 Received: from localhost (10.52.123.16) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 10 May 2021 18:09:08 +0100 Date: Mon, 10 May 2021 18:07:27 +0100 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Michael Turquette , Stephen Boyd , , , Alexandre Belloni , Alessandro Zummo , Mark Brown , Claudiu Beznea , Wolfram Sang , "Oleksij Rempel" , Ludovic Desroches , Thierry Reding , , Andrew Morton , , Lee Jones , , , Alexandru Ardelean Subject: Re: [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks Message-ID: <20210510180727.0000056d@Huawei.com> In-Reply-To: <20210510061724.940447-1-u.kleine-koenig@pengutronix.de> References: <20210510061724.940447-1-u.kleine-koenig@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.123.16] X-ClientProxiedBy: lhreml720-chm.china.huawei.com (10.201.108.71) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_100912_354996_4CF34A7F X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 May 2021 08:17:18 +0200 Uwe Kleine-K=F6nig wrote: > Hello, > = > this is just a resend as I didn't get any feedback in the two weeks > since the original v6 submission. Would be nice to hear something back, > I'm trying for more than half a year now to get feedback. :-\ I have a bunch of usecases in IIO, (many with local devm_add_action_or_rese= t() doing the same thing.) +CC Alex who sent out a series add more local handling of this case today. Code seems correct and clean to me, but whether the clk maintainers want to encourage this pattern is down to them (I've had similar discussions about regulators in the past where we've agreed to disagree on this topic). Jonathan > = > Best regards > Uwe > = > Uwe Kleine-K=F6nig (6): > clk: generalize devm_clk_get() a bit > clk: Provide new devm_clk_helpers for prepared and enabled clocks > pwm: atmel: Simplify using devm_clk_get_prepared() > rtc: at91sam9: Simplify using devm_clk_get_enabled() > i2c: imx: Simplify using devm_clk_get_enabled() > spi: davinci: Simplify using devm_clk_get_enabled() > = > drivers/clk/clk-devres.c | 96 ++++++++++++++++++++++++++++++------ > drivers/i2c/busses/i2c-imx.c | 12 +---- > drivers/pwm/pwm-atmel.c | 15 +----- > drivers/rtc/rtc-at91sam9.c | 22 ++------- > drivers/spi/spi-davinci.c | 11 +---- > include/linux/clk.h | 87 +++++++++++++++++++++++++++++++- > 6 files changed, 176 insertions(+), 67 deletions(-) > = > = > base-commit: a38fd8748464831584a19438cbb3082b5a2dab15 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel