From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230E8C433ED for ; Tue, 11 May 2021 10:12:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C4CE6192C for ; Tue, 11 May 2021 10:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C4CE6192C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4g28TTNKosAbZnv6Ya1hNgMgkdDIHT9O/NV2FNxoNT8=; b=Khbp1PI1WH4huJnkU+JGL4IuJ dELfnJq5dMCWRov5ZR7kxToMIOFlE6OXAlZsZBb9kAIZcicJ0BQ/MpkzeopmH2wvAtWQm9ya8x++S +QI2g7YTZjkjADT+t4o0iFms0hmNDgPBH4ifLVatSP0b+kX5WHxruAOq6jS7nhxRNKNC+LgigyAIi gUWgPzLFnS7OtpFCTYD6aOVax6zgn0BI9XZY13pj7n30u9FL2SvG+MKbBUdTrI3EQ0usyKRSm19JZ VX/lshxuuKfVZleNgl2K7iUb0iWgUMSMydPUFhcaqWTjMCz4ILk3zXZm23cpV6MrhVwb6EkrSbVvm hqlrIXN5g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgPM7-00Gqum-NA; Tue, 11 May 2021 10:11:11 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgI2a-00G6NG-Dj for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 02:22:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iTW08RKQlEMkN9MzGBUZrshqkp6B2YVcitJQPmQIOxc=; b=AGDB6QtsaxWR3GA41+laPntkjF YSwS8KHtgM7MR6PaPjTIqgEue8ubdlX7viTA2UqUr9Ip/TqW/BzrEmDd6pVgJRtHlsGvndJ5Ff3ga HsrxfVqNWbbqRmNdQz3Yf30+Xsls3cACylT3lV+1Fp/mScmlygGNpxRZVehlg3hy+qaCwuZ1DVFVV gZp7tXL02QOnBJRH+FUnWwE9cQPhwrlaunsnD8yFo3KieCQxfDECAYLtWSSUpckHloAubV7IjR7S4 hQWHIW36gr9I2/DX4mSoQXMSpINuETGfrZG6gqbSgAxMZgkNwvVN8MFADdShjxezQPT+hDi44KJSW EBHZ4Gog==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgI2X-009G42-Pg for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 02:22:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7F0E6162B; Tue, 11 May 2021 02:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620699749; bh=J49dWfDtr/uMNE/FC4yL9V1Co9tZspE5lpR1SyxOHjI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TpsjRagjADiC1FUuy2fCOnZL1eoYMaycgp44lLT/0ugp4Uc5b87Vkf3z/PfxXLpOL SFN+wNCjPzeLCpDHm7nzLJphs9OcP5SQxNEMrMnulAyt6qBCwLwJZ8CfHoVfENkHye 5aXeThsD/0k+BqOdfIBgCn7ZJlcSr09FrpAPRDiTamBvEnLpeKRqMJnGs2tiKy3aBN nQT1/qwbinEV4GMBBx44UqtYZ9Q1v4Io4MVybbSOCzst+47PhWr4Ot9W4+rKpHYDFA S0etXL9L21PVGOFJQlqVHqrBPrjAi4diWzGJ+j9Dub0KCyhR/IFSc31cwfXuRMm2PK Wct5kJPnW0gvw== Date: Tue, 11 May 2021 10:22:23 +0800 From: Shawn Guo To: Adrien Grassein Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, catalin.marinas@arm.com, will@kernel.org, bjorn.andersson@linaro.org, krzk@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support Message-ID: <20210511022222.GB3425@dragon> References: <20210331232356.2204476-1-adrien.grassein@gmail.com> <20210331232356.2204476-3-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210331232356.2204476-3-adrien.grassein@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_192229_875270_2D080943 X-CRM114-Status: GOOD ( 17.45 ) /bin/ln: failed to access 'reaver_cache/texts/20210510_192229_875270_2D080943': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_192229_875270_2D080943 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 01, 2021 at 01:23:54AM +0200, Adrien Grassein wrote: > Add the description for the USB host port. > This port is linked to a resettable USB HUB so handle > this reset signal with a GPIO hog. > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mq-nitrogen.dts | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > index b46f45a82be1..04992cbba56e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > @@ -102,6 +102,14 @@ ethphy0: ethernet-phy@4 { > }; > }; > > +&gpio1 { > + usb-host-reset-hog { > + gpio-hog; > + gpios = <14 GPIO_ACTIVE_HIGH>; > + output-high; > + }; > +}; > + > &i2c1 { > clock-frequency = <400000>; > pinctrl-names = "default"; > @@ -213,6 +221,22 @@ &usb3_phy0 { > status = "okay"; > }; > > +&usb_dwc3_1 { > + dr_mode = "host"; > + status = "okay"; > +}; > + > +/* > + * On this board, USB host is connected to a resettable hub. > + * The reset signal is connected to the GPIO <&gpio1 14 GPIO_ACTIVE_LOW>. > + * You need to activate it in the bootloader or in the userspace. > + */ > +&usb3_phy1 { > + status = "okay"; We usually end property list with 'status'. Shawn > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb3_1>; > +}; > + > &usdhc1 { > assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>; > assigned-clock-rates = <400000000>; > @@ -388,6 +412,12 @@ MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC 0x16 > >; > }; > > + pinctrl_usb3_1: usb3-1grp { > + fsl,pins = < > + MX8MQ_IOMUXC_GPIO1_IO14_GPIO1_IO14 0x16 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x83 > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel