* [PATCH 1/1] tty: serial: sifive: Remove redundant error printing in sifive_serial_probe()
@ 2021-05-11 9:54 Zhen Lei
0 siblings, 0 replies; only message in thread
From: Zhen Lei @ 2021-05-11 9:54 UTC (permalink / raw)
To: Claudiu Beznea, Sebastian Reichel, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, linux-pm, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/tty/serial/sifive.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c
index 0ac0371f943b688..4b28b5ae72899cf 100644
--- a/drivers/tty/serial/sifive.c
+++ b/drivers/tty/serial/sifive.c
@@ -947,10 +947,8 @@ static int sifive_serial_probe(struct platform_device *pdev)
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
base = devm_ioremap_resource(&pdev->dev, mem);
- if (IS_ERR(base)) {
- dev_err(&pdev->dev, "could not acquire device memory\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(clk)) {
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-11 12:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 9:54 [PATCH 1/1] tty: serial: sifive: Remove redundant error printing in sifive_serial_probe() Zhen Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).