From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD3DC433ED for ; Tue, 11 May 2021 17:22:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F1D4611CA for ; Tue, 11 May 2021 17:22:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F1D4611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bewjLKXIaWTWMj5Q7SeNnarg0hsQ6weSGsRNzIdUiYw=; b=m8JncurbfP+0VahhZxqw3TIua BkwW00W8sGCi4KHQjXUoQaFQvxm+5dR6DmBHVycecrYQlpO2v8U0WAWyfHSpBfTcn/t2ytZKiKk7o KblW9bROHD+YUjBOMHbKHLjMvClVP02o7dS6+hAIaZZk0SoIz9MAvorWP9HKXY2xaUfK6Xeuo2u9e U6a1tXlcOcs2GBefNzM0v0NGr3lqUXXl4sKzvGLjlPf3IdZ8Y93P6+pQc3r5QC8XHfxqY4B9Lf9pu WrrgXXDnQ5g2gsvVGEGbWYyUvRAfAFyjWYJEwy9stRzLDKw5QKiTRmQpbI47TVYzk9tKA1d/C4ayX WZokhPH0w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgW3d-000u0w-SB; Tue, 11 May 2021 17:20:34 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgW3Y-000u0O-LB for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 17:20:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mw4M6QD5ev4WL40MWqnaVGH00M0PQutnLhNdkwAP+5M=; b=iNhJjtsiXnE0theoEzhX5EpcXK gxu+zKhgRC1L4GaIYuiU8OrMWZ+xbtGhR7uUY0Ov3Wy7GUBfm3+D0CYa4YrMUFayR7YOIMGtzoS00 SuaabF6/0k+oAGoLGOw1JdsbRDQ+nF7GOzG0JJ9+ZTRCaRScxSEXvTox6mGElJ6v905fMQURmwhss 2ey+Bzf0OY7iud+LZVP/lo2zuCu5r8TZsXSUD8H6JM4RetBdDUnG7TZbFhdwyaBo5sxY8RLVEnkUw lsXLpUAJmr7ALoJbY2LvYMB6tirTyeaNaRVeRzCz+hhT45AknoQz6wLqu1tgCpk8IktyHN6ESJGMV rltVhiYQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgW3V-009o4j-QQ for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 17:20:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A28261261; Tue, 11 May 2021 17:20:23 +0000 (UTC) Date: Tue, 11 May 2021 18:20:20 +0100 From: Catalin Marinas To: Luo Longjun Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sangyan@huawei.com, ningyu9@huawei.com, luchunhua@huawei.com, Matthias Brugger , Enric Balletbo i Serra Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP Message-ID: <20210511172020.GB21033@arm.com> References: <20210507182410.10515-1-luolongjun@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210507182410.10515-1-luolongjun@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_102025_906231_FF23A9C5 X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote: > When I compile kernel in ARM64, it produces the following output: > > *** Default configuration is based on 'defconfig' > arch/arm64/configs/defconfig:1018:warning: override: reassigning to > symbol MTK_PMIC_WRAP > > After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options. > > Signed-off-by: Luo Longjun > --- > arch/arm64/configs/defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 08c6f769df9a..9907a431db0d 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y > CONFIG_SPI_SH_MSIOF=m > CONFIG_SPI_SUN6I=y > CONFIG_SPI_SPIDEV=m > -CONFIG_MTK_PMIC_WRAP=m > CONFIG_SPMI=y > CONFIG_PINCTRL_SINGLE=y > CONFIG_PINCTRL_MAX77620=y Adding Matthias and Enric. This change looks fine to me but I think it should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m option while commit fbbe38309d56 introduced the =y variant. You could add: Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel