From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E355C433B4 for ; Wed, 12 May 2021 20:10:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ACE3613FB for ; Wed, 12 May 2021 20:10:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ACE3613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5oYI8CjfqL0OLstkHMxyZq9VZuKjFDD19cZ+nGG+4ac=; b=jLqnjHgBLwMpSmcHO37zS9OfR n7BG+RMk26MnJ7LugI4jRjCPigmRmEdtyS3el1tlyds8TIesFlGWqB1LLcwoCN0yeIpSRB5LHduvK yE67sqtHyqVP26hRcq/cTuP2oBL9WvBGdqQkIJhrZezAI7q+XomfKYeQrGlfIeFFlj2uMD57EqEJ+ tBh7dLadhByyJpKMAetqw454jQOgHYrdU+YQD7CCy+hAXhCX4Q9b3knoFPjiO9bhW+P/itBnJ3OoN mk0Ro5u7whVk/tQnqXjGR0R2GgIRwL5SeGNTQPrTyP99naILsjrh/vMzrJg9XPZa0cmFQTF6pGhVC Hz1AB+MOw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgv9C-003rCY-Cw; Wed, 12 May 2021 20:07:59 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7u-003qrp-RH for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:06:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QZOu937T06FGYysrX40DfRIEifPnkgP2wpT5ChbrOLM=; b=lJL8RCDaSMjBZD4cx23I3vQX94 965uODIOkBdjDIzooyIms1ENrlStB38Kqt6+BkFhnpRwLsrnCGR8muflgtTHgIvbWZqKrxN00XKY1 GMw5OgRrPkbYCL/94U38plUwWb8bZcBpUqh4vVirq6/ASTdD8q5By2VD9AtZ8BHlzNev3PZGc+uEk XEVpOhwC4kusJOlbtd3tGsFkdyfWio2nkYKHf1m27mIzXKgCukFeywoW7iHwspcenpTYaA87EuPgC ZnK7lngQfdRpdvAvSiYfjdrgQuEqKhGr5PotrbhEf96ML07Q08idGbywAx425WksfO7RNZDX1Bg7b EymPeJPw==; Received: from mail-oi1-f170.google.com ([209.85.167.170]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7s-00Amlo-0g for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:06:37 +0000 Received: by mail-oi1-f170.google.com with SMTP id w22so9511097oiw.9 for ; Wed, 12 May 2021 13:06:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QZOu937T06FGYysrX40DfRIEifPnkgP2wpT5ChbrOLM=; b=ip+WTcOu6a8VNYNht7s+h0Rg/Bk3DWR7JAJBJDPRKcIYdH40dRzyDTGZ+ZLeLPXnCw aesYsM0y6YCYnV1DcskIbwLxbBHbbYuDqkyczMa56QUtwSL/Iczo9BA5MFiZF9HIe29v RXa82Z6PSb9l6JQ8cVp8bqU5E+8BE9mGs5Sj+wkve8dWQlJKX+XybMeJ7WJB7ieB8AFW NwmYM9eQ6emKPvxR9Z2+Iqs/ciqeNkdqGhht+4RXumLHKsu44Bko8BWIxNP3EZuSjgIO bNqfe8w+yJI+WJZZkhaJtR6L5KjXXbsa0x9QnV07RdoJbeY3eRcNZQkCdPmvsikxpsDo hUjA== X-Gm-Message-State: AOAM532u79YYFc9r4IvI2anNKbjROout+vfyjpSBp+OP9ob4zc0CGhNk sr+c0pfGVkWXWOVQ9KjRVQ== X-Google-Smtp-Source: ABdhPJyFestwfEyHgdtvQESLKDKYdJEwVqw5rAmNlfsvq9xl609Ay/5t03I4TO2cGO9CWGnLqGNXZg== X-Received: by 2002:a05:6808:561:: with SMTP id j1mr189039oig.24.1620849994987; Wed, 12 May 2021 13:06:34 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d19sm172127oti.57.2021.05.12.13.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 13:06:34 -0700 (PDT) Received: (nullmailer pid 2429755 invoked by uid 1000); Tue, 11 May 2021 19:00:57 -0000 Date: Tue, 11 May 2021 14:00:57 -0500 From: Rob Herring To: Shengjiu Wang Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: imx-akcodec: Add binding doc for akcodec machine driver Message-ID: <20210511190057.GA2416585@robh.at.kernel.org> References: <1620630441-14358-1-git-send-email-shengjiu.wang@nxp.com> <1620630441-14358-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1620630441-14358-2-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_130636_085795_D3703D73 X-CRM114-Status: GOOD ( 23.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 03:07:21PM +0800, Shengjiu Wang wrote: > Imx-akcodec is a new added machine driver for supporting > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > Signed-off-by: Shengjiu Wang > --- > changes in v2: > - update doc accoring to Rob's comment, use the common porperties. > > .../bindings/sound/imx-audio-akcodec.yaml | 107 ++++++++++++++++++ > 1 file changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > new file mode 100644 > index 000000000000..0812c4779b59 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-audio-akcodec > + - fsl,imx-audio-akcodec We gone from individual codecs to a family of codecs. Is there something specific for the machine driver about this set of codecs? Why can't it be *any* codec? > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. Valid names could be power supplies, > + MicBias of codec and the jacks on the board. > + > +patternProperties: > + ".*-dai-link$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + format: > + description: audio format. > + items: > + enum: > + - i2s > + - dsp_b > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + properties: > + sound-dai: true > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + properties: > + sound-dai: true > + > + required: > + - link-name > + - cpu > + > + additionalProperties: false > + > +required: > + - compatible > + - model > + > +additionalProperties: false > + > +examples: > + - | > + sound-ak4458 { > + compatible = "fsl,imx-audio-akcodec"; > + model = "ak4458-audio"; > + pri-dai-link { > + link-name = "akcodec"; > + format = "i2s"; > + cpu { > + sound-dai = <&sai1>; > + }; > + codec { > + sound-dai = <&ak4458_1>, <&ak4458_2>; > + }; > + }; > + fe-dai-link { > + link-name = "HiFi-ASRC-FE"; > + format = "i2s"; > + cpu { > + sound-dai = <&easrc>; > + }; > + }; > + be-dai-link { > + link-name = "HiFi-ASRC-BE"; > + format = "dsp_b"; > + cpu { > + sound-dai = <&sai1>; > + }; > + codec { > + sound-dai = <&ak4458_1>, <&ak4458_2>; > + }; > + }; > + }; > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel