From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>,
Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: fix memory node
Date: Thu, 13 May 2021 10:15:35 +0800 [thread overview]
Message-ID: <20210513021535.GK3425@dragon> (raw)
In-Reply-To: <20210408110219.20149-1-michael@walle.cc>
+ Bhaskar
On Thu, Apr 08, 2021 at 01:02:18PM +0200, Michael Walle wrote:
> While enabling EDAC support for the LS1028A it was discovered that the
> memory node has a wrong endianness setting as well as a wrong interrupt
> assignment. Fix both.
>
> This was tested on a sl28 board. To force ECC errors, you can use the
> error injection supported by the controller in hardware (with
> CONFIG_EDAC_DEBUG enabled):
>
> # enable error injection
> $ echo 0x100 > /sys/devices/system/edac/mc/mc0/inject_ctrl
> # flip lowest bit of the data
> $ echo 0x1 > /sys/devices/system/edac/mc/mc0/inject_data_lo
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
Bhaskar,
Does it look good to you?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 9506f0669ead..040a3e529bf1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -197,8 +197,8 @@
> ddr: memory-controller@1080000 {
> compatible = "fsl,qoriq-memory-controller";
> reg = <0x0 0x1080000 0x0 0x1000>;
> - interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> - big-endian;
> + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> + little-endian;
> };
>
> dcfg: syscon@1e00000 {
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-13 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:02 [PATCH 1/2] arm64: dts: ls1028a: fix memory node Michael Walle
2021-04-08 11:02 ` [PATCH 2/2] arm64: defconfig: enable Layerscape EDAC driver Michael Walle
2021-05-13 2:15 ` Shawn Guo [this message]
2021-05-22 12:34 ` [PATCH 1/2] arm64: dts: ls1028a: fix memory node Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513021535.GK3425@dragon \
--to=shawnguo@kernel.org \
--cc=bhaskar.upadhaya@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).